[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1296: Check deserialize result when save meta

chaoyli commented on a change in pull request #1296: Check deserialize result when save meta URL: https://github.com/apache/incubator-doris/pull/1296#discussion_r293206659 ## File path: be/src/olap/tablet_meta.h ## @@ -235,7 +237,7 @@ inline const int16_t TabletMeta::shard

[GitHub] [incubator-doris] imay merged pull request #1295: Fix bug that get_json_function may not be able to get result

imay merged pull request #1295: Fix bug that get_json_function may not be able to get result URL: https://github.com/apache/incubator-doris/pull/1295 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] morningman closed pull request #1295: Fix bug that get_json_function may not be able to get result

morningman closed pull request #1295: Fix bug that get_json_function may not be able to get result URL: https://github.com/apache/incubator-doris/pull/1295 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] morningman opened a new pull request #1295: Fix bug that get_json_function may not be able to get result

morningman opened a new pull request #1295: Fix bug that get_json_function may not be able to get result URL: https://github.com/apache/incubator-doris/pull/1295 std::string object is unexpectedly deconstructed, cause invalid result. ISSUE: #1294 ---

[GitHub] [incubator-doris] yiguolei opened a new pull request #1296: Check deserialize result when save meta

yiguolei opened a new pull request #1296: Check deserialize result when save meta URL: https://github.com/apache/incubator-doris/pull/1296 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #1289: Modify colocation creation logic

morningman commented on a change in pull request #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r293186643 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -31,6 +31,8 @@ import org

[GitHub] [incubator-doris] morningman commented on a change in pull request #1289: Modify colocation creation logic

morningman commented on a change in pull request #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r293186541 ## File path: fe/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java ## @@ -277,6 +284,12 @@ pu

[GitHub] [incubator-doris] morningman opened a new pull request #1295: Fix bug that get_json_function may not be able to get result

morningman opened a new pull request #1295: Fix bug that get_json_function may not be able to get result URL: https://github.com/apache/incubator-doris/pull/1295 std::string object is unexpectedly deconstructed, cause invalid result. ISSUE: #1294 ---

[GitHub] [incubator-doris] morningman opened a new issue #1294: Get json function returns unexpected result

morningman opened a new issue #1294: Get json function returns unexpected result URL: https://github.com/apache/incubator-doris/issues/1294 **Describe the bug** `select get_json_int('{"123456789" : {"abcefg":6,"abc":10}}', "$.123456789.abcefg");` should return `6`, but actual is `NULL

[GitHub] [incubator-doris] imay commented on a change in pull request #1289: Modify colocation creation logic

imay commented on a change in pull request #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r292979555 ## File path: fe/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java ## @@ -277,6 +284,12 @@ public s

[GitHub] [incubator-doris] imay commented on a change in pull request #1289: Modify colocation creation logic

imay commented on a change in pull request #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#discussion_r292981569 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -31,6 +31,8 @@ import org.apach

[GitHub] [incubator-doris] chaoyli merged pull request #1293: Change default value to NOT NULL when creating table

chaoyli merged pull request #1293: Change default value to NOT NULL when creating table URL: https://github.com/apache/incubator-doris/pull/1293 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292820315 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.ja

[GitHub] [incubator-doris] chaoyli opened a new pull request #1293: Change default value to NOT NULL when creating table

chaoyli opened a new pull request #1293: Change default value to NOT NULL when creating table URL: https://github.com/apache/incubator-doris/pull/1293 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292817997 ## File path: fe/src/main/java/org/apache/doris/analysis/VirtualSlotRef.java

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292812477 ## File path: fe/src/main/java/org/apache/doris/analysis/GroupByClause.java

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292810059 ## File path: fe/src/main/java/org/apache/doris/analysis/GroupByClause.java

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292804954 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -3111,9 +3114,52 @@

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292803921 ## File path: fe/src/test/java/org/apache/doris/analysis/GroupByClauseTest.java

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

chenhao7253886 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292805700 ## File path: fe/src/main/java/org/apache/doris/analysis/Analyzer.java

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292803477 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

EmmyMiao87 commented on a change in pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292#discussion_r292802485 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -194,12 +195,12 @@

[GitHub] [incubator-doris] morningman commented on a change in pull request #1286: Add thirdparty lib

morningman commented on a change in pull request #1286: Add thirdparty lib URL: https://github.com/apache/incubator-doris/pull/1286#discussion_r292800117 ## File path: thirdparty/vars.sh ## @@ -247,6 +247,24 @@ S2_NAME=s2geometry-0.9.0.tar.gz S2_SOURCE=s2geometry-0.9.0 S2

[GitHub] [incubator-doris] lide-reed opened a new pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement

lide-reed opened a new pull request #1292: Support Grouping Sets, Rollup and Cube to extend group by statement URL: https://github.com/apache/incubator-doris/pull/1292 This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] morningman opened a new pull request #1289: Modify colocation

morningman opened a new pull request #1289: Modify colocation URL: https://github.com/apache/incubator-doris/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] morningman opened a new issue #1291: Modify colocation feature

morningman opened a new issue #1291: Modify colocation feature URL: https://github.com/apache/incubator-doris/issues/1291 # 修改 Colocation 的创建逻辑 之前的实现中，用户需要先创建一个 parent table，然后在创建1个或多个 child table关联到 parent table。同时在 table 对象中记录了一个 colocateTable 对象，其中是 parent table 的名字。 这个实现有一些问题，

[GitHub] [incubator-doris] chaoyli edited a comment on issue #1290: Rollup data is in chaos with base table

chaoyli edited a comment on issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290#issuecomment-501170905 The problem is addressed in #1287 This is an automated messag

[GitHub] [incubator-doris] chaoyli merged pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming …

chaoyli merged pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming … URL: https://github.com/apache/incubator-doris/pull/1287 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] chaoyli closed issue #1290: Rollup data is in chaos with base table

chaoyli closed issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] chaoyli commented on issue #1290: Rollup data is in chaos with base table

chaoyli commented on issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290#issuecomment-501170905 The problem is address in #1287 This is an automated message from th

[GitHub] [incubator-doris] chaoyli commented on issue #1290: Rollup data is in chaos with base table

chaoyli commented on issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290#issuecomment-501170439 We should modify the check logic to handle SegmentGroups. This is an

[GitHub] [incubator-doris] chaoyli commented on issue #1287: Fix creating rollup bug from multi SegmentGroups generated streaming …

chaoyli commented on issue #1287: Fix creating rollup bug from multi SegmentGroups generated streaming … URL: https://github.com/apache/incubator-doris/pull/1287#issuecomment-501170652 The related issue is #1290 This is an a

[GitHub] [incubator-doris] chaoyli commented on issue #1290: Rollup data is in chaos with base table

chaoyli commented on issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290#issuecomment-501170099 There is a bug when creating rollup from Delta generated by Streaming Load. If the delta includes many SegmentGroups, only last segm

[GitHub] [incubator-doris] chaoyli commented on issue #1290: Rollup data is in chaos with base table

chaoyli commented on issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290#issuecomment-501169225 The reproduce procedure: 1. Ingesting a file with large size in streaming load, which will be saved as many segments. 2. Create

[GitHub] [incubator-doris] chaoyli opened a new issue #1290: Rollup data is in chaos with base table

chaoyli opened a new issue #1290: Rollup data is in chaos with base table URL: https://github.com/apache/incubator-doris/issues/1290 ``` CREATE TABLE IF NOT EXISTS test_db.user_log ( `phone` BIGINT NOT NULL , `dt` BIGINT NOT NULL , `pv` BIGINT , `rule_id` BIGINT , `theme

[GitHub] [incubator-doris] imay merged pull request #1288: Add description of strict mode in decimal type

imay merged pull request #1288: Add description of strict mode in decimal type URL: https://github.com/apache/incubator-doris/pull/1288 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] imay commented on a change in pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming …

imay commented on a change in pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming … URL: https://github.com/apache/incubator-doris/pull/1287#discussion_r292788549 ## File path: be/src/olap/olap_table.cpp ## @@ -1867,8 +1867,19 @@ void O

[GitHub] [incubator-doris] morningman closed pull request #1289: Modify colocation

morningman closed pull request #1289: Modify colocation URL: https://github.com/apache/incubator-doris/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] morningman opened a new pull request #1289: Modify colocation

morningman opened a new pull request #1289: Modify colocation URL: https://github.com/apache/incubator-doris/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1288: Add description of strict mode in decimal type

EmmyMiao87 opened a new pull request #1288: Add description of strict mode in decimal type URL: https://github.com/apache/incubator-doris/pull/1288 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] chaoyli opened a new pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming …

chaoyli opened a new pull request #1287: Fix creating rollup bug from multi SegmentGroups generated streaming … URL: https://github.com/apache/incubator-doris/pull/1287 …load. In streaming load, one version will generate mutli SegmentGroups. Upon creating rollup, the previous code

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1286: Add thirdparty lib

kangpinghuang opened a new pull request #1286: Add thirdparty lib URL: https://github.com/apache/incubator-doris/pull/1286 add bitshuffle and CRoaring Bitmap lib This is an automated message from the Apache Git Service. To res