[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290146308 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290145895 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290145895 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] imay opened a new issue #1246: Make MySQL optional

2019-06-03 Thread GitBox
imay opened a new issue #1246: Make MySQL optional URL: https://github.com/apache/incubator-doris/issues/1246 Now, we support scanning MySQL table. we use libmysqlclient.a whose license is GPLv2, which is not compatible with APLv2. we should make it optional so that we can make it an

[GitHub] [incubator-doris] imay commented on a change in pull request #1237: Change strategy of incorrect data

2019-06-03 Thread GitBox
imay commented on a change in pull request #1237: Change strategy of incorrect data URL: https://github.com/apache/incubator-doris/pull/1237#discussion_r290139546 ## File path: docs/documentation/cn/administrator-guide/config/be_config.md ## @@ -0,0 +1,20 @@ +# be ��˵�

[GitHub] [incubator-doris] morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290135848 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
EmmyMiao87 commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290135798 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

Re:Re: [VOTE] Release Apache Doris 0.10.0-incubating-rc02

2019-06-03 Thread 陈明雨
Hi Dave: Thanks for you check. LZ4: Yes, we just use the files in libs/, which are in Doris code: be/src/exec/decompressor.h/cpp So I think this is OK. LZO: Since it is under GPL2 license, we will change this compressor as a optional feature when build Doris. RapidJson: MIT/BSD seems comp

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290133953 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] morningman merged pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
morningman merged pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] chenhao7253886 merged pull request #1245: Add converter to convert expression to plan node

2019-06-03 Thread GitBox
chenhao7253886 merged pull request #1245: Add converter to convert expression to plan node URL: https://github.com/apache/incubator-doris/pull/1245 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] imay opened a new pull request #1245: Add converter to convert expression to plan node

2019-06-03 Thread GitBox
imay opened a new pull request #1245: Add converter to convert expression to plan node URL: https://github.com/apache/incubator-doris/pull/1245 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290123942 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -662,6 +662,24

[GitHub] [incubator-doris] morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240#discussion_r290123896 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -294,6 +294

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen opened a new pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240 Fix https://github.com/apache/incubator-doris/issues/1239 This is an automated m

[GitHub] [incubator-doris] imay closed pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
imay closed pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay closed pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
imay closed pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] imay opened a new pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
imay opened a new pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238 Before RowBlock will reserve memory for all columns in schema, even if it is not queried. Which will cause bad performance when quering wide table. In thi

[GitHub] [incubator-doris] morningman closed issue #1242: Upgrade BRPC to 0.9.5

2019-06-03 Thread GitBox
morningman closed issue #1242: Upgrade BRPC to 0.9.5 URL: https://github.com/apache/incubator-doris/issues/1242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] morningman merged pull request #1243: Upgrade brpc to 0.9.5

2019-06-03 Thread GitBox
morningman merged pull request #1243: Upgrade brpc to 0.9.5 URL: https://github.com/apache/incubator-doris/pull/1243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] kangkaisen commented on issue #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
kangkaisen commented on issue #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#issuecomment-498502628 > @kangkaisen > `Save the small file content to FE metadata is necessary? could we save the small file content i

[GitHub] [incubator-doris] imay merged pull request #1244: fixup leak memory

2019-06-03 Thread GitBox
imay merged pull request #1244: fixup leak memory URL: https://github.com/apache/incubator-doris/pull/1244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] morningman edited a comment on issue #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
morningman edited a comment on issue #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#issuecomment-498496714 @kangkaisen `Save the small file content to FE metadata is necessary? could we save the small file conte

[GitHub] [incubator-doris] worker24h opened a new pull request #1244: fixup leak memory

2019-06-03 Thread GitBox
worker24h opened a new pull request #1244: fixup leak memory URL: https://github.com/apache/incubator-doris/pull/1244 When I declared that the compilation mode was BUILD_TYPE=LSAN, there was a memory leak after running doris. be.out: Direct leak of 32816 byte(s) in 1 object(s) all

[GitHub] [incubator-doris] kangpinghuang closed pull request #1241: Add new format file api

2019-06-03 Thread GitBox
kangpinghuang closed pull request #1241: Add new format file api URL: https://github.com/apache/incubator-doris/pull/1241 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] morningman commented on issue #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
morningman commented on issue #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#issuecomment-498496714 @kangkaisen This is an automated message from the

[GitHub] [incubator-doris] morningman commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r290106749 ## File path: fe/src/test/java/org/apache/doris/common/util/SmallFileMgrTest.java ###

[GitHub] [incubator-doris] morningman commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r290106759 ## File path: fe/src/main/java/org/apache/doris/common/util/KafkaUtil.java ## @@

[GitHub] [incubator-doris] imay opened a new pull request #1243: Upgrade brpc to 0.9.5

2019-06-03 Thread GitBox
imay opened a new pull request #1243: Upgrade brpc to 0.9.5 URL: https://github.com/apache/incubator-doris/pull/1243 Fix #1242 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay closed pull request #1243: Upgrade brpc to 0.9.5

2019-06-03 Thread GitBox
imay closed pull request #1243: Upgrade brpc to 0.9.5 URL: https://github.com/apache/incubator-doris/pull/1243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] imay commented on a change in pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
imay commented on a change in pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238#discussion_r290099274 ## File path: be/src/olap/row_block.cpp ## @@ -314,51 +115,29 @@ void RowBlock::clear() { } void RowBlock::_com

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
kangpinghuang commented on a change in pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238#discussion_r290095012 ## File path: be/src/olap/row_block.cpp ## @@ -314,51 +115,29 @@ void RowBlock::clear() { } void RowB

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r289698255 ## File path: fe/src/main/java/org/apache/doris/analysis/CreateFileStmt.java ##

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
kangkaisen commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r289696806 ## File path: docs/help/Contents/Data Definition/ddl_stmt.md ## @@ -595,9 +595,9

Re: [VOTE] Release Apache Doris 0.10.0-incubating-rc02

2019-06-03 Thread Dave Fisher
Hi - Apologies for the delay. I am in process of doing the review and I have questions about some of the third party dependencies that are licensed in Category X (https://www.apache.org/legal/resolved#category-x ) In an official release these may be used as dependencies if they are optional fu

[GitHub] [incubator-doris] imay commented on issue #1242: Upgrade BRPC to 0.9.5

2019-06-03 Thread GitBox
imay commented on issue #1242: Upgrade BRPC to 0.9.5 URL: https://github.com/apache/incubator-doris/issues/1242#issuecomment-498287464 apache/incubator-brpc#283 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] imay opened a new pull request #1243: Upgrade brpc to 0.9.5

2019-06-03 Thread GitBox
imay opened a new pull request #1243: Upgrade brpc to 0.9.5 URL: https://github.com/apache/incubator-doris/pull/1243 Fix #1242 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay opened a new issue #1242: Upgrade BRPC to 0.9.5

2019-06-03 Thread GitBox
imay opened a new issue #1242: Upgrade BRPC to 0.9.5 URL: https://github.com/apache/incubator-doris/issues/1242 **Describe the bug** We use json2pb in our UT, but we meet BRPC's [bug](https://github.com/apache/incubator-brpc/issues/283). So we need to upgrade our BRPC depende

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1241: Add new format file api

2019-06-03 Thread GitBox
kangpinghuang opened a new pull request #1241: Add new format file api URL: https://github.com/apache/incubator-doris/pull/1241 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] morningman commented on a change in pull request #1237: Change strategy of incorrect data

2019-06-03 Thread GitBox
morningman commented on a change in pull request #1237: Change strategy of incorrect data URL: https://github.com/apache/incubator-doris/pull/1237#discussion_r289786192 ## File path: be/src/common/config.h ## @@ -419,6 +419,11 @@ namespace config { // same cache size

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1240: Fix IllegalArgumentException in LoadManager

2019-06-03 Thread GitBox
kangkaisen opened a new pull request #1240: Fix IllegalArgumentException in LoadManager URL: https://github.com/apache/incubator-doris/pull/1240 Fix https://github.com/apache/incubator-doris/issues/1239 This is an automated m

[GitHub] [incubator-doris] kangkaisen opened a new issue #1239: IllegalArgumentException when loadLoadJobsV2

2019-06-03 Thread GitBox
kangkaisen opened a new issue #1239: IllegalArgumentException when loadLoadJobsV2 URL: https://github.com/apache/incubator-doris/issues/1239 **Describe the bug** ``` java.lang.IllegalArgumentException: No enum constant org.apache.doris.load.EtlJobType. at java.base/java.l

[GitHub] [incubator-doris] imay opened a new pull request #1238: Reduce memory RowBlock needed

2019-06-03 Thread GitBox
imay opened a new pull request #1238: Reduce memory RowBlock needed URL: https://github.com/apache/incubator-doris/pull/1238 Before RowBlock will reserve memory for all columns in schema, even if it is not queried. Which will cause bad performance when quering wide table. In thi

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1237: Change strategy of incorrect data

2019-06-03 Thread GitBox
EmmyMiao87 opened a new pull request #1237: Change strategy of incorrect data URL: https://github.com/apache/incubator-doris/pull/1237 This change adds a config named enable_load_strict which is used to prohibit the incorrect data. When the config is set to false, the incorrect data will

[GitHub] [incubator-doris] imay commented on issue #1236: Bad performance when query a table which has many columns(100+)

2019-06-03 Thread GitBox
imay commented on issue #1236: Bad performance when query a table which has many columns(100+) URL: https://github.com/apache/incubator-doris/issues/1236#issuecomment-498170972 When I looked into code, I found the only difference between these two query is that in wide table, we will crea

[GitHub] [incubator-doris] imay opened a new issue #1236: Bad performance when query a table which has many columns(100+)

2019-06-03 Thread GitBox
imay opened a new issue #1236: Bad performance when query a table which has many columns(100+) URL: https://github.com/apache/incubator-doris/issues/1236 **Describe the bug** When query two columns in a wide table (`table1`) which has many columns, in this case is 178 columns. I

[GitHub] [incubator-doris] imay commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
imay commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r289713077 ## File path: fe/src/test/java/org/apache/doris/common/util/SmallFileMgrTest.java ## @

[GitHub] [incubator-doris] imay commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job

2019-06-03 Thread GitBox
imay commented on a change in pull request #1235: Support SSL authentication with Kafka in routine load job URL: https://github.com/apache/incubator-doris/pull/1235#discussion_r289712195 ## File path: fe/src/main/java/org/apache/doris/common/util/KafkaUtil.java ## @@ -0,0