[GitHub] [incubator-doris] chaoyli merged pull request #893: Add unit tests for be_refactor

2019-04-09 Thread GitBox
chaoyli merged pull request #893: Add unit tests for be_refactor URL: https://github.com/apache/incubator-doris/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] chaoyli merged pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
chaoyli merged pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
yiguolei commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273795803 ## File path: be/src/olap/data_dir.cpp ## @@ -604,18 +605,24 @@ OLAPStatus DataDir::_conv

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
yiguolei commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273792821 ## File path: be/src/olap/data_dir.cpp ## @@ -604,18 +605,24 @@ OLAPStatus DataDir::_conv

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
chaoyli commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273772207 ## File path: be/src/olap/data_dir.cpp ## @@ -604,18 +605,24 @@ OLAPStatus DataDir::_conve

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
chaoyli commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273772135 ## File path: be/src/olap/data_dir.cpp ## @@ -604,18 +605,24 @@ OLAPStatus DataDir::_conve

[GitHub] [incubator-doris] chaoyli edited a comment on issue #838: CumulativeCompaction with HLL cause BE core dump

2019-04-09 Thread GitBox
chaoyli edited a comment on issue #838: CumulativeCompaction with HLL cause BE core dump URL: https://github.com/apache/incubator-doris/issues/838#issuecomment-481517194 HLL core dump in cumulative compaction is fixed in https://github.com/apache/incubator-doris/pull/901/files -

[GitHub] [incubator-doris] chaoyli commented on issue #838: CumulativeCompaction with HLL cause BE core dump

2019-04-09 Thread GitBox
chaoyli commented on issue #838: CumulativeCompaction with HLL cause BE core dump URL: https://github.com/apache/incubator-doris/issues/838#issuecomment-481517194 https://github.com/apache/incubator-doris/pull/901/files This

[GitHub] [incubator-doris] imay merged pull request #901: Fix HLL compaction bug

2019-04-09 Thread GitBox
imay merged pull request #901: Fix HLL compaction bug URL: https://github.com/apache/incubator-doris/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
kangpinghuang commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273770294 ## File path: be/src/olap/data_dir.h ## @@ -123,7 +123,7 @@ class DataDir { Sta

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #895: Remove old files after tablet is successfully loaded

2019-04-09 Thread GitBox
kangpinghuang commented on a change in pull request #895: Remove old files after tablet is successfully loaded URL: https://github.com/apache/incubator-doris/pull/895#discussion_r273769845 ## File path: be/src/olap/tablet_manager.cpp ## @@ -1086,8 +1090,9 @@ OLAPStatus Tab

[GitHub] [incubator-doris] chaoyli opened a new pull request #901: Fix HLL compaction bug.

2019-04-09 Thread GitBox
chaoyli opened a new pull request #901: Fix HLL compaction bug. URL: https://github.com/apache/incubator-doris/pull/901 1. Cumulative Compaction in HLL will core dump because of null pointer This is an automated message from t

[GitHub] [incubator-doris] lide-reed opened a new pull request #900: Add error status when data has an array in EsScrollParser

2019-04-09 Thread GitBox
lide-reed opened a new pull request #900: Add error status when data has an array in EsScrollParser URL: https://github.com/apache/incubator-doris/pull/900 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] lide-reed merged pull request #900: Add error status when data has an array in EsScrollParser

2019-04-09 Thread GitBox
lide-reed merged pull request #900: Add error status when data has an array in EsScrollParser URL: https://github.com/apache/incubator-doris/pull/900 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] lide-reed opened a new pull request #899: Fix multithreads for EsHttpScanNode

2019-04-09 Thread GitBox
lide-reed opened a new pull request #899: Fix multithreads for EsHttpScanNode URL: https://github.com/apache/incubator-doris/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] lide-reed merged pull request #899: Fix multithreads for EsHttpScanNode

2019-04-09 Thread GitBox
lide-reed merged pull request #899: Fix multithreads for EsHttpScanNode URL: https://github.com/apache/incubator-doris/pull/899 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] kangpinghuang commented on issue #897: AlphaRowsetWriter's add_rowset api will failed when the rowset added has more than one SegmentGroup

2019-04-09 Thread GitBox
kangpinghuang commented on issue #897: AlphaRowsetWriter's add_rowset api will failed when the rowset added has more than one SegmentGroup URL: https://github.com/apache/incubator-doris/issues/897#issuecomment-481215098 Fixed by #898 ---

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #898: Fix writer add_rowset bug

2019-04-09 Thread GitBox
kangpinghuang opened a new pull request #898: Fix writer add_rowset bug URL: https://github.com/apache/incubator-doris/pull/898 fix AlphaRowsetWriter's add_rowset api This is an automated message from the Apache Git Service. T

[GitHub] [incubator-doris] kangpinghuang opened a new issue #897: AlphaRowsetWriter's add_rowset api will failed when the rowset added has more than one SegmentGroup

2019-04-09 Thread GitBox
kangpinghuang opened a new issue #897: AlphaRowsetWriter's add_rowset api will failed when the rowset added has more than one SegmentGroup URL: https://github.com/apache/incubator-doris/issues/897 **Describe the bug** When the added rowset has more than one SegmentGroup, add rowset will

[GitHub] [incubator-doris] kangpinghuang commented on issue #896: Add unit tests for be_refactor

2019-04-09 Thread GitBox
kangpinghuang commented on issue #896: Add unit tests for be_refactor URL: https://github.com/apache/incubator-doris/issues/896#issuecomment-481213418 Fixed by #893 1. add rowset_meta_test to test RowsetMeta and AlphaRowsetMeta 2. add alpha_rowset_test to test AlphaRowset/AlphaRowset

[GitHub] [incubator-doris] kangpinghuang opened a new issue #896: Add unit tests for be_refactor

2019-04-09 Thread GitBox
kangpinghuang opened a new issue #896: Add unit tests for be_refactor URL: https://github.com/apache/incubator-doris/issues/896 **Is your feature request related to a problem? Please describe.** Now the unit tests in be_refactor are not enough. It is necessary to add unit tests for Rowse

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #893: Add unit tests for be_refactor

2019-04-09 Thread GitBox
yiguolei commented on a change in pull request #893: Add unit tests for be_refactor URL: https://github.com/apache/incubator-doris/pull/893#discussion_r273398575 ## File path: be/src/olap/storage_engine.cpp ## @@ -428,13 +430,17 @@ void StorageEngine::_delete_tables_on_unu

[GitHub] [incubator-doris] yiguolei opened a new pull request #895: Remove old files after tablet is successfully

2019-04-09 Thread GitBox
yiguolei opened a new pull request #895: Remove old files after tablet is successfully URL: https://github.com/apache/incubator-doris/pull/895 1. check and call init automatically when call load 2. return error if convert meets error 3. remove old files when convert and load tablet fi

[GitHub] [incubator-doris] lide-reed merged pull request #894: Fix shards to _shards in ESScanReader

2019-04-09 Thread GitBox
lide-reed merged pull request #894: Fix shards to _shards in ESScanReader URL: https://github.com/apache/incubator-doris/pull/894 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] lide-reed opened a new pull request #894: Fix shards to _shards in ESScanReader

2019-04-09 Thread GitBox
lide-reed opened a new pull request #894: Fix shards to _shards in ESScanReader URL: https://github.com/apache/incubator-doris/pull/894 This is an automated message from the Apache Git Service. To respond to the message, plea

[DISCUSS] Unify the load framework in Doris

2019-04-09 Thread Miao,Ling
Hi all, I prepare to unify the load framework in Doris. The background is following: There are different load frameworks belong to different load methods in Doris. On the one hand, the performance of broker and mini load which use the old framework is lower than stream load. On the other hand,

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #893: Add unit tests for be_refactor

2019-04-09 Thread GitBox
kangpinghuang opened a new pull request #893: Add unit tests for be_refactor URL: https://github.com/apache/incubator-doris/pull/893 1. add rowset_meta_test 2. add alpha_rowset_test This is an automated message from the Apa