[GitHub] kangpinghuang commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249670514 ## File path: be/src/olap/push_handler.cpp ## @@ -401,46 +394,42 @@ OLAPStatus PushHandler::

[GitHub] kangpinghuang commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249659093 ## File path: be/src/olap/push_handler.cpp ## @@ -54,10 +57,59 @@ OLAPStatus PushHandler::pr

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663506 ## File path: be/src/olap/txn_manager.cpp ## @@ -172,9 +172,8 @@ void TxnManager::get_tablet_related_txns(Tablet

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663468 ## File path: be/src/olap/txn_manager.cpp ## @@ -151,7 +151,7 @@ OLAPStatus TxnManager::delete_txn( } void T

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663432 ## File path: be/src/olap/txn_manager.cpp ## @@ -151,7 +151,7 @@ OLAPStatus TxnManager::delete_txn( } void T

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249661922 ## File path: be/src/olap/delta_writer.cpp ## @@ -45,12 +45,10 @@ DeltaWriter::~DeltaWriter() { } void Delta

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662757 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662816 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662703 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662146 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,138 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662688 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662942 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +954,56 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662523 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,138 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663147 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,129 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663203 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,129 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663063 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,129 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663319 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,129 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249663580 ## File path: be/src/olap/txn_manager.cpp ## @@ -190,11 +189,7 @@ void TxnManager::get_txn_related_tablets(const

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249662552 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,138 @@ StorageEngine::~StorageEngine() { cl

[GitHub] chaoyli merged pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli merged pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] chenhao7253886 merged pull request #568: Remove unit of measurement about query statistics in audit log

2019-01-21 Thread GitBox
chenhao7253886 merged pull request #568: Remove unit of measurement about query statistics in audit log URL: https://github.com/apache/incubator-doris/pull/568 This is an automated message from the Apache Git Service. To res

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249653235 ## File path: be/src/olap/merger.h ## @@ -46,7 +46,7 @@ class Merger { } private: TabletSharedPtr _

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249653250 ## File path: be/src/olap/merger.cpp ## @@ -33,7 +33,7 @@ using std::vector; namespace doris { -Merger::M

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249653225 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_base_co

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249653174 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_base_co

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249653037 ## File path: be/src/olap/cumulative_compaction.h ## @@ -172,7 +172,7 @@ class CumulativeCompaction { Ver

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249652928 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_base_co

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249652799 ## File path: be/src/olap/merger.h ## @@ -30,7 +30,7 @@ class ColumnData; class Merger { public: // par

[GitHub] chaoyli commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249651967 ## File path: be/src/olap/delta_writer.cpp ## @@ -113,13 +113,13 @@ OLAPStatus DeltaWriter::init() {

[GitHub] kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249650705 ## File path: be/src/olap/cumulative_compaction.h ## @@ -172,7 +172,7 @@ class CumulativeCompaction {

[GitHub] chenhao7253886 opened a new pull request #568: Remove unit of measurement about query statistics in audit log

2019-01-21 Thread GitBox
chenhao7253886 opened a new pull request #568: Remove unit of measurement about query statistics in audit log URL: https://github.com/apache/incubator-doris/pull/568 This is an automated message from the Apache Git Service.

[GitHub] kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249650629 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_b

[GitHub] kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
kangpinghuang commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249650556 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_b

[GitHub] yiguolei commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649853 ## File path: be/src/olap/merger.h ## @@ -46,7 +46,7 @@ class Merger { } private: TabletSharedPtr

[GitHub] yiguolei commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649764 ## File path: be/src/olap/delta_writer.cpp ## @@ -113,13 +113,13 @@ OLAPStatus DeltaWriter::init() {

[GitHub] yiguolei commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649842 ## File path: be/src/olap/merger.h ## @@ -30,7 +30,7 @@ class ColumnData; class Merger { public: // pa

[GitHub] yiguolei commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649828 ## File path: be/src/olap/merger.cpp ## @@ -33,7 +33,7 @@ using std::vector; namespace doris { -Merger::

[GitHub] yiguolei commented on a change in pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
yiguolei commented on a change in pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564#discussion_r249649686 ## File path: be/src/olap/base_compaction.cpp ## @@ -309,13 +309,13 @@ OLAPStatus BaseCompaction::_do_base_c

[GitHub] yiguolei opened a new pull request #567: Add publish version task

2019-01-21 Thread GitBox
yiguolei opened a new pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567 1. Add publish version task 2. Add a global execute_task method in storage engine 3. Ignore any errors when load tablet and rowset from data dir. -

[GitHub] morningman merged pull request #566: Fix some bugs

2019-01-21 Thread GitBox
morningman merged pull request #566: Fix some bugs URL: https://github.com/apache/incubator-doris/pull/566 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

Re: Does Doris need new mentor?

2019-01-21 Thread Dave Fisher
This mentor agrees. Welcome Shaofeng Shi! Regards, Dave Sent from my iPhone > On Jan 21, 2019, at 7:41 PM, Willem Jiang wrote: > > Yeah, it's nice to see we could get more hands from the new mentor. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > >> On Mon, Jan 21, 2019 at 11

Re: Does Doris need new mentor?

2019-01-21 Thread Willem Jiang
Yeah, it's nice to see we could get more hands from the new mentor. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Mon, Jan 21, 2019 at 11:16 PM ShaoFeng Shi wrote: > > Hello, Doris podling, > > This is Shaofeng Shi, one of Apache Kylin PMC and Apache Incubator PMC; I > know Doris (previo

[GitHub] chenhao7253886 merged pull request #565: Fix uncorrect hll type length when creating table

2019-01-21 Thread GitBox
chenhao7253886 merged pull request #565: Fix uncorrect hll type length when creating table URL: https://github.com/apache/incubator-doris/pull/565 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] morningman opened a new pull request #566: Fix some bugs

2019-01-21 Thread GitBox
morningman opened a new pull request #566: Fix some bugs URL: https://github.com/apache/incubator-doris/pull/566 1. Backup obj should set state to NORMAL. 2. Replica with version 1-0 should be handled correctly. This is an

[GitHub] chenhao7253886 opened a new pull request #565: Fix uncorrect hll type length when creating table

2019-01-21 Thread GitBox
chenhao7253886 opened a new pull request #565: Fix uncorrect hll type length when creating table URL: https://github.com/apache/incubator-doris/pull/565 This is an automated message from the Apache Git Service. To respond to

Re: Does Doris need new mentor?

2019-01-21 Thread hkp
Yes, Warmly welcome you to be our mentor, @shaofeng. Thank you! | | hkp | | kangpinghu...@126.com | 签名由网易邮箱大师定制 On 1/22/2019 10:01,Li,De(BDG) wrote: Yes, we do, thank you, warmly welcome you, Shaofeng. Best Regards, Reed On 2019/1/22 上午7:16, "Zhao Chun" wrote: Welcome, Shaofeng Thank you very

Re: Does Doris need new mentor?

2019-01-21 Thread Li,De(BDG)
Yes, we do, thank you, warmly welcome you, Shaofeng. Best Regards, Reed On 2019/1/22 上午7:16, "Zhao Chun" wrote: >Welcome, Shaofeng > >Thank you very much for being our mentor. > >陈明雨 于 2019年1月22日周二 07:12写道: > >> Welcome, Shaofeng! >> >> It is greatful to us to have a new mentor, lol! >> >> >>

Re: Does Doris need new mentor?

2019-01-21 Thread Li,Chaoyong
Welcome Shaofeng to be our mentor. 在 2019/1/22 上午7:16,“Zhao Chun” 写入: Welcome, Shaofeng Thank you very much for being our mentor. 陈明雨 于 2019年1月22日周二 07:12写道: > Welcome, Shaofeng! > > It is greatful to us to have a new mentor, lol! > > > >

Re: Does Doris need new mentor?

2019-01-21 Thread Zhao Chun
Welcome, Shaofeng Thank you very much for being our mentor. 陈明雨 于 2019年1月22日周二 07:12写道: > Welcome, Shaofeng! > > It is greatful to us to have a new mentor, lol! > > > > > -- > 发自我的网易邮箱手机智能版 > > > 在 2019-01-21 23:15:28,"ShaoFeng Shi" 写道: > >Hello, Doris podling, > > > >This is Shaofeng Shi, one

Re:Does Doris need new mentor?

2019-01-21 Thread 陈明雨
Welcome, Shaofeng! It is greatful to us to have a new mentor, lol! -- 发自我的网易邮箱手机智能版 在 2019-01-21 23:15:28,"ShaoFeng Shi" 写道: >Hello, Doris podling, > >This is Shaofeng Shi, one of Apache Kylin PMC and Apache Incubator PMC; I >know Doris (previously called Palo) since several years ago becau

Does Doris need new mentor?

2019-01-21 Thread ShaoFeng Shi
Hello, Doris podling, This is Shaofeng Shi, one of Apache Kylin PMC and Apache Incubator PMC; I know Doris (previously called Palo) since several years ago because Kylin and Doris are all analytics engines for big data (but has different implementations: Kylin is MOLAP, Doris is MPP), both main te

[GitHub] chaoyli opened a new pull request #564: Change CreateTablet implemention

2019-01-21 Thread GitBox
chaoyli opened a new pull request #564: Change CreateTablet implemention URL: https://github.com/apache/incubator-doris/pull/564 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] imay commented on issue #549: Add a colocate join meta repair tool

2019-01-21 Thread GitBox
imay commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455999649 > @imay I added header "Transfer-Encoding: chunked" to java http client, which still work well. After I debugged, I think either the Netty Htt

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-21 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455984204 @imay I added header "Transfer-Encoding: chunked" to java http client, which still work well. After I debugged, I think either the Netty

[GitHub] kangpinghuang opened a new pull request #563: Modify schema change to use rowset

2019-01-21 Thread GitBox
kangpinghuang opened a new pull request #563: Modify schema change to use rowset URL: https://github.com/apache/incubator-doris/pull/563 replace segment group/column data with rowset in schema change This is an automated messa

[GitHub] imay commented on issue #549: Add a colocate join meta repair tool

2019-01-21 Thread GitBox
imay commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455980791 @kangkaisen I found that curl's request has HTTP header "Transfer-Encoding: chunked". Maybe this encoding type caused the different res