[GitHub] chaoyli closed pull request #470: Fixed compilation error in refactoring tablet and tabletmeta

2018-12-25 Thread GitBox
chaoyli closed pull request #470: Fixed compilation error in refactoring tablet and tabletmeta URL: https://github.com/apache/incubator-doris/pull/470 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] chaoyli opened a new pull request #470: Fixed compilation error in refactoring tablet and tabletmeta

2018-12-25 Thread GitBox
chaoyli opened a new pull request #470: Fixed compilation error in refactoring tablet and tabletmeta URL: https://github.com/apache/incubator-doris/pull/470 This is an automated message from the Apache Git Service. To respon

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-25 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243933493 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,667 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-25 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243934071 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,667 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-25 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243933413 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,667 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-25 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243933930 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,667 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] EmmyMiao87 commented on a change in pull request #456: Add routine load statement

2018-12-25 Thread GitBox
EmmyMiao87 commented on a change in pull request #456: Add routine load statement URL: https://github.com/apache/incubator-doris/pull/456#discussion_r243933548 ## File path: fe/src/main/java/org/apache/doris/analysis/LoadProperty.java ## @@ -0,0 +1,25 @@ +// Licensed to th

[GitHub] imay commented on a change in pull request #456: Add routine load statement

2018-12-25 Thread GitBox
imay commented on a change in pull request #456: Add routine load statement URL: https://github.com/apache/incubator-doris/pull/456#discussion_r243909920 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1103,6 +1146,87 @@ opt_cluster ::= :} ; +// Routine load

[GitHub] imay commented on a change in pull request #456: Add routine load statement

2018-12-25 Thread GitBox
imay commented on a change in pull request #456: Add routine load statement URL: https://github.com/apache/incubator-doris/pull/456#discussion_r243910295 ## File path: fe/src/main/java/org/apache/doris/analysis/LoadProperty.java ## @@ -0,0 +1,25 @@ +// Licensed to the Apach

[GitHub] chaoyli closed pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli closed pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243909118 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage {

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243909107 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage {

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243909039 ## File path: be/src/olap/tablet_meta.cpp ## @@ -172,8 +172,8 @@ const RowsetMeta* TabletMeta::g

[GitHub] morningman closed pull request #469: Fix fe ut

2018-12-25 Thread GitBox
morningman closed pull request #469: Fix fe ut URL: https://github.com/apache/incubator-doris/pull/469 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork

[GitHub] morningman opened a new pull request #469: Fix fe ut

2018-12-25 Thread GitBox
morningman opened a new pull request #469: Fix fe ut URL: https://github.com/apache/incubator-doris/pull/469 1. Fix StreamLoadScanNodeTest 2. Revert the fix of decimal value with scientific notation, this still need to fix it later ---

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903890 ## File path: be/src/olap/tablet_meta.cpp ## @@ -47,12 +47,12 @@ NewStatus TabletMeta::deserialize_unl

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903781 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage { re

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903763 ## File path: be/src/olap/tablet_meta.h ## @@ -90,12 +90,13 @@ class TabletMeta { Newstatus add

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903682 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage { re

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903351 ## File path: be/src/olap/tablet_meta.cpp ## @@ -172,8 +172,8 @@ const RowsetMeta* TabletMeta::get_inc

[GitHub] kangkaisen commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat

2018-12-25 Thread GitBox
kangkaisen commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat URL: https://github.com/apache/incubator-doris/pull/466#issuecomment-449842536 > > I think this PR has fixed issue [458](https://github.com/apache/incubator-doris/issues/458) > > Could you test thi

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903077 ## File path: be/src/olap/tablet.cpp ## @@ -228,12 +228,13 @@ void Tablet::calc_missed_versions(int64_

[GitHub] chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243903040 ## File path: be/src/olap/tablet.cpp ## @@ -76,7 +76,7 @@ OLAPStatus Tablet::init_once() { for (i

[GitHub] imay commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat

2018-12-25 Thread GitBox
imay commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat URL: https://github.com/apache/incubator-doris/pull/466#issuecomment-449842360 > I think this PR has fixed issue [458](https://github.com/apache/incubator-doris/issues/458) Could you test this patch to se

[GitHub] kangkaisen commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat

2018-12-25 Thread GitBox
kangkaisen commented on issue #466: Change WriteLock to ReadLock when get_tablet_stat URL: https://github.com/apache/incubator-doris/pull/466#issuecomment-449842119 I think this PR has fixed issue [458](https://github.com/apache/incubator-doris/issues/458)

[GitHub] imay opened a new pull request #468: Support UDF in syntax

2018-12-25 Thread GitBox
imay opened a new pull request #468: Support UDF in syntax URL: https://github.com/apache/incubator-doris/pull/468 Now, you can create UDF with CREATE FUNCTION statement. Doris only support UDF in this version, it will support UDAF/UDTF later.

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900781 ## File path: be/src/olap/tablet_meta.cpp ## @@ -47,12 +47,12 @@ NewStatus TabletMeta::deseriali

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900921 ## File path: be/src/olap/tablet_meta.cpp ## @@ -172,8 +172,8 @@ const RowsetMeta* TabletMeta::g

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900852 ## File path: be/src/olap/tablet_meta.cpp ## @@ -172,8 +172,8 @@ const RowsetMeta* TabletMeta::g

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900551 ## File path: be/src/olap/tablet.cpp ## @@ -228,12 +228,13 @@ void Tablet::calc_missed_versions(

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900964 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage {

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243901065 ## File path: be/src/olap/tablet_meta.h ## @@ -90,12 +90,13 @@ class TabletMeta { Newstat

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243900398 ## File path: be/src/olap/tablet.cpp ## @@ -76,7 +76,7 @@ OLAPStatus Tablet::init_once() {

[GitHub] kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
kangpinghuang commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243901015 ## File path: gensrc/proto/olap_file.proto ## @@ -183,6 +183,47 @@ message OLAPHeaderMessage {

[GitHub] yiguolei commented on a change in pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
yiguolei commented on a change in pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467#discussion_r243899632 ## File path: be/src/olap/tablet.cpp ## @@ -76,7 +76,7 @@ OLAPStatus Tablet::init_once() { for (

[GitHub] chaoyli opened a new pull request #467: change Rowset pointer to std::shared_ptr

2018-12-25 Thread GitBox
chaoyli opened a new pull request #467: change Rowset pointer to std::shared_ptr URL: https://github.com/apache/incubator-doris/pull/467 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] chaoyli closed pull request #464: Make column's name be case insensitive in load stmt

2018-12-25 Thread GitBox
chaoyli closed pull request #464: Make column's name be case insensitive in load stmt URL: https://github.com/apache/incubator-doris/pull/464 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] imay closed pull request #466: Change WriteLock to ReadLock when get_tablet_stat

2018-12-25 Thread GitBox
imay closed pull request #466: Change WriteLock to ReadLock when get_tablet_stat URL: https://github.com/apache/incubator-doris/pull/466 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] chaoyli opened a new pull request #466: Change WriteLock to ReadLock when get_tablet_stat

2018-12-25 Thread GitBox
chaoyli opened a new pull request #466: Change WriteLock to ReadLock when get_tablet_stat URL: https://github.com/apache/incubator-doris/pull/466 This is an automated message from the Apache Git Service. To respond to the me