[GitHub] chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243510756 ## File path: gensrc/proto/olap_file.proto ## @@ -175,6 +175,48 @@ message OLAPHeaderMessage { optional uin

[GitHub] chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243510449 ## File path: be/src/olap/tablet.cpp ## @@ -202,917 +63,145 @@ Tablet::~Tablet() { } // ensure that

[GitHub] chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243510254 ## File path: be/src/olap/tablet_meta.cpp ## @@ -17,968 +17,197 @@ #include "olap/tablet_meta.h" -#include

[GitHub] chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243510303 ## File path: be/src/olap/tablet_meta.cpp ## @@ -17,968 +17,197 @@ #include "olap/tablet_meta.h" -#include

[GitHub] chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243509153 ## File path: be/src/common/config.h ## @@ -214,8 +214,8 @@ namespace config { CONF_Int32(max_tablet_num_pe

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243476579 ## File path: be/src/olap/tablet.cpp ## @@ -202,917 +63,145 @@ Tablet::~Tablet() { } // ensure that

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243504231 ## File path: be/src/olap/tablet_meta.cpp ## @@ -17,968 +17,197 @@ #include "olap/tablet_meta.h" -#include

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243507597 ## File path: be/src/olap/tablet_meta.cpp ## @@ -17,968 +17,197 @@ #include "olap/tablet_meta.h" -#include

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243486057 ## File path: be/src/olap/tablet.cpp ## @@ -202,917 +63,145 @@ Tablet::~Tablet() { } // ensure that

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243495085 ## File path: be/src/olap/tablet.cpp ## @@ -1126,490 +215,46 @@ void Tablet::get_missing_versions_with_header_l

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243485697 ## File path: be/src/common/config.h ## @@ -214,8 +214,8 @@ namespace config { CONF_Int32(max_tablet_num_p

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243504162 ## File path: be/src/olap/tablet_meta.cpp ## @@ -17,968 +17,197 @@ #include "olap/tablet_meta.h" -#include

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243494747 ## File path: be/src/olap/tablet.cpp ## @@ -202,917 +63,145 @@ Tablet::~Tablet() { } // ensure that

[GitHub] yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454#discussion_r243503181 ## File path: gensrc/proto/olap_file.proto ## @@ -175,6 +175,48 @@ message OLAPHeaderMessage { optional ui

[GitHub] Salieri1969 commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
Salieri1969 commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243484679 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] crystaldust opened a new issue #455: Failed to build doris

2018-12-20 Thread GitBox
crystaldust opened a new issue #455: Failed to build doris URL: https://github.com/apache/incubator-doris/issues/455 I'm trying to build doris with the `build.sh` script but got an error: ```bash .. /home/lance/Downloads/apache-doris-0.9.0.rc01-incubating-src/thirdparty/src/llv

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243485102 ## File path: be/src/olap/segment_group.cpp ## @@ -276,28 +324,26 @@ OLAPStatus SegmentGroup::load()

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243484976 ## File path: be/src/olap/segment_group.cpp ## @@ -139,19 +148,58 @@ SegmentGroup::~SegmentGroup() {

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243183706 ## File path: be/src/olap/rowset/alpha_rowset_reader.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apach

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243484934 ## File path: be/src/olap/segment_group.cpp ## @@ -115,15 +125,14 @@ SegmentGroup::SegmentGroup(Tabl

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243484089 ## File path: be/src/olap/rowset/alpha_rowset.cpp ## @@ -0,0 +1,139 @@ +// Licensed to the Apache So

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243485325 ## File path: be/src/olap/segment_group.cpp ## @@ -551,23 +595,20 @@ OLAPStatus SegmentGroup::add_sh

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243485196 ## File path: be/src/olap/segment_group.cpp ## @@ -276,28 +324,26 @@ OLAPStatus SegmentGroup::load()

[GitHub] yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
yiguolei commented on a change in pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452#discussion_r243484319 ## File path: be/src/olap/rowset/alpha_rowset.h ## @@ -0,0 +1,60 @@ +// Licensed to the Apache Softw

[GitHub] Salieri1969 commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
Salieri1969 commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243484679 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under on

[GitHub] chaoyli opened a new pull request #454: Refactor Tablet and TabletMeta

2018-12-20 Thread GitBox
chaoyli opened a new pull request #454: Refactor Tablet and TabletMeta URL: https://github.com/apache/incubator-doris/pull/454 1. Change TabletMeta to encapsulate interface to operate TabletMetaPB. 2. Delete unused function in Tablet and refactoring the interface of Tablet. 3. Extra

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243204079 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243207853 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243209155 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243202079 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243200786 ## File path: be/src/exec/es_scan_node.h ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243203728 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243201775 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243202764 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay commented on a change in pull request #450: Add EsScanNode

2018-12-20 Thread GitBox
imay commented on a change in pull request #450: Add EsScanNode URL: https://github.com/apache/incubator-doris/pull/450#discussion_r243201585 ## File path: be/src/exec/es_scan_node.cpp ## @@ -0,0 +1,660 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] imay opened a new pull request #453: Add UserFunctionCache to cache UDF's library

2018-12-20 Thread GitBox
imay opened a new pull request #453: Add UserFunctionCache to cache UDF's library URL: https://github.com/apache/incubator-doris/pull/453 This patch replace LibCache with UserFunctionCache. LibCache use HDFS URL to identify a UDF's Library, and when BE process restart all of downloade

[GitHub] kangpinghuang opened a new pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader

2018-12-20 Thread GitBox
kangpinghuang opened a new pull request #452: Add AlphaRowsetMeta and AlphaRowsetReader URL: https://github.com/apache/incubator-doris/pull/452 1. Add AlphaRowsetMeta. Original PDelta will be converted to RowsetMetaPb and will be managed by AlphaRowsetMeta 2. Add AlphaRowsetReader. Alph