[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235625242 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @@ +p

[GitHub] morningman closed pull request #337: Fix add Rollup bug

2018-11-21 Thread GitBox
morningman closed pull request #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[GitHub] morningman closed issue #332: Adding ROLLUP result in Doris All BE core dump

2018-11-21 Thread GitBox
morningman closed issue #332: Adding ROLLUP result in Doris All BE core dump URL: https://github.com/apache/incubator-doris/issues/332 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] chaoyli removed a comment on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
chaoyli removed a comment on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440938039 OK, I this is right. This is an automated message from the Apache Git Service. To resp

[GitHub] chaoyli commented on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
chaoyli commented on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440938039 OK, I this is right. This is an automated message from the Apache Git Service. To respond to t

[GitHub] morningman commented on a change in pull request #340: Fix bug of #307

2018-11-21 Thread GitBox
morningman commented on a change in pull request #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340#discussion_r235623128 ## File path: be/src/http/download_action.cpp ## @@ -254,7 +258,8 @@ Status DownloadAction::check_path_is_allowed(const std:

[GitHub] kangkaisen commented on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
kangkaisen commented on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440937228 Add a special add_column_statistics method for linked_schema_change. @chaoyli Hi, chaoyli. Please review. Thanks.

[GitHub] morningman commented on a change in pull request #340: Fix bug of #307

2018-11-21 Thread GitBox
morningman commented on a change in pull request #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340#discussion_r235622049 ## File path: be/src/http/download_action.cpp ## @@ -254,7 +258,8 @@ Status DownloadAction::check_path_is_allowed(const std:

[GitHub] imay commented on issue #340: Fix bug of #307

2018-11-21 Thread GitBox
imay commented on issue #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340#issuecomment-440933520 @kangpinghuang And you need to change your commit log to describe what you fixed This is an autom

[GitHub] imay commented on a change in pull request #340: Fix bug of #307

2018-11-21 Thread GitBox
imay commented on a change in pull request #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340#discussion_r235619033 ## File path: be/src/http/download_action.cpp ## @@ -243,8 +246,9 @@ Status DownloadAction::check_token(HttpRequest *req) { Stat

[GitHub] imay commented on a change in pull request #340: Fix bug of #307

2018-11-21 Thread GitBox
imay commented on a change in pull request #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340#discussion_r235618934 ## File path: be/src/http/download_action.cpp ## @@ -254,7 +258,8 @@ Status DownloadAction::check_path_is_allowed(const std::strin

[GitHub] kangpinghuang opened a new pull request #340: Fix bug of #307

2018-11-21 Thread GitBox
kangpinghuang opened a new pull request #340: Fix bug of #307 URL: https://github.com/apache/incubator-doris/pull/340 There is a bug to use symbolic link directory as storage root path. It is a problem that whether the path is canonical ---

Re: [MENTORS] About admin right of GitHub repository

2018-11-21 Thread Li,De(BDG)
OK, I got it, thanks Willem. On 2018/11/22 上午11:37, "Willem Jiang" wrote: >As only Infra admin has the admin right of Apache group, when the >github project is transferred into Apache group, the committers don't >have the admin right anymore. If you want to do some modification on >the project,

[GitHub] imay commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
imay commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235592916 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @@ +package

[GitHub] imay closed pull request #339: Fix a compile issue of DORIS_GCC_HOME

2018-11-21 Thread GitBox
imay closed pull request #339: Fix a compile issue of DORIS_GCC_HOME URL: https://github.com/apache/incubator-doris/pull/339 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] lide-reed opened a new pull request #339: Fix a compile issue of DORIS_GCC_HOME

2018-11-21 Thread GitBox
lide-reed opened a new pull request #339: Fix a compile issue of DORIS_GCC_HOME URL: https://github.com/apache/incubator-doris/pull/339 Fix a typo in compile script. This is an automated message from the Apache Git Service. To

[GitHub] kangkaisen removed a comment on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
kangkaisen removed a comment on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440904504 @chaoyli Hi,chaoyli. I See. I have updated the commit. Please review, Thanks. This i

[GitHub] kangkaisen commented on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
kangkaisen commented on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440904504 @chaoyli Hi,chaoyli. I See. I have updated the commit. Please review, Thanks. This is an aut

Re: [MENTORS] About admin right of GitHub repository

2018-11-21 Thread Willem Jiang
As only Infra admin has the admin right of Apache group, when the github project is transferred into Apache group, the committers don't have the admin right anymore. If you want to do some modification on the project, you can submit an infra JIRA[1] [1]https://issues.apache.org/jira/browse/INFRA

[GitHub] kangpinghuang commented on issue #307: The BE storage_root_path is set to a soft symlink, causing the load task to stay in the QUORUM_FINIHSED state

2018-11-21 Thread GitBox
kangpinghuang commented on issue #307: The BE storage_root_path is set to a soft symlink, causing the load task to stay in the QUORUM_FINIHSED state URL: https://github.com/apache/incubator-doris/issues/307#issuecomment-440902768 The bug is the path's canonical problem. I will submit a PR t

[MENTORS] About admin right of GitHub repository

2018-11-21 Thread Li,De(BDG)
Hi, It seems we have been revoked admin right from apache/incubator-doris repository in GitHub suddenly. Do you know that’s why. Best Regards, Reed

[GitHub] imay closed pull request #338: Fix compile issue of thirdparty library

2018-11-21 Thread GitBox
imay closed pull request #338: Fix compile issue of thirdparty library URL: https://github.com/apache/incubator-doris/pull/338 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] imay commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r23558 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235586537 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java #

[GitHub] imay commented on a change in pull request #338: Fix compile issue of thirdparty library

2018-11-21 Thread GitBox
imay commented on a change in pull request #338: Fix compile issue of thirdparty library URL: https://github.com/apache/incubator-doris/pull/338#discussion_r235587835 ## File path: build.sh ## @@ -35,6 +35,18 @@ export DORIS_HOME=${ROOT} . ${DORIS_HOME}/env.sh +# buil

[GitHub] imay commented on a change in pull request #338: Fix compile issue of thirdparty library

2018-11-21 Thread GitBox
imay commented on a change in pull request #338: Fix compile issue of thirdparty library URL: https://github.com/apache/incubator-doris/pull/338#discussion_r235587748 ## File path: thirdparty/build-thirdparty.sh ## @@ -57,17 +57,18 @@ ${TP_DIR}/download-thirdparty.sh ex

[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235587295 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScanner.java ## @@ -0,0 +1,181 @@ +/

[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235584932 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @@ +p

[GitHub] wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235586537 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java #

[GitHub] lide-reed opened a new pull request #338: Fix compile issue of thirdparty library

2018-11-21 Thread GitBox
lide-reed opened a new pull request #338: Fix compile issue of thirdparty library URL: https://github.com/apache/incubator-doris/pull/338 1. Fix compile issue when run script in thirdparty directly. 2. Enable continue download and compile when download is interrupted. -

[GitHub] imay commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235585122 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235584850 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @@ +p

[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235584672 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @@ +p

[GitHub] morningman commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235584508 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScanner.java ## @@ -0,0 +1,181 @@ +/

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235583194 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java ##

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235582623 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java ##

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235584122 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235584017 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235583272 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java ##

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235583137 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java ##

[GitHub] morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235583568 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java ##

[GitHub] chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235583924 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @

[GitHub] chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235583891 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @

[GitHub] chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235582376 ## File path: fe/src/main/java/org/apache/doris/clone/TabletFactory.java ## @@ -0,0 +1,655 @

[GitHub] chenhao7253886 commented on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440886820 I think TabletChecker is more precise to describe this class than TabletScanner. -

[GitHub] chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235579986 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScanner.java ## @@ -0,0 +1,181 @

[GitHub] chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on a change in pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#discussion_r235579812 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScanner.java ## @@ -0,0 +1,181 @

[GitHub] chenhao7253886 commented on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chenhao7253886 commented on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440881871 Factory class is not suitable for implementing procedure to RECOVER and REBLANCE, but only for creating.

[GitHub] wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235403934 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java #

[GitHub] wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly

2018-11-21 Thread GitBox
wuyunfeng commented on a change in pull request #333: Add distributor which schedule task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235403934 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java #

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235397443 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadScheduler.java

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235396508 ## File path: fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java #

[GitHub] chaoyli commented on issue #337: Fix add Rollup bug

2018-11-21 Thread GitBox
chaoyli commented on issue #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337#issuecomment-440666720 I have review your code and core dump info carefully. It may be a little difficulty. 1. Adding rollup should not call LinkedSchemaChange Class. Because Lin

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235387722 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235387153 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -10

[GitHub] kangkaisen commented on issue #332: Adding ROLLUP result in Doris All BE core dump

2018-11-21 Thread GitBox
kangkaisen commented on issue #332: Adding ROLLUP result in Doris All BE core dump URL: https://github.com/apache/incubator-doris/issues/332#issuecomment-440661792 This bug could reproduce stably. 1 create table: ``` CREATE TABLE `table_test_palo_detail` ( `user_id` int(11

[GitHub] kangkaisen opened a new pull request #337: Fix add Rollup bug

2018-11-21 Thread GitBox
kangkaisen opened a new pull request #337: Fix add Rollup bug URL: https://github.com/apache/incubator-doris/pull/337 Fix [332](https://github.com/apache/incubator-doris/issues/332) 1 when add_column_statistics, we should use use _table->num_key_fields(), not column_statistic_fields.

[GitHub] chaoyli edited a comment on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chaoyli edited a comment on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440659126 If tablets to be repaired are at different priorities, how to handle it. For example, Tablet A loss two of three replicas, Tabl

[GitHub] chaoyli commented on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chaoyli commented on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440659126 If tablets to be repaired is at different priority, how to handle it. For example, Tablet A loss two of three replicas, Tablet B loss o

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235382208 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235382208 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] chaoyli edited a comment on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chaoyli edited a comment on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440657850 I think TabletScanner and TabletFactory are not suitable names. Scanner is used in query to scan tablet data. Also I think Tabl

[GitHub] chaoyli commented on issue #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
chaoyli commented on issue #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336#issuecomment-440657850 I think TabletScanner is not a suitable name. Scanner is used in query to scan tablet data. --

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235378853 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -27

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235378992 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -27

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235378992 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -27

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235378853 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -27

[GitHub] EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
EmmyMiao87 commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235377667 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskInfo.java #

[GitHub] morningman opened a new pull request #336: First commit of new tablet repair framework

2018-11-21 Thread GitBox
morningman opened a new pull request #336: First commit of new tablet repair framework URL: https://github.com/apache/incubator-doris/pull/336 There are 3 new main classes 1. TabletScanner This scanner is responsible for scanning all unhealthy tablets, and a

[GitHub] morningman opened a new issue #335: Add a new tablet repair framework for faster tablet balance and repair

2018-11-21 Thread GitBox
morningman opened a new issue #335: Add a new tablet repair framework for faster tablet balance and repair URL: https://github.com/apache/incubator-doris/issues/335 # Current problem The current tablet repair and balance is based on CloneChecker, which is a fixed scheduler daemon th

[GitHub] morningman closed issue #315: FE Catalog should know the path info of each replica in BE

2018-11-21 Thread GitBox
morningman closed issue #315: FE Catalog should know the path info of each replica in BE URL: https://github.com/apache/incubator-doris/issues/315 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] morningman commented on issue #322: 删除表耗时过长

2018-11-21 Thread GitBox
morningman commented on issue #322: 删除表耗时过长 URL: https://github.com/apache/incubator-doris/issues/322#issuecomment-440642027 ISSUE #328 may resolve this issue. This is an automated message from the Apache Git Service. To resp

[GitHub] morningman closed issue #328: Decrease the num of edit log for logging catalog id

2018-11-21 Thread GitBox
morningman closed issue #328: Decrease the num of edit log for logging catalog id URL: https://github.com/apache/incubator-doris/issues/328 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] imay closed pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
imay closed pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] morningman commented on a change in pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
morningman commented on a change in pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235343430 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @

[GitHub] morningman commented on a change in pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
morningman commented on a change in pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235340868 ## File path: fe/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java ## @

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235332160 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -10

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235327570 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235330761 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235324530 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -71

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235322244 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -71

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235337342 ## File path: fe/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java #

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235334652 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235339798 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235328758 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235326642 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235328054 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -25

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235324949 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -44

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235335419 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java

[GitHub] morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
morningman commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235331952 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -10

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235331979 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoad.java ## @@ -27,15 +2

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235329176 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235328270 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235330204 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235327378 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java ##

[GitHub] imay commented on a change in pull request #333: Add distributor which allocate task to be fairly

2018-11-21 Thread GitBox
imay commented on a change in pull request #333: Add distributor which allocate task to be fairly URL: https://github.com/apache/incubator-doris/pull/333#discussion_r235330412 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskInfo.java ## @@

[GitHub] yiguolei commented on a change in pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
yiguolei commented on a change in pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235322031 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@

[GitHub] yiguolei commented on a change in pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
yiguolei commented on a change in pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235317987 ## File path: fe/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java ## @@

[GitHub] yiguolei commented on a change in pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
yiguolei commented on a change in pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334#discussion_r235317671 ## File path: fe/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java ## @@

[GitHub] morningman opened a new pull request #334: Modify partition's version name to what it means

2018-11-21 Thread GitBox
morningman opened a new pull request #334: Modify partition's version name to what it means URL: https://github.com/apache/incubator-doris/pull/334 1. committedVersion(Hash) -> visibleVersion(Hash) 2. currentVersion(Hash) -> committedVersion(Hash) 3. add some comment to make the code

  1   2   >