[GitHub] [comdev-site] rlenferink commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
rlenferink commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490049905 This looks quite neat when tested locally! I updated the README with the steps I had to execute to get this working locally. I checked [the Jenkins build](https://ci-builds.apac

[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
sebbASF commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490069944 Rather than a container, maybe it is possible to install hugo and npm/npx in Jenkins? That would be useful for others. -- This is an automated message from the Apache Git Service. To

[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
sebbASF commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490080175 I've raised INFRA-24405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [comdev-site] bdelacretaz commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
bdelacretaz commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490093022 You might also install a `pagefind` binary ( https://github.com/CloudCannon/pagefind/releases ) from the `Jenkinsfile`, similar to how Hugo is installed for this build? Pagefind insta

[GitHub] [comdev-site] bdelacretaz commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
bdelacretaz commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490115972 ...and BTW it would be good to verify checksums when downloading external tools. I've never done this in a Jenkinsfile myself but https://www.jenkins.io/doc/pipeline/steps/pipe

[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
sebbASF commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490182314 Seems to be building OK now - OK to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [comdev-site] sebbASF merged pull request #99: += pagefind

2023-03-30 Thread via GitHub
sebbASF merged PR #99: URL: https://github.com/apache/comdev-site/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apac

[GitHub] [comdev-site] rlenferink commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
rlenferink commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1490626581 > I've raised INFRA-24405 To be honest: I don't like the idea of globally installed tooling. Different projects are using different versions of Hugo (Celix uses 0.63.2, Je

[GitHub] [comdev-site] rlenferink opened a new pull request, #100: Use pinned version of Hugo

2023-03-30 Thread via GitHub
rlenferink opened a new pull request, #100: URL: https://github.com/apache/comdev-site/pull/100 As explained in https://github.com/apache/comdev-site/pull/99#issuecomment-1490626581 not pinning tooling to a specific version is not too good of an idea in general. Having to rely on different

[GitHub] [comdev-site] sebbASF commented on pull request #100: Use pinned version of Hugo

2023-03-30 Thread via GitHub
sebbASF commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1491059249 Surely the version of Hugo provided by Jenkins is effectively pinned? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [comdev-site] sebbASF commented on pull request #99: += pagefind

2023-03-30 Thread via GitHub
sebbASF commented on PR #99: URL: https://github.com/apache/comdev-site/pull/99#issuecomment-1491069518 Well, Python and Ruby etc are all shared installs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [comdev-site] sebbASF commented on a diff in pull request #100: Use pinned version of Hugo

2023-03-31 Thread via GitHub
sebbASF commented on code in PR #100: URL: https://github.com/apache/comdev-site/pull/100#discussion_r115416 ## Jenkinsfile: ## @@ -56,10 +68,13 @@ pipeline { stage('Build') { steps { script { -sh 'for i in $(which -

[GitHub] [comdev-events-site] sebbASF opened a new pull request, #3: Add pagefind

2023-03-31 Thread via GitHub
sebbASF opened a new pull request, #3: URL: https://github.com/apache/comdev-events-site/pull/3 The search box can be moved / copied elsewhere -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [comdev-events-site] sebbASF opened a new pull request, #4: Obsolete

2023-03-31 Thread via GitHub
sebbASF opened a new pull request, #4: URL: https://github.com/apache/comdev-events-site/pull/4 No point keeping these anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [comdev-site] rlenferink commented on a diff in pull request #100: Use pinned version of Hugo

2023-04-01 Thread via GitHub
rlenferink commented on code in PR #100: URL: https://github.com/apache/comdev-site/pull/100#discussion_r1155086940 ## Jenkinsfile: ## @@ -56,10 +68,13 @@ pipeline { stage('Build') { steps { script { -sh 'for i in $(whic

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-01 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1492909086 > Surely the version of Hugo provided by Jenkins is effectively pinned? It indeed is pinned. But if INFRA (or another project) requests the version to be updated then we might

[GitHub] [comdev-site] sebbASF commented on a diff in pull request #100: Use pinned version of Hugo

2023-04-01 Thread via GitHub
sebbASF commented on code in PR #100: URL: https://github.com/apache/comdev-site/pull/100#discussion_r1155094358 ## Jenkinsfile: ## @@ -56,10 +68,13 @@ pipeline { stage('Build') { steps { script { -sh 'for i in $(which -

[GitHub] [comdev-site] sebbASF commented on pull request #100: Use pinned version of Hugo

2023-04-01 Thread via GitHub
sebbASF commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1492950991 > But it seems that only works for maven, jdk and gradle: https://www.jenkins.io/doc/book/pipeline/syntax/#supported-tools. However https://www.jenkins.io/doc/book/managing/tools/

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493320573 > > But it seems that only works for maven, jdk and gradle: https://www.jenkins.io/doc/book/pipeline/syntax/#supported-tools. > > However https://www.jenkins.io/doc/book/managi

[GitHub] [comdev-site] rlenferink commented on a diff in pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on code in PR #100: URL: https://github.com/apache/comdev-site/pull/100#discussion_r1155303835 ## Jenkinsfile: ## @@ -56,10 +68,13 @@ pipeline { stage('Build') { steps { script { -sh 'for i in $(whic

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493328882 @sebbASF does this look okay to you to be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [comdev-site] sebbASF commented on pull request #100: Use pinned version of Hugo

2023-04-02 Thread via GitHub
sebbASF commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1493379962 The env.HUGO and env.PAGEFIND variables are redundant, in my view, given that they are only used once -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [comdev-events-site] sebbASF commented on pull request #4: Obsolete

2023-04-02 Thread via GitHub
sebbASF commented on PR #4: URL: https://github.com/apache/comdev-events-site/pull/4#issuecomment-1493461512 Please see https://community-test.staged.apache.org/ which shows the result of applying PR #4 and PR #3 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [comdev-events-site] sebbASF commented on pull request #3: Add pagefind

2023-04-02 Thread via GitHub
sebbASF commented on PR #3: URL: https://github.com/apache/comdev-events-site/pull/3#issuecomment-1493461566 Please see https://community-test.staged.apache.org/ which shows the result of applying PR #4 and PR #3 -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-04 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1496356352 They are used once in the `${HUGO} version` and once in the actual `${HUGO} --destination` call. Same for pagefind. -- This is an automated message from the Apache Git Service. To

[GitHub] [comdev-site] sebbASF commented on pull request #100: Use pinned version of Hugo

2023-04-04 Thread via GitHub
sebbASF commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1496721071 however the version calls were added for debug purposes and are not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [comdev-site] rlenferink commented on pull request #100: Use pinned version of Hugo

2023-04-05 Thread via GitHub
rlenferink commented on PR #100: URL: https://github.com/apache/comdev-site/pull/100#issuecomment-1497064040 > however the version calls were added for debug purposes and are not needed Removed those statements and simplified the call to Hugo (per your suggestions) -- This is an au

[GitHub] [comdev-site] rlenferink merged pull request #100: Use pinned version of Hugo

2023-04-05 Thread via GitHub
rlenferink merged PR #100: URL: https://github.com/apache/comdev-site/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-events-site] rbowen merged pull request #5: No longer have online platform

2023-04-06 Thread via GitHub
rbowen merged PR #5: URL: https://github.com/apache/comdev-events-site/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.

[GitHub] [comdev-site] sebbASF merged pull request #101: Update Jenkinsfile

2023-04-07 Thread via GitHub
sebbASF merged PR #101: URL: https://github.com/apache/comdev-site/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.ap

[GitHub] [comdev-events-site] sebbASF merged pull request #4: Obsolete

2023-04-07 Thread via GitHub
sebbASF merged PR #4: URL: https://github.com/apache/comdev-events-site/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-events-site] sebbASF merged pull request #3: Add pagefind

2023-04-07 Thread via GitHub
sebbASF merged PR #3: URL: https://github.com/apache/comdev-events-site/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-site] rbowen opened a new pull request, #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
rbowen opened a new pull request, #102: URL: https://github.com/apache/comdev-site/pull/102 This starts documentation around best practice for folks on the various rungs of the "contributor ladder" as they call it at the CNCF: Contributors Committers PMC members There are

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172542784 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172543386 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172544153 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172545711 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172546277 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172546675 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172547346 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172549188 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172550559 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172551026 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172552556 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172552556 ## source/contributor-ladder.md: ## @@ -0,0 +1,122 @@ +--- +title: ASF Contributor Ladder +--- + +Projects at the ASF offer a way to grow in your responsibilites in

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172559623 ## source/contributors/mailing-lists.md: ## @@ -0,0 +1,55 @@ +--- +title: Mailing lists +--- + +The ASF has a long tradition of using mailing lists as the primary +

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172560082 ## source/contributors/mailing-lists.md: ## @@ -0,0 +1,55 @@ +--- +title: Mailing lists +--- + +The ASF has a long tradition of using mailing lists as the primary +

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172565399 ## source/pmc/_index.md: ## @@ -0,0 +1,72 @@ +--- +title: Project Management Committees +--- + +The Project Management Committee, or PMC, is the technical steering

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172565399 ## source/pmc/_index.md: ## @@ -0,0 +1,72 @@ +--- +title: Project Management Committees +--- + +The Project Management Committee, or PMC, is the technical steering

[GitHub] [comdev-site] cottage14 commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
cottage14 commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172567130 ## source/pmc/_index.md: ## @@ -0,0 +1,72 @@ +--- +title: Project Management Committees +--- + +The Project Management Committee, or PMC, is the technical steering

[GitHub] [comdev-site] bdelacretaz commented on pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
bdelacretaz commented on PR #102: URL: https://github.com/apache/comdev-site/pull/102#issuecomment-1516313840 This looks really nice and useful, thanks! I see at least two existing pages that overlap with this new content: * https://apache.org/foundation/how-it-works.html * h

[GitHub] [comdev-site] rbowen commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
rbowen commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1172804091 ## source/pmc/_index.md: ## @@ -0,0 +1,72 @@ +--- +title: Project Management Committees +--- + +The Project Management Committee, or PMC, is the technical steering +co

[GitHub] [comdev-site] rbowen commented on pull request #102: Best practice docs for PMCs, etc

2023-04-20 Thread via GitHub
rbowen commented on PR #102: URL: https://github.com/apache/comdev-site/pull/102#issuecomment-1516614526 All comments addressed. Any objections to merging and moving forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [comdev-site] potiuk commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-21 Thread via GitHub
potiuk commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1173842272 ## source/pmc/responsibilities.md: ## @@ -0,0 +1,88 @@ +--- +title: PMC Responsibilities +--- + +The Project Management Committee (PMC) is responsible for the oversigh

[GitHub] [comdev-site] potiuk commented on a diff in pull request #102: Best practice docs for PMCs, etc

2023-04-21 Thread via GitHub
potiuk commented on code in PR #102: URL: https://github.com/apache/comdev-site/pull/102#discussion_r1173844845 ## source/pmc/responsibilities.md: ## @@ -0,0 +1,88 @@ +--- +title: PMC Responsibilities +--- + +The Project Management Committee (PMC) is responsible for the oversigh

[GitHub] [comdev-site] potiuk commented on pull request #102: Best practice docs for PMCs, etc

2023-04-21 Thread via GitHub
potiuk commented on PR #102: URL: https://github.com/apache/comdev-site/pull/102#issuecomment-1517926192 Small comments only - this looks great @rbowen and others who commented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [comdev-site] rbowen merged pull request #102: Best practice docs for PMCs, etc

2023-04-21 Thread via GitHub
rbowen merged PR #102: URL: https://github.com/apache/comdev-site/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] rbowen merged pull request #103: Not really clear why this is necessary ...

2023-04-21 Thread via GitHub
rbowen merged PR #103: URL: https://github.com/apache/comdev-site/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] rbowen merged pull request #104: moves gsoc to a top-level nav item

2023-04-21 Thread via GitHub
rbowen merged PR #104: URL: https://github.com/apache/comdev-site/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] sebbASF opened a new pull request, #105: Exclude only -staging branches; simplify

2023-04-22 Thread via GitHub
sebbASF opened a new pull request, #105: URL: https://github.com/apache/comdev-site/pull/105 The current pattern for preventing loops works because it does not allow '-' in the branch name. This is a bit restrictived. It would be better to exclude all branches ending in '-staging', a

[GitHub] [comdev-site] bdelacretaz commented on pull request #105: Exclude only -staging branches; simplify

2023-04-24 Thread via GitHub
bdelacretaz commented on PR #105: URL: https://github.com/apache/comdev-site/pull/105#issuecomment-1519621580 Looks good to me, though I haven't tested it myself. Note that the README mentions restrictions on preview branch names that can then be updated. -- This is an automated messag

[GitHub] [comdev-site] sebbASF commented on pull request #105: Exclude only -staging branches; simplify

2023-04-24 Thread via GitHub
sebbASF commented on PR #105: URL: https://github.com/apache/comdev-site/pull/105#issuecomment-1519881292 On Mon, 24 Apr 2023 at 09:30, Bertrand Delacretaz ***@***.***> wrote: > Looks good to me, though I haven't tested it myself. > I tested it in the preview/test2 branch:

[GitHub] [comdev-site] sebbASF merged pull request #105: Exclude only -staging branches; simplify

2023-04-24 Thread via GitHub
sebbASF merged PR #105: URL: https://github.com/apache/comdev-site/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.ap

[GitHub] [comdev-site] rbowen merged pull request #106: Initial prose for several more of these docs

2023-04-25 Thread via GitHub
rbowen merged PR #106: URL: https://github.com/apache/comdev-site/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] swapnilmmane commented on pull request #106: Initial prose for several more of these docs

2023-04-26 Thread via GitHub
swapnilmmane commented on PR #106: URL: https://github.com/apache/comdev-site/pull/106#issuecomment-1522952345 Great stuff, thank you @rbowen! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [comdev-site] sebbASF opened a new pull request, #107: Simplify Jenkinsfile

2023-04-26 Thread via GitHub
sebbASF opened a new pull request, #107: URL: https://github.com/apache/comdev-site/pull/107 Merge Deploy and Staging stages; create empty repo to hold build output -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [comdev-site] sebbASF commented on pull request #107: Simplify Jenkinsfile

2023-04-26 Thread via GitHub
sebbASF commented on PR #107: URL: https://github.com/apache/comdev-site/pull/107#issuecomment-1523940009 Would like to stop Jenkins build if output cannot be deployed. e.g. branch xyz-staging cannot be created by git-site-role, so there is no point building branch xyz. A branch such a

[GitHub] [comdev-site] sebbASF commented on pull request #107: Simplify Jenkinsfile

2023-04-26 Thread via GitHub
sebbASF commented on PR #107: URL: https://github.com/apache/comdev-site/pull/107#issuecomment-1524043183 It may be useful to allow builds even if they are not deployable, so only suppress Deploy stage if it will fail -- This is an automated message from the Apache Git Service. To respond

[GitHub] [comdev-site] bdelacretaz opened a new pull request, #108: Add tag-based navigation

2023-04-27 Thread via GitHub
bdelacretaz opened a new pull request, #108: URL: https://github.com/apache/comdev-site/pull/108 Tag navigation in the preview at https://community-tags.staged.apache.org/ doesn't work as Hugo generates absolute URLs, I don't know how to change that. Anyway the risk of this breaking a

[GitHub] [comdev-site] bdelacretaz merged pull request #108: Add tag-based navigation

2023-04-27 Thread via GitHub
bdelacretaz merged PR #108: URL: https://github.com/apache/comdev-site/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@communit

[GitHub] [comdev-site] rlenferink opened a new pull request, #109: Add a failure and fixed section to the Jenkinsfile for sending notifications

2023-04-28 Thread via GitHub
rlenferink opened a new pull request, #109: URL: https://github.com/apache/comdev-site/pull/109 I think it is useful to ping the dev@ list if a deployment of our main branch failed. Build failures might go unnoticed otherwise. I couldn't use the `when { branch 'main' }` since that app

[GitHub] [comdev-site] bdelacretaz commented on a diff in pull request #109: Add a failure and fixed section to the Jenkinsfile for sending notifications

2023-04-28 Thread via GitHub
bdelacretaz commented on code in PR #109: URL: https://github.com/apache/comdev-site/pull/109#discussion_r1180385710 ## Jenkinsfile: ## @@ -168,5 +168,43 @@ pipeline { } deleteDir() /* clean up our workspace */ } + +// If the build fail

[GitHub] [comdev-site] bdelacretaz commented on a diff in pull request #109: Add a failure and fixed section to the Jenkinsfile for sending notifications

2023-04-28 Thread via GitHub
bdelacretaz commented on code in PR #109: URL: https://github.com/apache/comdev-site/pull/109#discussion_r1180386183 ## Jenkinsfile: ## @@ -168,5 +168,43 @@ pipeline { } deleteDir() /* clean up our workspace */ } + +// If the build fail

[GitHub] [comdev-site] rbowen opened a new pull request, #110: Typos and a few additional links

2023-04-28 Thread via GitHub
rbowen opened a new pull request, #110: URL: https://github.com/apache/comdev-site/pull/110 Typos and a few additional links -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [comdev-site] rbowen merged pull request #110: Typos and a few additional links

2023-04-28 Thread via GitHub
rbowen merged PR #110: URL: https://github.com/apache/comdev-site/pull/110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-events-site] sebbASF opened a new pull request, #6: Update Jenkinsfile

2023-04-28 Thread via GitHub
sebbASF opened a new pull request, #6: URL: https://github.com/apache/comdev-events-site/pull/6 Only install Hugo if necessary Use separate stages for installs Merge Deploy and Staging stages -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [comdev-site] rlenferink opened a new pull request, #111: Import blogs from roller

2023-04-29 Thread via GitHub
rlenferink opened a new pull request, #111: URL: https://github.com/apache/comdev-site/pull/111 INFRA recently announced to projects the need to migrate their blogs since roller will be decommissioned around May 31st: https://lists.apache.org/thread/hfhzochhmqhd32tclgc47d5nk90jxmb2 T

[GitHub] [comdev-site] rlenferink commented on a diff in pull request #109: Add a failure and fixed section to the Jenkinsfile for sending notifications

2023-04-29 Thread via GitHub
rlenferink commented on code in PR #109: URL: https://github.com/apache/comdev-site/pull/109#discussion_r1181025485 ## Jenkinsfile: ## @@ -168,5 +168,43 @@ pipeline { } deleteDir() /* clean up our workspace */ } + +// If the build faile

[GitHub] [comdev-site] rlenferink merged pull request #109: Add a failure and fixed section to the Jenkinsfile for sending notifications

2023-04-29 Thread via GitHub
rlenferink merged PR #109: URL: https://github.com/apache/comdev-site/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-site] cottage14 opened a new pull request, #112: Update _index.md

2023-04-29 Thread via GitHub
cottage14 opened a new pull request, #112: URL: https://github.com/apache/comdev-site/pull/112 lines 26, 30, 40: removed unnecessary comma 38: capitalized 'Board' to match use later in the page 40: changed 'are' to 'is'; navigating gender-free pronouns can be tricky while trying to mai

[GitHub] [comdev-events-site] sebbASF merged pull request #6: Update Jenkinsfile

2023-04-30 Thread via GitHub
sebbASF merged PR #6: URL: https://github.com/apache/comdev-events-site/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-site] sebbASF merged pull request #113: Preview/test3

2023-04-30 Thread via GitHub
sebbASF merged PR #113: URL: https://github.com/apache/comdev-site/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.ap

[GitHub] [comdev-site] rbowen merged pull request #112: Update _index.md

2023-05-04 Thread via GitHub
rbowen merged PR #112: URL: https://github.com/apache/comdev-site/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] rlenferink merged pull request #111: Import blogs from roller

2023-05-09 Thread via GitHub
rlenferink merged PR #111: URL: https://github.com/apache/comdev-site/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-site] rlenferink commented on pull request #107: Simplify Jenkinsfile

2023-05-09 Thread via GitHub
rlenferink commented on PR #107: URL: https://github.com/apache/comdev-site/pull/107#issuecomment-1540358291 @sebbASF am I correct that this PR is no longer needed? (the jenkinsfile on the main branch no longer has a separate staging/deploy branch) -- This is an automated message from the

[GitHub] [comdev-site] sebbASF commented on pull request #107: Simplify Jenkinsfile

2023-05-09 Thread via GitHub
sebbASF commented on PR #107: URL: https://github.com/apache/comdev-site/pull/107#issuecomment-1540441215 Redundant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [comdev-site] sebbASF closed pull request #107: Simplify Jenkinsfile

2023-05-09 Thread via GitHub
sebbASF closed pull request #107: Simplify Jenkinsfile URL: https://github.com/apache/comdev-site/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [comdev-site] bigio opened a new pull request, #114: Add my slides for The Apache Way talk at Merge-it

2023-05-14 Thread via GitHub
bigio opened a new pull request, #114: URL: https://github.com/apache/comdev-site/pull/114 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [comdev-site] rlenferink commented on pull request #114: Add my slides for The Apache Way talk at Merge-it

2023-05-15 Thread via GitHub
rlenferink commented on PR #114: URL: https://github.com/apache/comdev-site/pull/114#issuecomment-1548182496 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [comdev-site] rlenferink merged pull request #114: Add my slides for The Apache Way talk at Merge-it

2023-05-15 Thread via GitHub
rlenferink merged PR #114: URL: https://github.com/apache/comdev-site/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community

[GitHub] [comdev-site] rbowen opened a new pull request, #115: Advice around adding new committers.

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #115: URL: https://github.com/apache/comdev-site/pull/115 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [comdev-site] rbowen merged pull request #115: Advice around adding new committers.

2023-05-15 Thread via GitHub
rbowen merged PR #115: URL: https://github.com/apache/comdev-site/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] rbowen opened a new pull request, #116: Edits Andrew requested

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #116: URL: https://github.com/apache/comdev-site/pull/116 Makes edits that Andrew requested on my most recent patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [comdev-site] rbowen opened a new pull request, #117: Remove link to attic'ed Forrest website.

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #117: URL: https://github.com/apache/comdev-site/pull/117 Resolves COMDEV-421, removing the link to the Forrest guidelines. I, for one, don't want to encourage projects to have a bunch of other committer requirements, and so have opted not to reproduce For

[GitHub] [comdev-site] rbowen opened a new pull request, #118: Removes the 'CoPDoC' section.

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #118: URL: https://github.com/apache/comdev-site/pull/118 Drops the CoPDoc section, which 1) seems out of place in this document in a 2) References an acronym that neither I, not anyone on ComDev I have spoken to has heard of, and 3) Lists some bul

[GitHub] [comdev-site] rbowen opened a new pull request, #119: Make github email subjects more readable

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #119: URL: https://github.com/apache/comdev-site/pull/119 Shamelessly stolen from the PLC4x repo, where it was crafted by @chrisdutz This makes auto-generated email from GitHub more readable, especially on narrow (ie, phone) email clients, by consolidati

[GitHub] [comdev-site] rbowen opened a new pull request, #120: events.apache.org is canonical

2023-05-15 Thread via GitHub
rbowen opened a new pull request, #120: URL: https://github.com/apache/comdev-site/pull/120 Move calendar reference to https://events.apache.org/ which is the canonical source of ASF events. Also removes references to long-defunct resources, in case someone gets to the old resource somehow.

[GitHub] [comdev-site] bdelacretaz commented on pull request #120: events.apache.org is canonical

2023-05-15 Thread via GitHub
bdelacretaz commented on PR #120: URL: https://github.com/apache/comdev-site/pull/120#issuecomment-1548546036 +1 to dropping /calendars and merging this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [comdev-site] rbowen merged pull request #118: Removes the 'CoPDoC' section.

2023-05-16 Thread via GitHub
rbowen merged PR #118: URL: https://github.com/apache/comdev-site/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

[GitHub] [comdev-site] rbowen merged pull request #117: Remove link to attic'ed Forrest website.

2023-05-16 Thread via GitHub
rbowen merged PR #117: URL: https://github.com/apache/comdev-site/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@community.apa

<    1   2   3   4   5   6   >