Re: [PR] Prototype "volunteers" page - DO NOT MERGE (comdev-site)

2023-11-21 Thread via GitHub
sebbASF commented on code in PR #146: URL: https://github.com/apache/comdev-site/pull/146#discussion_r1400778425 ## static/js/components/whimsy-loader.js: ## @@ -0,0 +1,11 @@ +const fetchPublicData = async whimsyFilename => { Review Comment: Please can this info be included

Re: [PR] Prototype "volunteers" page - DO NOT MERGE (comdev-site)

2023-11-21 Thread via GitHub
bdelacretaz commented on code in PR #146: URL: https://github.com/apache/comdev-site/pull/146#discussion_r1400744362 ## static/js/components/whimsy-loader.js: ## @@ -0,0 +1,11 @@ +const fetchPublicData = async whimsyFilename => { Review Comment: It's used by the Web Componen

Re: [PR] Prototype "volunteers" page - DO NOT MERGE (comdev-site)

2023-11-21 Thread via GitHub
sebbASF commented on code in PR #146: URL: https://github.com/apache/comdev-site/pull/146#discussion_r1400726964 ## static/js/components/whimsy-loader.js: ## @@ -0,0 +1,11 @@ +const fetchPublicData = async whimsyFilename => { Review Comment: What is this file for? -- Thi

Re: [PR] Prototype "volunteers" page - DO NOT MERGE (comdev-site)

2023-11-21 Thread via GitHub
Humbedooh commented on PR #146: URL: https://github.com/apache/comdev-site/pull/146#issuecomment-1820555887 FWIW, if you set the PR to _draft_, it cannot be accidentally merged. I have set it to such. -- This is an automated message from the Apache Git Service. To respond to the message,