-1.
No copypasta, please. I want to reduce code patterns that are duplicated
all over the place.
Gary
On Thu, Oct 24, 2024 at 1:15 PM wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> ebourg pushed a commit to branch master
> in repository https://gitbox.apache.o
It looks to me like there are several different changes here.
It seems to me that using standard library methods for ArrayFill and
SystemProperties is a sensible change.
I'm not sure about the other change as it does affect the behaviour,
and does look more complicated.
Perhaps it could be recast
Le 24/10/2024 à 21:05, Gary Gregory a écrit :
Uh, no, don't be disingenuous by showing 3 lines, the commit is many pages
long of diff. All of it is -1 as it increases the code complexity, increase
code duplication, and adds the anti-pattern of throwing RuntimeException
more than once.
My commi
Hello Emmanuel,
Uh, no, don't be disingenuous by showing 3 lines, the commit is many pages
long of diff. All of it is -1 as it increases the code complexity, increase
code duplication, and adds the anti-pattern of throwing RuntimeException
more than once.
Please revert.
Gary
On Thu, Oct 24, 202
Hi Gary,
Le 24/10/2024 à 19:25, Gary Gregory a écrit :
No copypasta, please. I want to reduce code patterns that are duplicated
all over the place.
What do you mean by "copypasta"? Are you concerned about the maintenance
cost of the 3 lines of reflection code appearing twice in
Pack200Unpac
