Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Claude Warren
I think that it should return an empty filter as the javadoc says On Fri 4 Oct 2024, 15:53 Gary D. Gregory, wrote: > See the new disabled test BloomFilterExtractorTest. > > Gary > > On 2024/10/04 14:51:55 "Gary D. Gregory" wrote: > > Hi Claude and all, > > > > The method: > > > > > org.apache.c

Re: [CLI] [DISCUSS] Help formatter extension proposal

2024-10-04 Thread Claude Warren
Thx Gary. I will review this weekend. On Fri 4 Oct 2024, 15:41 Gary D. Gregory, wrote: > Hi all, > > I wrote a bunch of comments in the PR. > > Gary > > On 2024/10/02 10:57:53 Tushar Kapila wrote: > > I don't contribute code. But looking at the dictionary meaning Scribe > fits. > > So my vote i

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary Gregory
OK, but how do you create an empty filter? Gary On Fri, Oct 4, 2024, 12:54 PM Claude Warren wrote: > I think that it should return an empty filter as the javadoc says > > > On Fri 4 Oct 2024, 15:53 Gary D. Gregory, wrote: > > > See the new disabled test BloomFilterExtractorTest. > > > > Gary >

Re: [CLI] [DISCUSS] Help formatter extension proposal

2024-10-04 Thread Gary D. Gregory
Hi all, I wrote a bunch of comments in the PR. Gary On 2024/10/02 10:57:53 Tushar Kapila wrote: > I don't contribute code. But looking at the dictionary meaning Scribe fits. > So my vote is Scribe. > > a word that fits and not confused with existing class/ responsibility? > > verb > 1. > liter

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary D. Gregory
See the new disabled test BloomFilterExtractorTest. Gary On 2024/10/04 14:51:55 "Gary D. Gregory" wrote: > Hi Claude and all, > > The method: > > org.apache.commons.collections4.bloomfilter.BloomFilterExtractor.flatten() > > is documented as always returning a BloomFilter: > > /** >

[collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary D. Gregory
Hi Claude and all, The method: org.apache.commons.collections4.bloomfilter.BloomFilterExtractor.flatten() is documented as always returning a BloomFilter: /** * Create a standard (non-layered) Bloom filter by merging all of the layers. If * the filter is empty this method will re

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Alex Herbert
You cannot return an empty BloomFilter when there is no array of BloomFilters to flatten. The BloomFilter is tied to a Shape. Without a shape you cannot know what size filter to create. So we have to return null or throw an exception. Whatever choice must be documented. Note we do not currently ch

Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Gary Gregory
The problem with returning null is that all call sites must now check for null or end up throwing an NPE. I'd prefer to fail sooner rather than later, so I'd go with throwing an exception and updating the Javadoc. WDYT? Gary On Fri, Oct 4, 2024, 1:30 PM Alex Herbert wrote: > You cannot return