I find a couple of issues:
No documentation for the new options. (I am working on that).
A weird mix of .get() and .build() methods on builders. The new builders
all extend Supplier<> so the get makes sense in that respect, but I don't
think this is the normal nomenclature for Builders. I expec
I also think that the if an Option is marked with deprecated then the
HelpFormatter should, by default, inlcude the "[Deprecated]" line. (I am
working on a change for this too)
On Tue, May 14, 2024 at 2:22 PM Claude Warren wrote:
> I find a couple of issues:
>
> No documentation for the new opt
I *thought* that is how things work…. I am going to double check my usage of
this feature in Solr CLI (not yet released) and report back!
> On May 14, 2024, at 8:25 AM, Claude Warren wrote:
>
> I also think that the if an Option is marked with deprecated then the
> HelpFormatter should, by def
Hi All,
Better documentation is always nice :-)
I vote for Supplier/get() because it does not require the invention of
something new that does _exactly the same thing as the code already
provided in the JRE_.
Gary
On Tue, May 14, 2024 at 8:22 AM Claude Warren wrote:
>
> I find a couple of issu
We already have historical uses of builders in CLI (e.g.
CommandLine.Builder) that use build() not get().
In addition many of the other commons packages have Builders that are
triggered by a "build" call.
On Tue, May 14, 2024 at 3:03 PM Gary Gregory wrote:
> Hi All,
>
> Better documentation is a
Eric, I may have broken it with my implementation of the HelpFormatter
deprecatedFormatFunc() method.
On Tue, May 14, 2024 at 4:06 PM Claude Warren wrote:
> We already have historical uses of builders in CLI (e.g.
> CommandLine.Builder) that use build() not get().
> In addition many of the other
[Note: You're receiving this email because you are subscribed to one
or more project dev@ mailing lists at the Apache Software Foundation.]
We are very close to Community Over Code EU -- check out the amazing
program and the special discounts that we have for you.
Special discounts
You still hav
I will add some tests to show what it is doing in the various cases. But I
think that since we are now providing external developers with the ability
to display custom information about the Option there are a couple of
function that we could probably use internally and provide to the external
deve
I have submitted a draft pull request
https://github.com/apache/commons-cli/pull/272
However, I would like to resolve the Builder/build Builder/get naming issue
before I take it out of draft mode.
On Tue, May 14, 2024 at 6:05 PM Claude Warren wrote:
> I will add some tests to show what it is
IMO future factories should only be Suppliers.
Whether to deprecate current code in favor of Suppliers is possible if only
a bit noisy.
Gary
On Tue, May 14, 2024, 12:22 PM Claude Warren wrote:
> I have submitted a draft pull request
> https://github.com/apache/commons-cli/pull/272
>
> However,
Also think of the anti pattern of all Commons Components implementing their
own factory pattern with a custom interface instead of just reusing Java's
own Supplier.
Gary
On Tue, May 14, 2024, 1:00 PM Gary Gregory wrote:
> IMO future factories should only be Suppliers.
>
> Whether to deprecate c
By factory i assume you mean builder in this context
To my understanding a factory can produce mutiple types of objects while a
builder ony one. I got called out on that awhile ago on a different project
Should we then make all existing builders in CLI implement supplier and
deprecate the curren
I have to admit that i am partial to build but in reviewing gang of four
and various java build patterns i find that there are a number of terminal
methods.
Gary is, I now believe, correct; that the builder should implement Supplier.
On Tue 14 May 2024, 19:28 Claude Warren, wrote:
> By factor
Sounds good to me! Thank you for talking it out. GoF reference appreciated
👏 😉
Looking forward to a PR,
Gary
On Tue, May 14, 2024, 1:47 PM Claude Warren wrote:
> I have to admit that i am partial to build but in reviewing gang of four
> and various java build patterns i find that there are a n
14 matches
Mail list logo
