Re: commons-fileupload2-jakarta

2023-07-12 Thread Martin Tzvetanov Grigorov
Hi, On 2023/07/09 14:45:21 Emmanuel Bourg wrote: > Dumb question: what's the benefit of using commons-fileupload in 2023 > instead of the equivalent file upload feature of the Servlet API? Last time when I tried to replace Commons Fileupload with pure Servlet API I faced these issues: 1) The

Re: [commons-lang] 04/04: Throw IllegalArgumentException instead of InternalError in the builder package

2023-07-12 Thread Gilles Sadowski
Hi. Le mer. 12 juil. 2023 à 14:44, a écrit : > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-lang.git > > commit 2e3feda04337baa483bc26b66f238161dc6c97ac > Author: Gar

Re: [commons-lang] 04/04: Throw IllegalArgumentException instead of InternalError in the builder package

2023-07-12 Thread Gary Gregory
There must be something messed up with EOLs despite my git autocrlf settings... sorry about that. Gary On Wed, Jul 12, 2023, 08:51 Gilles Sadowski wrote: > Hi. > > Le mer. 12 juil. 2023 à 14:44, a écrit : > > > > This is an automated email from the ASF dual-hosted git repository. > > > > ggreg

[pool] Creating the 2.x branch

2023-07-12 Thread Phil Steitz
I think the code in master is close to releasable modulo the breaking change that we have agreed should move to 3.x. The clean way to proceed on the 2.x branch would be to go back to the commit that introduced the new exception type parameter, cut the branch from there and then port all of the sub

Re: [pool] Creating the 2.x branch

2023-07-12 Thread Gary Gregory
My initial impression is that creating a script that edits sources correctly will take longer to write than editing the head of master to remove some of the generics. Recall that the code has other generics. I am guessing that a manual edit is probably a half day to a full day of work, I'm not sur

Re: [pool] Creating the 2.x branch

2023-07-12 Thread Phil Steitz
> On Jul 12, 2023, at 7:14 PM, Gary Gregory wrote: > > My initial impression is that creating a script that edits sources > correctly will take longer to write than editing the head of master to > remove some of the generics. Recall that the code has other generics. > > I am guessing that a