Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-22 Thread Stefan Bodewig
On 2010-02-22, Torsten Curdt wrote: > On Mon, Feb 22, 2010 at 06:11, Stefan Bodewig wrote: >> Technically you haven't read the entry but only its metadata and are now >> asking whether you can also read the actual contents of the entry. > Right. So wouldn't it make sense to call it e.g. > - c

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-22 Thread Torsten Curdt
On Mon, Feb 22, 2010 at 06:11, Stefan Bodewig wrote: > On 2010-02-20, Torsten Curdt wrote: > >>> Then maybe: >>> canReadEntry(entry) >>> canWriteEntry(entry) > >>> to go confirm with: > >>> getNextEntry() Actually re-reading it sounds like you are thinking if (canReadEntry()) { getNextEntry()

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-21 Thread Stefan Bodewig
On 2010-02-20, Torsten Curdt wrote: >> Then maybe: >> canReadEntry(entry) >> canWriteEntry(entry) >> to go confirm with: >> getNextEntry() > Better ... but still. I've already read the entry and then ask whether > I can read it (again)? Technically you haven't read the entry but only its met

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-20 Thread Torsten Curdt
>>> I'm not attached to names and can live with either.  I don't feel >>> stream.canRead(anEntry) is ambiguos, but then again I know what it does. >> >> stream.canWrite(entry) is clear >> >> stream.canRead(entry) I am not quite sure what to make of >> >> I am using getNextEntry() to get an entry. >

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-19 Thread Christian Grobmeier
On Fri, Feb 19, 2010 at 6:49 PM, Torsten Curdt wrote: >>> While I am fine with the changes itself I find the naming "canRead" on >>> an InputStream a little ambiguous. >>> Maybe "canReadArchiveEntry"? Open to other suggestions. >> >> I'm not attached to names and can live with either.  I don't fee

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-19 Thread Torsten Curdt
>> While I am fine with the changes itself I find the naming "canRead" on >> an InputStream a little ambiguous. >> Maybe "canReadArchiveEntry"? Open to other suggestions. > > I'm not attached to names and can live with either.  I don't feel > stream.canRead(anEntry) is ambiguos, but then again I kn

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-19 Thread Stefan Bodewig
On 2010-02-19, Torsten Curdt wrote: > While I am fine with the changes itself I find the naming "canRead" on > an InputStream a little ambiguous. > Maybe "canReadArchiveEntry"? Open to other suggestions. I'm not attached to names and can live with either. I don't feel stream.canRead(anEntry) is

Re: svn commit: r911797 - /commons/proper/compress/trunk/src/changes/changes.xml

2010-02-19 Thread Torsten Curdt
While I am fine with the changes itself I find the naming "canRead" on an InputStream a little ambiguous. Maybe "canReadArchiveEntry"? Open to other suggestions. cheers -- Torsten > -        The Achive*Stream and ZipFile classes now have canRead/Write > +        The Archive*Stream and ZipFile cla