Re: make gzip deflate buffer size configurable

2021-02-19 Thread Brett Okken
https://issues.apache.org/jira/browse/COMPRESS-566 https://github.com/apache/commons-compress/pull/168 Thanks, Brett On Wed, Feb 17, 2021 at 1:23 PM Gary Gregory wrote: > > Yes in both cases is safest. > > Gary > > On Wed, Feb 17, 2021, 14:17 Brett Okken wrote: > > > 512 is also the default in

Re: make gzip deflate buffer size configurable

2021-02-17 Thread Gary Gregory
Yes in both cases is safest. Gary On Wed, Feb 17, 2021, 14:17 Brett Okken wrote: > 512 is also the default in GZIPInputStream, but I agree that it seems > quite small, which is why I want to be able to adjust it :) > > I have not contributed to this project in the past. Does this type of > issu

Re: make gzip deflate buffer size configurable

2021-02-17 Thread Brett Okken
512 is also the default in GZIPInputStream, but I agree that it seems quite small, which is why I want to be able to adjust it :) I have not contributed to this project in the past. Does this type of issue just need a PR, or should I log a JIRA also? Brett On Wed, Feb 17, 2021 at 1:04 PM Gary Gr

Re: make gzip deflate buffer size configurable

2021-02-17 Thread Gary Gregory
Sounds good to me. Also the default seems small, or is that a standard size for Gzip, otherwise 4k or 8k seems better. Gary On Wed, Feb 17, 2021, 11:48 Brett Okken wrote: > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > Are there any objections to making that size confi

make gzip deflate buffer size configurable

2021-02-17 Thread Brett Okken
The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. Are there any objections to making that size configurable in GzipParameters? If that is acceptable, I can create a PR with the changes. Thanks, Brett - To unsub