[GitHub] commons-lang pull request: add isNull and isNotNull methods

2014-05-16 Thread otaviojava
Github user otaviojava closed the pull request at: https://github.com/apache/commons-lang/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: commons-lang pull request: add isNull and isNotNull methods

2014-02-04 Thread Bernd Eckenfels
Hello, I agree, for a simple "isNull(Object)" predicate, this is really an anti pattern. I can understand validate() methods which throw a application specific cleaned up exception and do some logging and stuff. But this is nothing for a external dependency. This is different from isEmpty(String)

Re: commons-lang pull request: add isNull and isNotNull methods

2014-02-04 Thread Adrian Crum
Personally, I view this as an anti-pattern. You have a null reference in your hand, and instead of checking the reference that is in your hand, you give it to an unrelated class and have that class check to see if it is a null reference. That just doesn't make any sense to me. Adrian Crum Sand

commons-lang pull request: add isNull and isNotNull methods

2014-02-04 Thread otaviojava
GitHub user otaviojava opened a pull request: https://github.com/apache/commons-lang/pull/16 add isNull and isNotNull methods Sugestion to add two simple and useful methods, with tests, on ObjectsUtil to get the code cleaner. isnull and isNotNull. So you can use if (ObjectUtil.isNu