Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-26 Thread Gary Gregory
On Thu, Jul 26, 2018 at 1:31 PM Oliver Heger wrote: > > > Am 25.07.2018 um 23:36 schrieb Gary Gregory: > > I'd we do not already have that, the name does not need "defensive". > > Commons Collections would be where to put collections related code. > > I would rather think that this copy functiona

Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-26 Thread Oliver Heger
Am 25.07.2018 um 23:36 schrieb Gary Gregory: > I'd we do not already have that, the name does not need "defensive". > Commons Collections would be where to put collections related code. I would rather think that this copy functionality is pretty basic, so I would put it in [lang]. I would not w

Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-25 Thread Gary Gregory
I'd we do not already have that, the name does not need "defensive". Commons Collections would be where to put collections related code. Gary On Wed, Jul 25, 2018, 14:00 Oliver Heger wrote: > +1, Thank you. > > I had planned to create a patch for this issue, but did not find the > time so far.

Re: commons-dbcp git commit: [DBCP-517] Make defensive copies of char[] passwords.

2018-07-25 Thread Oliver Heger
+1, Thank you. I had planned to create a patch for this issue, but did not find the time so far. BTW, I have quite often the need to create defensive copies of arrays or collections in some variants (e.g. null safe, with wrapping to an unmodifiable collection, etc.). Could this be an addition to