Re: commons-crypto git commit: Fallback no longer exists

2016-06-29 Thread Stian Soiland-Reyes
+1 to make sure the Benchmark class is normally compiled (or at least during a -Prelease). JMH is licensed as ASF-incompatible GPL 2.0, but that's OK for a test dependency - particularly as a user can just remove it if they don't run the benchmark tests. On 29 June 2016 at 11:27, sebb AT AS

Re: commons-crypto git commit: Fallback no longer exists

2016-06-29 Thread sebb AT ASF
This compile error was not picked up because the Benchmark class is only compiled if the -Pbenchmark profile is used. The class cannot currently be compiled in normal mode because it depends on JMH which is only included as a test dependency by the profile. I'm wondering whether the test dependen