This should likely be one PR, see comments in the PR. In general, when you
submit a fix in a PR, it should contain changes to both main and test. The
test changed or added to the test folder should fail without the changes to
main.
Gary
On Wed, Apr 19, 2023, 01:30 Miguel Muñoz wrote:
> Today I
Today I resubmitted both changes as Pull Requests.
— Miguel Muñoz
On Tue, Apr 18, 2023 at 3:44 AM Gary Gregory wrote:
> Thanks Miguel,
>
> Please provide changes as PRs on GiHub. This is the best way to go IMO
> because it runs code against all tests on all configured OSs and Java
> versions, a
Thanks Miguel,
Please provide changes as PRs on GiHub. This is the best way to go IMO
because it runs code against all tests on all configured OSs and Java
versions, and provides the least friction for managing changes.
TY!
Gary
On Tue, Apr 18, 2023, 04:20 Miguel Muñoz wrote:
> Developers,
>
>
>
> Or as a Github PR:
>
+1
On Tue, 18 Apr 2023 at 11:18, sebb wrote:
> Or as a Github PR:
>
> https://github.com/apache/commons-io/pulls
>
> These systems are easier for developers to track than emails, which
> can get overlooked.
>
> On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski
> wrote:
> >
Or as a Github PR:
https://github.com/apache/commons-io/pulls
These systems are easier for developers to track than emails, which
can get overlooked.
On Tue, 18 Apr 2023 at 09:54, Gilles Sadowski wrote:
>
> Hi.
>
> Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit :
> >
> > Developers,
> >
>
Hi.
Le mar. 18 avr. 2023 à 10:20, Miguel Muñoz a écrit :
>
> Developers,
>
> (I'm new to Apache,
Welcome.
> so I hope this is the right way to submit patches.)
The usual way would be to file a report on the bug-tracking system:
https://issues.apache.org/jira/projects/IO
and upload patches th
the current directory:
@@ -61,6 +62,17 @@
* @see FileFilterUtils#fileFileFilter()
*/
public class SymbolicLinkFileFilter extends AbstractFileFilter implements Serializable {
+/*
+ * Note to developers: The unit test needs to create symbolic links to files. However, on
+ * Windows, this
"The class per its javadoc filters for symbolic links on files."
It sounds like it's only supposed to pass files that are symbolic links. If
that's the idea, the class doesn't work at all. If not, we need a clearer
description.
As for unit tests, maybe the test should detect the Windows OS and ju
Here's a better idea for how to write the unit test.
First, we put something in the SymbolicLinkFileFilter class like this:
public class SymbolicLinkFileFilter {
private static LinkTester linkTester = new LinkTester(); // defined below
static setLinkTesterForUnitTests(LinkT
Hi Miguel,
Thank you for reviewing. A better unit test would help of course ;-) but
testing links can be a pain as the JVM requires admin rights on Windows 10
at least. This might not be an issue for GitHub but be aware of it if you
run builds locally.
The class per its javadoc filters for symbol
Let's assume this is for IO, not VFS; in the future, please prefix email
subjects with
[IO] or [VFS] or whatever Commons component is being discussed.
TY!
Gary
On Thu, Apr 13, 2023, 01:59 Miguel Muñoz wrote:
> It's not clear what exactly this filter is supposed to do. From its
> behavior, I gat
It's not clear what exactly this filter is supposed to do. From its
behavior, I gather that it's supposed to distinguish files from
directories, treating Symbolic links as ordinary files. There are two
reasons why this isn't clear.
1. This behavior (usually) seems identical to that of a filter tha
12 matches
Mail list logo
