Re: [configuration] review for PR 30

2019-07-02 Thread Emmanuel Bourg
Le 02/07/2019 à 01:59, Gary Gregory a écrit : > What would you call the method? I don't know, setPropertyDirectInternal? It's private anyway, the name isn't important. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@co

Re: [configuration] review for PR 30

2019-07-01 Thread Gary Gregory
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg wrote: > Le 01/07/2019 à 16:26, Gary Gregory a écrit : > > > May anyone that knows enough of the internals of [configuration] please > > comment on https://github.com/apache/commons-configuration/pull/30 > > I got a quick look, besides the setArrayPro

Re: [configuration] review for PR 30

2019-07-01 Thread Emmanuel Bourg
Le 01/07/2019 à 16:26, Gary Gregory a écrit : > May anyone that knows enough of the internals of [configuration] please > comment on https://github.com/apache/commons-configuration/pull/30 I got a quick look, besides the setArrayProperty method that doesn't seem to have the right name (there is n

[configuration] review for PR 30

2019-07-01 Thread Gary Gregory
Hi All: May anyone that knows enough of the internals of [configuration] please comment on https://github.com/apache/commons-configuration/pull/30 ? Gary

Re: [VFS] Review for PR-30

2018-05-16 Thread Otto Fowler
https://travis-ci.org/apache/commons-vfs/jobs/342781180 On May 15, 2018 at 13:44:25, Gary Gregory (garydgreg...@gmail.com) wrote: Hopefully I can take a look this week. Do all tests pass? Like 'mvn clean test'. Gary On Mon, May 14, 2018 at 7:44 AM, Otto Fowler wrote: > https://github.com/ap

Re: [VFS] Review for PR-30

2018-05-15 Thread Gary Gregory
Hopefully I can take a look this week. Do all tests pass? Like 'mvn clean test'. Gary On Mon, May 14, 2018 at 7:44 AM, Otto Fowler wrote: > https://github.com/apache/commons-vfs/pull/30 > > Any chance getting some eyes on this? >

[VFS] Review for PR-30

2018-05-14 Thread Otto Fowler
https://github.com/apache/commons-vfs/pull/30 Any chance getting some eyes on this?

Re: Review for PR

2016-08-25 Thread sebb
On 25 August 2016 at 17:04, Raviteja Lokineni wrote: > The pull request is closed. If you like people to review and merge it: > >1. It should be open >2. There should be an associated JIRA issue Good advice. Also note that most developers work on ASF projects in their own time, so bugs m

Re: Review for PR

2016-08-25 Thread Raviteja Lokineni
The pull request is closed. If you like people to review and merge it: 1. It should be open 2. There should be an associated JIRA issue Thanks, Raviteja On Wed, Aug 24, 2016 at 7:37 AM, Utsav Oza wrote: > While surfing through the code base I encountered few spelling errors in > the comm

Review for PR

2016-08-24 Thread Utsav Oza
While surfing through the code base I encountered few spelling errors in the comments provided alongside the code. Please review this pull request and let me know if I am attempting anything in a wrong way or not. https://github.com/apache/commons-net/pull/4 Regards Utsav