Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

2024-04-02 Thread sebb
On Tue, 2 Apr 2024 at 15:40, mogasale.tech wrote: > > Thanks for the response. > > I have thoughts about this change not only within DomainValidator, but also > to make it configurable at the two classes (EmailValidator and > UrlValidator) where DomainValidator#isValid is consumed today. > > I'll

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

2024-04-02 Thread Oliver B. Fischer
+1 Am 31.03.24 um 04:43 schrieb mogasale.tech: Hi Team, Here is the proposal to make DomainValidator#isValidDomainSyntax method in commons-validator library public, currently it is package private. Below are the reasoning behind the same. 1. In many use cases, products just need to validate th

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

2024-04-02 Thread mogasale.tech
Thanks for the response. I have thoughts about this change not only within DomainValidator, but also to make it configurable at the two classes (EmailValidator and UrlValidator) where DomainValidator#isValid is consumed today. I'll give it a try in a few days. Regards, Ram On Sun, 31 Mar 2024 a

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

2024-03-30 Thread Gary Gregory
Ram, Feel free to provide a PR on GitHub. Gary On Sat, Mar 30, 2024, 10:43 PM mogasale.tech wrote: > Hi Team, > > Here is the proposal to make DomainValidator#isValidDomainSyntax method in > commons-validator library public, currently it is package private. Below > are the reasoning behind the