Re: [pool] Another source compatibility break in 2.x

2023-07-21 Thread Phil Steitz
On Fri, Jul 21, 2023 at 5:17 AM Elliotte Rusty Harold wrote: > On Thu, Jul 20, 2023 at 8:27 PM Phil Steitz wrote: > > > > We have a minor source compat break still in 2.x > > > > The change to have BaseGenericObjectPool implement Autocloseable forced > > addition of an abstract close method. Te

Re: [pool] Another source compatibility break in 2.x

2023-07-21 Thread Gary Gregory
1a or 1b seem fine and least intrusive. Gary On Thu, Jul 20, 2023, 20:28 Phil Steitz wrote: > We have a minor source compat break still in 2.x > > The change to have BaseGenericObjectPool implement Autocloseable forced > addition of an abstract close method. Technically, that could break > sub

Re: [pool] Another source compatibility break in 2.x

2023-07-21 Thread Elliotte Rusty Harold
On Thu, Jul 20, 2023 at 8:27 PM Phil Steitz wrote: > > We have a minor source compat break still in 2.x > > The change to have BaseGenericObjectPool implement Autocloseable forced > addition of an abstract close method. Technically, that could break > subclass implementations that don't implement