Re: [pool] Reusing Config

2010-10-28 Thread Simone Tripodi
Thanks a lot Seb, your suggestions are always appreciated :) Thanks for the sample, I see your troubles on ctor/builder, I think it makes much more sense when the number of arguments is very large, like the Generic(Keyed)ObjectPool(Factory). Do you have options to suggest? Thanks in advance. Abou

Re: [pool] Reusing Config

2010-10-28 Thread sebb
On 28 October 2010 18:50, Simone Tripodi wrote: > Hi Seb, > thanks for your feedbacks. Please read my questions inline your comments > >> The public StackObjectPoolConfig ctor repeats the settings available >> in the nested Builder. >> I'm not sure I see the point of having both. Or perhaps the ct

Re: [pool] Reusing Config

2010-10-28 Thread Simone Tripodi
Hi Seb, thanks for your feedbacks. Please read my questions inline your comments > The public StackObjectPoolConfig ctor repeats the settings available > in the nested Builder. > I'm not sure I see the point of having both. Or perhaps the ctor is > supposed to be private? I'm sorry but I didn't u

Re: [pool] Reusing Config

2010-10-28 Thread sebb
On 28 October 2010 15:16, Simone Tripodi wrote: > Hi again James, all, > please review my last commit[1], I refactored the Config and related > (Keyed)StackObjectPool(Factory), I tried to implements the concepts > we've been discussing in this thread. The public StackObjectPoolConfig ctor repeats

Re: [pool] Reusing Config

2010-10-28 Thread Simone Tripodi
Hi again James, all, please review my last commit[1], I refactored the Config and related (Keyed)StackObjectPool(Factory), I tried to implements the concepts we've been discussing in this thread. If this fits to our vision, I can follow applying the refactor to Generic(Keyed)ObjectPool(Factory). Ma

Re: [pool] Reusing Config

2010-10-28 Thread Simone Tripodi
Hi James, thanks, understood. I take in charge yet another cycle of refactoring, I'll ping you all when in trouble about something :) Have a nice day and thanks for the feedbacks! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Thu, Oct 28, 2010 at 2:12 PM, James Carman

Re: [pool] Reusing Config

2010-10-28 Thread James Carman
On Thu, Oct 28, 2010 at 6:50 AM, Simone Tripodi wrote: > That's why I wouldn't follow the option #2; but please, explain me > which are the side effects of that design, so I can avoid to repeat > the same mistake in the future. > If you make the config objects immutable, you can just keep the con

Re: [pool] Reusing Config

2010-10-28 Thread Simone Tripodi
Hi all guys, sorry to be late but I had to read all the resume before posting something useful :P So, briefly, just my 2 cents with the hope to contribute in a useful way: About the JMX support, that could involve also the whole design, I suggest on keeping out the Configuration but rather taking

Re: [pool] Reusing Config part 2

2010-10-26 Thread Simone Tripodi
: >> -Original Message- >> From: Phil Steitz [mailto:phil.ste...@gmail.com] >> Sent: Monday, October 25, 2010 08:50 >> To: Commons Developers List >> Subject: Re: [pool] Reusing Config part 2 >> >> On 10/25/10 11:26 AM, Gary Gregory wrote: >

RE: [pool] Reusing Config part 2

2010-10-25 Thread Gary Gregory
> -Original Message- > From: Phil Steitz [mailto:phil.ste...@gmail.com] > Sent: Monday, October 25, 2010 08:50 > To: Commons Developers List > Subject: Re: [pool] Reusing Config part 2 > > On 10/25/10 11:26 AM, Gary Gregory wrote: > > Thank you for working thr

RE: [pool] Reusing Config part 2

2010-10-25 Thread Gary Gregory
> -Original Message- > From: Steven Siebert [mailto:smsi...@gmail.com] > Sent: Monday, October 25, 2010 08:43 > To: Commons Developers List > Subject: Re: [pool] Reusing Config part 2 > > Gary, > > I tossed this around as well, and noted these fields as a &

Re: [pool] Reusing Config

2010-10-25 Thread Phil Steitz
On 10/25/10 12:36 PM, James Carman wrote: On Mon, Oct 25, 2010 at 12:25 PM, Phil Steitz wrote: I notice now what I missed on initial review of Simo's patch - the pool accessors now manage the config properties via persisted Config members. I am OK with this, but it now means that the Config c

Re: [pool] Reusing Config

2010-10-25 Thread James Carman
On Mon, Oct 25, 2010 at 12:25 PM, Phil Steitz wrote: > > I notice now what I missed on initial review of Simo's patch - the pool > accessors now manage the config properties via persisted Config members.  I > am OK with this, but it now means that the Config classes have to be > mutable.  What nee

Re: [pool] Reusing Config

2010-10-25 Thread Phil Steitz
ceed on JMX support. Have a nice day, Simo http://people.apache.org/~simonetripodi/< http://people.apache.org/%7Esimonetripodi/> http://www.99soft.org/ On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory wrote: -Original Message- From: Steven Siebert [mailto:smsi...@gmail.com] Sent: Thurs

Re: [pool] Reusing Config part 2

2010-10-25 Thread Phil Steitz
4.760.1560 Email: ggreg...@seagullsoftware.com Web: seagull.rocketsoftware.com -Original Message- From: Simone Tripodi [mailto:simone.trip...@gmail.com] Sent: Monday, October 25, 2010 05:36 To: Commons Developers List Subject: Re: [pool] Reusing Config Hi all mates, I updated the

Re: [pool] Reusing Config part 2

2010-10-25 Thread Steven Siebert
Software > 3340 Peachtree Road, Suite 820 • Atlanta, GA 30326 • USA > Tel: +1.404.760.1560 > Email: ggreg...@seagullsoftware.com > Web: seagull.rocketsoftware.com > > > -Original Message- > > From: Simone Tripodi [mailto:simone.trip...@gmail.com] > > Sent: Monday, October 25, 2

Re: [pool] Reusing Config

2010-10-25 Thread Phil Steitz
Siebert [mailto:smsi...@gmail.com] Sent: Thursday, October 21, 2010 18:08 To: Commons Developers List Subject: Re: [pool] Reusing Config Gary, Great work so far. I'm checking out the diffs now, I'm gonna hack out some simple UML "diffs", if only to wrap my head around it al

Re: [pool] Reusing Config

2010-10-25 Thread Steven Siebert
; could start committing the modifications and proceed on JMX support. >>> Have a nice day, >>> Simo >>> >>> http://people.apache.org/~simonetripodi/< >>> http://people.apache.org/%7Esimonetripodi/> >>> >>> http://www.99soft.org/

Re: [pool] Reusing Config

2010-10-25 Thread Phil Steitz
y wrote: -Original Message- From: Steven Siebert [mailto:smsi...@gmail.com] Sent: Thursday, October 21, 2010 18:08 To: Commons Developers List Subject: Re: [pool] Reusing Config Gary, Great work so far. I'm checking out the diffs now, I'm gonna hack out some simple UML &qu

Re: [pool] Reusing Config

2010-10-25 Thread Phil Steitz
he.org/%7Esimonetripodi/> http://www.99soft.org/ On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory wrote: -Original Message- From: Steven Siebert [mailto:smsi...@gmail.com] Sent: Thursday, October 21, 2010 18:08 To: Commons Developers List Subject: Re: [pool] Reusing Config Gary, Great w

Re: [pool] Reusing Config

2010-10-25 Thread Steven Siebert
jira issue uploading my patch; it contains the > >> >> configuration extraction and some code modification. > >> >> IMHO we shouldn't replicate the same data in both configuration AND > >> >> factory/pool, when creating the factory/pool it is enough storing the

Re: [pool] Reusing Config

2010-10-25 Thread Simone Tripodi
data in both configuration AND >> >> factory/pool, when creating the factory/pool it is enough storing the >> >> configuration reference, just use it. >> >> I intentionally missed the interfaces layer, since they can be added >> >> directly in the J

Re: [pool] Reusing Config

2010-10-25 Thread Steven Siebert
t; >> directly in the JMX support in the required form. > >> Please take a look at the patch and provide feedbacks, if you agree I > >> could start committing the modifications and proceed on JMX support. > >> Have a nice day, > >> Simo > >> > >

Re: [pool] Reusing Config

2010-10-25 Thread Simone Tripodi
ns and proceed on JMX support. >> Have a nice day, >> Simo >> >> http://people.apache.org/~simonetripodi/<http://people.apache.org/%7Esimonetripodi/> >> http://www.99soft.org/ >> >> >> >> On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory >

Re: [pool] Reusing Config

2010-10-25 Thread Steven Siebert
ginal Message- > >> From: Steven Siebert [mailto:smsi...@gmail.com] > >> Sent: Thursday, October 21, 2010 18:08 > >> To: Commons Developers List > >> Subject: Re: [pool] Reusing Config > >> > >> Gary, > >> > >> Great wor

Re: [pool] Reusing Config

2010-10-25 Thread Simone Tripodi
http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Fri, Oct 22, 2010 at 5:23 AM, Gary Gregory wrote: >> -Original Message- >> From: Steven Siebert [mailto:smsi...@gmail.com] >> Sent: Thursday, October 21, 2010 18:08 >> To: Commons Developers List >>

RE: [pool] Reusing Config

2010-10-21 Thread Gary Gregory
> -Original Message- > From: Steven Siebert [mailto:smsi...@gmail.com] > Sent: Thursday, October 21, 2010 18:08 > To: Commons Developers List > Subject: Re: [pool] Reusing Config > > Gary, > > Great work so far. I'm checking out the diffs now, I'm go

Re: [pool] Reusing Config

2010-10-21 Thread Steven Siebert
: > > -Original Message- > > From: Phil Steitz [mailto:phil.ste...@gmail.com] > > Sent: Thursday, October 21, 2010 06:29 > > To: Commons Developers List > > Subject: Re: [pool] Reusing Config > > > > On 10/21/10, Simone Tripodi wrote: > > > it seems

RE: [pool] Reusing Config

2010-10-21 Thread Gary Gregory
> -Original Message- > From: Phil Steitz [mailto:phil.ste...@gmail.com] > Sent: Thursday, October 21, 2010 06:29 > To: Commons Developers List > Subject: Re: [pool] Reusing Config > > On 10/21/10, Simone Tripodi wrote: > > it seems you've been doing a

Re: [pool] Reusing Config

2010-10-21 Thread Phil Steitz
oft.org/ > > > > On Thu, Oct 21, 2010 at 8:23 AM, Gary Gregory > wrote: >>> -Original Message- >>> From: Simone Tripodi [mailto:simone.trip...@gmail.com] >>> Sent: Wednesday, October 20, 2010 22:41 >>> To: Commons Developers List >>

Re: [pool] Reusing Config

2010-10-21 Thread Simone Tripodi
om] >> Sent: Wednesday, October 20, 2010 22:41 >> To: Commons Developers List >> Subject: Re: [pool] Reusing Config >> >> Hi Gary! >> unfortunately the link replied with 404 code, can you give me please >> the issue ID? > > It's https://issues.apach

RE: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
> -Original Message- > From: Simone Tripodi [mailto:simone.trip...@gmail.com] > Sent: Wednesday, October 20, 2010 22:41 > To: Commons Developers List > Subject: Re: [pool] Reusing Config > > Hi Gary! > unfortunately the link replied with 404 code, can you give

Re: [pool] Reusing Config

2010-10-20 Thread Simone Tripodi
greg...@seagullsoftware.com > Web: seagull.rocketsoftware.com > > > >> -Original Message- >> From: Simone Tripodi [mailto:simone.trip...@gmail.com] >> Sent: Wednesday, October 20, 2010 14:53 >> To: Commons Developers List >> Subject: Re: [pool] Reusing Confi

RE: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
Web: seagull.rocketsoftware.com  > -Original Message- > From: Simone Tripodi [mailto:simone.trip...@gmail.com] > Sent: Wednesday, October 20, 2010 14:53 > To: Commons Developers List > Subject: Re: [pool] Reusing Config > > Hi, > sorry for not having been c

Re: [pool] Reusing Config

2010-10-20 Thread Simone Tripodi
seagull.rocketsoftware.com > > > >> -Original Message- >> From: Simone Tripodi [mailto:simone.trip...@gmail.com] >> Sent: Wednesday, October 20, 2010 12:22 >> To: Commons Developers List >> Subject: Re: [pool] Reusing Config >> >> sure, I always

RE: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
4.760.1560 Email: ggreg...@seagullsoftware.com Web: seagull.rocketsoftware.com  > -Original Message- > From: Simone Tripodi [mailto:simone.trip...@gmail.com] > Sent: Wednesday, October 20, 2010 12:22 > To: Commons Developers List > Subject: Re: [pool] Reusing Config >

RE: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
> -Original Message- > From: Steven Siebert [mailto:smsi...@gmail.com] > Sent: Wednesday, October 20, 2010 12:51 > To: Commons Developers List > Subject: Re: [pool] Reusing Config > > I apologize for not getting the proposal for the MBean API out quite yet - > need

Re: [pool] Reusing Config

2010-10-20 Thread Steven Siebert
I apologize for not getting the proposal for the MBean API out quite yet - needed some sleep last night =) Gary, it seems your question is more approaching the issue academically, asking if the configuration can be extracted (indeed, abstracted) for reuse. Depending on your intent, this may or ma

Re: [pool] Reusing Config

2010-10-20 Thread Simone Tripodi
sure, I always wait for feedbacks before coding :P Cool expression "Rambo through the code", that was the first time I read it and made me laugh :D All the best, Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Wed, Oct 20, 2010 at 9:17 PM, Gary Gregory wrote: > It seems

Re: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
It seems to me there is a reason the code is the way it is so I'd really like to hear thoughts from some of the original authors before we go and Rambo through the code ;) Gary On Oct 20, 2010, at 12:13, "Simone Tripodi" wrote: > Hi Gary, > yes that's me that raised the question[1] and discus

Re: [pool] Reusing Config

2010-10-20 Thread Simone Tripodi
Hi Gary, yes that's me that raised the question[1] and discussed a little with Seb. What blocked me was the JMX support proposal since I'm not familiar with that technology, so I was consulting documentation to study. My very big +1 for that, with the wish of work directly on that stuff. Anyone el

RE: [pool] Reusing Config

2010-10-20 Thread Gary Gregory
In the same department, I see the following ivars: lifo : boolean maxActive : int maxIdle : int maxTotal : int maxWait : long minEvictableIdleTimeMillis : long minIdle : int numTestsPerEvictionRun : int testOnBorrow : boolean testOnReturn : boolean testWhileIdle : boolean timeBetweenEvictionRunsMi