RE: [lang] Suggested alternatives for escape functions

2013-12-11 Thread Peter Wall
Gary, I'm not sure how I would present this as a patch - it affects a number of different methods of the StringEscapeUtils class. I have created a JIRA item [LANG-935] https://issues.apache.org/jira/browse/LANG-935 and I have attached a zip file with source code for my alternative implementa

Re: [lang] Suggested alternatives for escape functions

2013-12-10 Thread Peter Wall
Hi Bernd, Thank you for taking the time to look at my submission. Let me see if I can answer your comments: 1. I have a separate version (which I did not include in my original email; I thought it was already long enough) which handles UTF-16 strings, that is, strings which could include U

Re: [lang] Suggested alternatives for escape functions

2013-12-10 Thread Bernd Eckenfels
Hello, it depends on what you want to escape, a single Unicode character could be 2 codepoints (UTF-16 codepoints can only cover the BMP). So having a String typed needle can be helpfull. But of course all the usual things are single-codepoint characters (<>&"...). Having said that, any rea

RE: [lang] Suggested alternatives for escape functions

2013-12-10 Thread Gary Gregory
Peter, Thank you for sharing with us. Can you provide your code as a patch in a JIRA issue? Hopefully unit tests still pass and the 7F conversion will not break compatibility. You should also provide your benchmark code so others can duplicate your findings. Make sure you work off of trunk in