Re: [DBCP] svn commit: r734473

2009-01-20 Thread Rahul Akolkar
On Mon, Jan 19, 2009 at 1:46 PM, sebb wrote: > On 19/01/2009, Rahul Akolkar wrote: >> Not really a DBCP only discussion at this point ... >> >> >> On Sun, Jan 18, 2009 at 1:20 PM, sebb wrote: >> > On 18/01/2009, Rahul Akolkar wrote: >> >> I think whats being pointed out >> >> here is tha

Re: [DBCP] svn commit: r734473

2009-01-19 Thread sebb
On 19/01/2009, Rahul Akolkar wrote: > Not really a DBCP only discussion at this point ... > > > On Sun, Jan 18, 2009 at 1:20 PM, sebb wrote: > > On 18/01/2009, Rahul Akolkar wrote: > >> On Thu, Jan 15, 2009 at 6:22 AM, sebb wrote: > >> > On 15/01/2009, Mark Thomas wrote: > >> >> > From:

Re: [DBCP] svn commit: r734473

2009-01-19 Thread Rahul Akolkar
Not really a DBCP only discussion at this point ... On Sun, Jan 18, 2009 at 1:20 PM, sebb wrote: > On 18/01/2009, Rahul Akolkar wrote: >> On Thu, Jan 15, 2009 at 6:22 AM, sebb wrote: >> > On 15/01/2009, Mark Thomas wrote: >> >> > From: Phil Steitz [mailto:phil.ste...@gmail.com] >> >> >> >>

Re: [DBCP] svn commit: r734473

2009-01-18 Thread sebb
On 18/01/2009, Rahul Akolkar wrote: > On Thu, Jan 15, 2009 at 6:22 AM, sebb wrote: > > On 15/01/2009, Mark Thomas wrote: > >> > From: Phil Steitz [mailto:phil.ste...@gmail.com] > >> > >> > > >> > Stephen Colebourne wrote: > >> > > Rahul Akolkar wrote: > >> > >> > >> > >> > >> Note th

Re: [DBCP] svn commit: r734473

2009-01-17 Thread Phil Steitz
Rahul Akolkar wrote: On Thu, Jan 15, 2009 at 6:22 AM, sebb wrote: On 15/01/2009, Mark Thomas wrote: From: Phil Steitz [mailto:phil.ste...@gmail.com] > Stephen Colebourne wrote: > > Rahul Akolkar wrote: > >> Note that the above breaks binary and source compatibili

Re: [DBCP] svn commit: r734473

2009-01-17 Thread Rahul Akolkar
On Thu, Jan 15, 2009 at 6:22 AM, sebb wrote: > On 15/01/2009, Mark Thomas wrote: >> > From: Phil Steitz [mailto:phil.ste...@gmail.com] >> >> > >> > Stephen Colebourne wrote: >> > > Rahul Akolkar wrote: >> > >> >> >> > >> Note that the above breaks binary and source compatibility. >> > Therefo

Re: [DBCP] svn commit: r734473

2009-01-15 Thread sebb
On 15/01/2009, Mark Thomas wrote: > > From: Phil Steitz [mailto:phil.ste...@gmail.com] > > > > > Stephen Colebourne wrote: > > > Rahul Akolkar wrote: > > >> > > > >> Note that the above breaks binary and source compatibility. > > Therefore, > > >> at the least, such changes deserve notable me

RE: [DBCP] svn commit: r734473

2009-01-15 Thread Mark Thomas
> From: Phil Steitz [mailto:phil.ste...@gmail.com] > > Stephen Colebourne wrote: > > Rahul Akolkar wrote: > >> > >> Note that the above breaks binary and source compatibility. > Therefore, > >> at the least, such changes deserve notable mentions in the release > >> notes and often additional thoug

Re: [DBCP] svn commit: r734473

2009-01-14 Thread Phil Steitz
Stephen Colebourne wrote: Rahul Akolkar wrote: On Wed, Jan 14, 2009 at 1:36 PM, wrote: Author: sebb Date: Wed Jan 14 10:36:07 2009 New Revision: 734473 URL: http://svn.apache.org/viewvc?rev=734473&view=rev Log: Make non-private static fields final Note that the above breaks binary and sou

Re: [DBCP] svn commit: r734473

2009-01-14 Thread Stephen Colebourne
Rahul Akolkar wrote: On Wed, Jan 14, 2009 at 1:36 PM, wrote: Author: sebb Date: Wed Jan 14 10:36:07 2009 New Revision: 734473 URL: http://svn.apache.org/viewvc?rev=734473&view=rev Log: Make non-private static fields final Note that the above breaks binary and source compatibility. Therefor

Re: [DBCP] svn commit: r734473

2009-01-14 Thread Rahul Akolkar
On Wed, Jan 14, 2009 at 1:36 PM, wrote: > Author: sebb > Date: Wed Jan 14 10:36:07 2009 > New Revision: 734473 > > URL: http://svn.apache.org/viewvc?rev=734473&view=rev > Log: > Make non-private static fields final Note that the above breaks binary and source compatibility. Therefore, at the le