Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread sebb
arman [mailto:ja...@carmanconsulting.com] >> Sent: Wednesday, June 08, 2016 4:03 AM >> To: Commons Developers List >> Subject: Re: [BCEL6] StackMapTable / StackMapTableEntry gone >> >> Let's be clear here. We are proposing changing the code because someone >&g

RE: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread Mark Roberts
. Thank you, Mark Roberts > -Original Message- > From: James Carman [mailto:ja...@carmanconsulting.com] > Sent: Wednesday, June 08, 2016 4:03 AM > To: Commons Developers List > Subject: Re: [BCEL6] StackMapTable / StackMapTableEntry gone > > Let's be clear here. We

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread Andrey Loskutov
I think I've found a way to fix the compile problems without introducing back StackMapTable / StackMapTableEntry classes to BCEL6, see https://github.com/findbugsproject/findbugs/commit/2e1807e82c18ce646e0298b8d0597e5eeb49c0af FindBugs is now compilable on BCEL6 latest greatest head, but our tes

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread James Carman
Let's be clear here. We are proposing changing the code because someone used a SNAPSHOT version and released their code which uses it? That code was never released and I don't know that it's right to bind us to a work-in-progress. It's bad enough we have to be saddled forever with the burden of

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread sebb
On 8 June 2016 at 10:34, Andrey Loskutov wrote: > On Wednesday 08 June 2016 10:17 sebb wrote: >> OK, so what options are there? >> >> A) add the classes back in, but deprecate the class(es) and defer to >> the new implementation if possible >> B) Update Findbugs to use the new design >> >> Anythin

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread Andrey Loskutov
On Wednesday 08 June 2016 10:17 sebb wrote: > OK, so what options are there? > > A) add the classes back in, but deprecate the class(es) and defer to > the new implementation if possible > B) Update Findbugs to use the new design > > Anything else? > > == > > If the choice is between A and B, t

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread sebb
On 8 June 2016 at 10:01, Andrey Loskutov wrote: > On Wednesday 08 June 2016 08:37 Benedikt Ritter wrote: >> Hallo Andrey, >> >> Andrey Loskutov schrieb am Mi., 8. Juni 2016 um 09:36 Uhr: >> >> > Hi, >> > >> > I'm following the package rename and trying to fix compile issues with >> > BCEL6 in Fin

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread Andrey Loskutov
On Wednesday 08 June 2016 08:37 Benedikt Ritter wrote: > Hallo Andrey, > > Andrey Loskutov schrieb am Mi., 8. Juni 2016 um 09:36 Uhr: > > > Hi, > > > > I'm following the package rename and trying to fix compile issues with > > BCEL6 in FindBugs. > > > > Before 6.0 we had both StackMap and StackM

Re: [BCEL6] StackMapTable / StackMapTableEntry gone

2016-06-08 Thread Benedikt Ritter
Hallo Andrey, Andrey Loskutov schrieb am Mi., 8. Juni 2016 um 09:36 Uhr: > Hi, > > I'm following the package rename and trying to fix compile issues with > BCEL6 in FindBugs. > > Before 6.0 we had both StackMap and StackMapTable classes (with > StackMapEntry / StackMapTableEntry elements). > Thi