Re: Parent POM and automatic module name

2018-01-09 Thread sebb
On 9 January 2018 at 12:30, Stephen Colebourne wrote: > This seems a lot more effort than just adding something to the pom.xml > in the child project. > Stephen Agreed; it could be something as simple as a property define. Note that if it is a file, then it needs to be added to the source archiv

Re: Parent POM and automatic module name

2018-01-09 Thread Gilles
On Tue, 9 Jan 2018 12:30:19 +, Stephen Colebourne wrote: This seems a lot more effort than just adding something to the pom.xml in the child project. Yes, but is there a possibility that this "automatic name" addition should be be removed in the future (and replaced by ...)? If so, having

Re: Parent POM and automatic module name

2018-01-09 Thread Stephen Colebourne
This seems a lot more effort than just adding something to the pom.xml in the child project. Stephen On 9 January 2018 at 12:11, Gilles wrote: > Hi. > > My suggestion would be > "profile.java_automatic_module_name" > in the top directory. > > Gilles > > > On Mon, 8 Jan 2018 22:23:08 -0800, Chas

Re: Parent POM and automatic module name

2018-01-09 Thread Gilles
Hi. My suggestion would be "profile.java_automatic_module_name" in the top directory. Gilles On Mon, 8 Jan 2018 22:23:08 -0800, Chas Honton wrote: Profile triggers in src/profiles? Chas On Jan 8, 2018, at 4:27 PM, sebb wrote: On 8 January 2018 at 23:14, Jörg Schaible wrote: Am Mon, 0

Re: Parent POM and automatic module name

2018-01-08 Thread Chas Honton
Profile triggers in src/profiles? Chas > On Jan 8, 2018, at 4:27 PM, sebb wrote: > >> On 8 January 2018 at 23:14, Jörg Schaible wrote: >> Am Mon, 08 Jan 2018 00:48:08 + schrieb sebb: >> >>> On 8 January 2018 at 00:25, Jörg Schaible wrote: >> >> [snip] >> > The component poms I chec

Re: Parent POM and automatic module name

2018-01-08 Thread sebb
On 8 January 2018 at 23:14, Jörg Schaible wrote: > Am Mon, 08 Jan 2018 00:48:08 + schrieb sebb: > >> On 8 January 2018 at 00:25, Jörg Schaible wrote: > > [snip] > The component poms I checked all include a comment like "Temporary fix, remove this after this has implemented in parent

Re: Parent POM and automatic module name

2018-01-08 Thread Jörg Schaible
Am Mon, 08 Jan 2018 00:48:08 + schrieb sebb: > On 8 January 2018 at 00:25, Jörg Schaible wrote: [snip] >>> The component poms I checked all include a comment like "Temporary >>> fix, remove this after this has implemented in parent pom". As these >>> comments are not true anymore I will rem

Re: Parent POM and automatic module name

2018-01-07 Thread sebb
On 8 January 2018 at 00:25, Jörg Schaible wrote: > Am Sun, 07 Jan 2018 12:04:16 +0100 schrieb Pascal Schumacher: > >> Am 07.01.2018 um 11:10 schrieb Stefan Bodewig: >>> My memory (which is old and failing frequently) claims we didn't want >>> to put it into the parent as not all components can use

Re: Parent POM and automatic module name

2018-01-07 Thread Jörg Schaible
Am Sun, 07 Jan 2018 12:04:16 +0100 schrieb Pascal Schumacher: > Am 07.01.2018 um 11:10 schrieb Stefan Bodewig: >> My memory (which is old and failing frequently) claims we didn't want >> to put it into the parent as not all components can use automatic >> module names (net hasn't got a single pack

Re: Parent POM and automatic module name

2018-01-07 Thread sebb
Might be sensible to add a note to the parent pom to say why it does not have the feature. On 7 January 2018 at 11:04, Pascal Schumacher wrote: > Am 07.01.2018 um 11:10 schrieb Stefan Bodewig: >> >> My memory (which is old and failing frequently) claims we didn't want to >> put it into the parent

Re: Parent POM and automatic module name

2018-01-07 Thread Pascal Schumacher
Am 07.01.2018 um 11:10 schrieb Stefan Bodewig: My memory (which is old and failing frequently) claims we didn't want to put it into the parent as not all components can use automatic module names (net hasn't got a single package root IIRC) and so wewanted to leave it to the individual components.

Re: Parent POM and automatic module name

2018-01-07 Thread Stefan Bodewig
On 2018-01-07, Pascal Schumacher wrote: > Hello everybody, > just noticed that Parent POM 43 does not seem to set the automatic > module name in the jar manifest. > Did I miss something you did we just forget to add the required > maven-jar-plugin configuration? My memory (which is old and fail

Parent POM and automatic module name

2018-01-07 Thread Pascal Schumacher
Hello everybody, just noticed that Parent POM 43 does not seem to set the automatic module name in the jar manifest. Did I miss something you did we just forget to add the required maven-jar-plugin configuration? -Pascal --