Re: I just found a typo which exist in most of the commons projects.

On Tue, May 26, 2020 at 9:00 AM Xeno Amess wrote: > https://github.com/apache/commons-jcs/pull/11/files > https://github.com/apache/commons-validator/pull/23/files These two are merged. > > https://github.com/apache/maven-enforcer/pull/68/files I can't do anything about that one. Gary >

Re: I just found a typo which exist in most of the commons projects.

Glad to hear that. I knoe there must be a template but I just don't know where it be in. I tried to find the temple several hours ago but failed lol. Gary Gregory 于2020年5月26日周二 下午8:51写道： > Note that the template > > 'commons-build-plugin/src/main/resources/commons-xdoc-templates/contributing-md-

Re: I just found a typo which exist in most of the commons projects.

https://github.com/apache/commons-jcs/pull/11/files https://github.com/apache/commons-validator/pull/23/files https://github.com/apache/maven-enforcer/pull/68/files Gary Gregory 于2020年5月26日周二 下午8:51写道： > Note that the template > > 'commons-build-plugin/src/main/resources/commons-xdoc-templates/

Re: I just found a typo which exist in most of the commons projects.

Note that the template 'commons-build-plugin/src/main/resources/commons-xdoc-templates/contributing-md-template.md' is correct. Gary On Tue, May 26, 2020 at 8:48 AM Gary Gregory wrote: > I merged a bunch of PRs but I might have missed some in this typo area. > Please feel free to ping the list

Re: I just found a typo which exist in most of the commons projects.

I merged a bunch of PRs but I might have missed some in this typo area. Please feel free to ping the list if we've missed some. TY! Gary On Mon, May 25, 2020 at 1:36 PM Xeno Amess wrote: > Ah, I go and see quite some of the repos have already fixed this typo... > So I will try to fix this typo

Re: I just found a typo which exist in most of the commons projects.

Ah, I go and see quite some of the repos have already fixed this typo... So I will try to fix this typo in other repos. thx. Gary Gregory 于2020年5月26日周二 上午12:59写道： > Always worth fixing IMO :-) > > On Mon, May 25, 2020, 12:15 Xeno Amess wrote: > > > in every CONTRIBUTING.md > >

Re: I just found a typo which exist in most of the commons projects.

Always worth fixing IMO :-) On Mon, May 25, 2020, 12:15 Xeno Amess wrote: > in every CONTRIBUTING.md > (for > example lang3 but actually almost every repo) > > ... > If you're planning to implement a new feature it makes sense

I just found a typo which exist in most of the commons projects.

in every CONTRIBUTING.md (for example lang3 but actually almost every repo) ... If you're planning to implement a new feature it makes sense to discuss *you're* changes on the [dev list] ... should be ... If you're planning