Re: Fwd: Build failed in Jenkins: commons-dbcp #237

2018-06-19 Thread Gary Gregory
OK, I think I'll roll an RC for Commons Pool soon, which I've been wanting to do anyway. Gary On Tue, Jun 19, 2018 at 9:16 AM Mark Thomas wrote: > On 19/06/18 16:03, Gary Gregory wrote: > > What is odd is that you've added generics to places where there are none. > > Ah. Found it. My local DBCP

Re: Fwd: Build failed in Jenkins: commons-dbcp #237

2018-06-19 Thread Mark Thomas
On 19/06/18 16:03, Gary Gregory wrote: > What is odd is that you've added generics to places where there are none. Ah. Found it. My local DBCP workspace depends on the local Pool workspace rather than the 2.5.0 release. I was picking up genrics changes that will be in the next pool release and ada

Re: Fwd: Build failed in Jenkins: commons-dbcp #237

2018-06-19 Thread Gary Gregory
What is odd is that you've added generics to places where there are none. Gary On Tue, Jun 19, 2018 at 8:42 AM Mark Thomas wrote: > On 19 June 2018 15:23:52 BST, Gary Gregory wrote: > >Mark, > > > >I'm not sure what compiler you are using, but these changes break the > >build > >in Jenkins, in

Re: Fwd: Build failed in Jenkins: commons-dbcp #237

2018-06-19 Thread Mark Thomas
On 19 June 2018 15:23:52 BST, Gary Gregory wrote: >Mark, > >I'm not sure what compiler you are using, but these changes break the >build >in Jenkins, in my local Eclipse workspace, and with Maven and Orcale >Java >8. Please fix: Odd. I'm using Eclipse and Java 8 and was seeing generics warnings b

Fwd: Build failed in Jenkins: commons-dbcp #237

2018-06-19 Thread Gary Gregory
Mark, I'm not sure what compiler you are using, but these changes break the build in Jenkins, in my local Eclipse workspace, and with Maven and Orcale Java 8. Please fix: [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /C:/vcs/git/apache/co