Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-18 Thread Paul Benedict
Probably because both compile down into max(Object[]). But when I read Joshua Bloch's Effective Java, he recommends doing something like this: max(double, double) max(double, double, double) max(double, double, double, double...) That would be nice. The behind-the-sceneds Object[] creation only h

Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-17 Thread Henri Yandell
On Mon, Nov 16, 2009 at 11:48 PM, Henri Yandell wrote: > On Mon, Nov 16, 2009 at 10:16 AM, Paul Benedict wrote: >> * Is there any benefit to making NumberUtils.min/max accept a variable >> arguments over a single array? > > Seems good. >From LANG-396: NumberUtils.min, NumberUtils.max varargs ru

Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-17 Thread Paul Benedict
>> * Validate throws IAE on every failure -- including null arguments. >> Because NPE is not thrown, it will make this class less and less >> palatable in the future since that is the favored approach nowadays -- >> and implemented by the JDK and Google. One solution is to expose a >> pluggable fac

Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-17 Thread Henri Yandell
On Mon, Nov 16, 2009 at 11:54 PM, Henri Yandell wrote: > On Mon, Nov 16, 2009 at 11:48 PM, Henri Yandell wrote: >> kill EscapeUtils/UnescapeUtils and make StringEscapeUtils undeprecated >> and the intended front door. > > I'll do that. Delete EscapeUtils and UnescapeUtils; replace > StringEscape

Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-16 Thread Henri Yandell
On Mon, Nov 16, 2009 at 11:48 PM, Henri Yandell wrote: > On Mon, Nov 16, 2009 at 10:16 AM, Paul Benedict wrote: > > Effectively, I think code on top of java.math is a fine fit for Lang, > whereas Commons Math is a wholly different bigger beastie. > >> * System is missing IS_JAVA_1_7 constant > >

Re: Comments on Commons Lang 3.0-SNAPSHOT

2009-11-16 Thread Henri Yandell
On Mon, Nov 16, 2009 at 10:16 AM, Paul Benedict wrote: > * I think org.apache.commons.lang.math should be refactored and removed: >  * Fraction has nothing to do with this library and belongs in > Commons Math. I see it so closely align to higher Math functions and > not the JDK. Dropping Fractio

Comments on Commons Lang 3.0-SNAPSHOT

2009-11-16 Thread Paul Benedict
* I think org.apache.commons.lang.math should be refactored and removed: * Fraction has nothing to do with this library and belongs in Commons Math. I see it so closely align to higher Math functions and not the JDK. * IEEE754rUtils should move to the root package * NumberUtils should move to