Re: Fwd: Circular Reference on WeakHashMap

2007-08-07 Thread Clebert Suconic
The insomnia got me today... Couldn't sleep! :-) https://issues.apache.org/jira/browse/BEANUTILS-291 There is a proposed fix on the JIRA.. it works! Nice.. isn't? The idea is to use a WeakHashMap on the Property also. I don't think this would cause performance issues, since WeakhashMap woul

Re: Fwd: Circular Reference on WeakHashMap

2007-08-07 Thread Clebert Suconic
;[EMAIL PROTECTED]> Date: Aug 7, 2007 2:36 AM Subject: Re: Circular Reference on WeakHashMap To: Clebert Suconic <[EMAIL PROTECTED]> On 8/7/07, Clebert Suconic <[EMAIL PROTECTED]> wrote: The solution seems simpler than I thought though... After looking at the report again... [EMA

Re: Fwd: Circular Reference on WeakHashMap

2007-08-07 Thread Clebert Suconic
> should the second sample on the wiki page not contain > SoftReference reference = new SoftReference(x); instead of > WeakReference reference = new WeakReference(x); ? Yep! :-) Just fixed it. Thanks! Clebert - To unsubscrib

Re: Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Heinz Drews
lass reference - for example in > > IntegerConverter it would just have: > > > > protected Class getDefaultType() { > > return Integer.class; > > } > > > > Niall > > > >> Niall Pemberton wrote: > >>> Woops, should

Re: Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Niall Pemberton
stance each AbstractConverter > > implementation only ever returns the same value - so I think its > > simpler to remove the class reference - for example in > > IntegerConverter it would just have: > > > > protected Class getDefaultType() { > > return I

Re: Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Clebert Suconic
ltType() { return Integer.class; } Niall Niall Pemberton wrote: Woops, should have gone to dev@ list -- Forwarded message -- From: Niall Pemberton <[EMAIL PROTECTED]> Date: Aug 7, 2007 2:36 AM Subject: Re: Circular Reference on WeakHashMap To: Clebert Sucon

Re: Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Niall Pemberton
erter it would just have: protected Class getDefaultType() { return Integer.class; } Niall > Niall Pemberton wrote: > > Woops, should have gone to dev@ list > > > > -- Forwarded message ------ > > From: Niall Pemberton <[EMAIL PROTECTED]>

Re: Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Clebert Suconic
<[EMAIL PROTECTED]> Date: Aug 7, 2007 2:36 AM Subject: Re: Circular Reference on WeakHashMap To: Clebert Suconic <[EMAIL PROTECTED]> On 8/7/07, Clebert Suconic <[EMAIL PROTECTED]> wrote: The solution seems simpler than I thought though... After looking at the report again..

Fwd: Circular Reference on WeakHashMap

2007-08-06 Thread Niall Pemberton
Woops, should have gone to dev@ list -- Forwarded message -- From: Niall Pemberton <[EMAIL PROTECTED]> Date: Aug 7, 2007 2:36 AM Subject: Re: Circular Reference on WeakHashMap To: Clebert Suconic <[EMAIL PROTECTED]> On 8/7/07, Clebert Suconic <[EMAIL PROTECTED

Re: Circular Reference on WeakHashMap

2007-08-06 Thread Clebert Suconic
The solution seems simpler than I thought though... After looking at the report again... [EMAIL PROTECTED] ClassConverter probably has a reference to Class... I thought this was a reflection object. It should be WeakReference. And... inspect your code for any other reflection usages. Nia

Re: Circular Reference on WeakHashMap

2007-08-06 Thread Clebert Suconic
>> if you don't believe me, do some >> testing with simple stuff before discussing this and come back to me >> only after that) > > OK I will. What I meant about with "no discussion" is.. usually people tend to disagree a circular REference on a WeakHashMap, SomeObject> would generate redeploy

Re: Circular Reference on WeakHashMap

2007-08-06 Thread Niall Pemberton
On 8/6/07, Clebert Suconic <[EMAIL PROTECTED]> wrote: > I have been investigating WeakHashMaps on BeanUtils 1.8 as part of a > investigation on this: > > http://jira.jboss.com/jira/browse/JBAS-2299 Thanks for getting back to us so quickly. > (Which is not actually an issue with JBAS, but an issue

Circular Reference on WeakHashMap

2007-08-06 Thread Clebert Suconic
I have been investigating WeakHashMaps on BeanUtils 1.8 as part of a investigation on this: http://jira.jboss.com/jira/browse/JBAS-2299 (Which is not actually an issue with JBAS, but an issue when using BeanUtils as part of the classPath). There is a circular reference on the WeakHashMap, T