Re: Bugs in Apache commons collections, version 4.0

2014-04-12 Thread Dipanjan Laha
On Sat, Apr 12, 2014 at 3:18 PM, Thomas Neidhart wrote: > On 04/12/2014 08:41 AM, Dipanjan Laha wrote: > > On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart > > wrote: > > > >> On 04/11/2014 05:52 AM, Dipanjan Laha wrote: > >>> Hi, > >>> > >>> The only issue here is then Collection's equals impleme

Re: Bugs in Apache commons collections, version 4.0

2014-04-12 Thread Thomas Neidhart
On 04/12/2014 08:41 AM, Dipanjan Laha wrote: > On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart > wrote: > >> On 04/11/2014 05:52 AM, Dipanjan Laha wrote: >>> Hi, >>> >>> The only issue here is then Collection's equals implementation would need >>> to check individually whether the Collection also

Re: Bugs in Apache commons collections, version 4.0

2014-04-11 Thread Dipanjan Laha
On Sat, Apr 12, 2014 at 1:04 AM, Thomas Neidhart wrote: > On 04/11/2014 05:52 AM, Dipanjan Laha wrote: > > Hi, > > > > The only issue here is then Collection's equals implementation would need > > to check individually whether the Collection also implements List, Set or > > Bag (more such interfac

Re: Bugs in Apache commons collections, version 4.0

2014-04-11 Thread Thomas Neidhart
On 04/11/2014 05:52 AM, Dipanjan Laha wrote: > Hi, > > The only issue here is then Collection's equals implementation would need > to check individually whether the Collection also implements List, Set or > Bag (more such interfaces may come up in the future). This is kind of a > hard coupling bet

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
Hi, The only issue here is then Collection's equals implementation would need to check individually whether the Collection also implements List, Set or Bag (more such interfaces may come up in the future). This is kind of a hard coupling between Collections equals and other implementations which w

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Julien Aymé
Hi, As specified by Collection#equals(Object) javadoc ( http://docs.oracle.com/javase/7/docs/api/java/util/Collection.html#equals(java.lang.Object) ), equals must be symmetric. That's why Collection.equals(List) must return false, as well as Collection.equals(Set), while Collection.equals(Collecti

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
Hello, I checked the equals symmetry mismatch issue in https://issues.apache.org/jira/browse/COLLECTIONS-512. I haven't checked the hascode mismatch or any other issue yet. The test in BugReport1_1.java initializes AbstractIterableGetMapDecorator which is meant to be abstract but is not. So imho

Bugs in Apache commons collections, version 4.0

2014-04-09 Thread Cyrille Artho
Dear developers, We have found several issues in Apache commons collections, version 4.0. We have grouped similar issues into one bug report (as the root cause may be in one place or the same problem in a few isolated places). Here are the direct links; please look at the bug tracker for details.