Re: Bugfix in commons-compress

2009-02-12 Thread Stefan Bodewig
On 2009-02-11, Ingo Rockel wrote: > I fixed the second issue and reported it here: > https://issues.apache.org/jira/browse/SANDBOX-286 > Again, is this sufficient? absolutely, yes. Thanks. A bit of history. The BZip classes used to be part of Ant (well, they still are) and for reasons I can

Re: Bugfix in commons-compress

2009-02-11 Thread Christian Grobmeier
> I put everything concerning the magic number issue into this jira issue: > > https://issues.apache.org/jira/browse/SANDBOX-285 > > Is this sufficient? > > I am still investigating the second issue, reading from the stream > directly works fine, but it fails if it is wrapped into a InputStreamRead

Re: Bugfix in commons-compress

2009-02-11 Thread Ingo Rockel
I fixed the second issue and reported it here: https://issues.apache.org/jira/browse/SANDBOX-286 Again, is this sufficient? Kind regards, Ingo Ingo Rockel schrieb: > Torsten Curdt wrote: >>> Is there any interest in these patches? >> Please - bring them on and file them in jira ! :) >>

Re: Bugfix in commons-compress

2009-02-11 Thread Ingo Rockel
Torsten Curdt wrote: >> Is there any interest in these patches? > > Please - bring them on and file them in jira ! :) > I put everything concerning the magic number issue into this jira issue: https://issues.apache.org/jira/browse/SANDBOX-285 Is this sufficient? I am still investigating the se

Re: Bugfix in commons-compress

2009-02-11 Thread Torsten Curdt
> Is there any interest in these patches? Please - bring them on and file them in jira ! :) > Or is the commons-compress > project dead? No, it's not ... it just got it's make-over and more people seem to be interested in it :) > I hope this list is the right place to address this issue to. De

Bugfix in commons-compress

2009-02-11 Thread Ingo Rockel
Hi, I just fixed a bug with a wrong magic number for bzip2 files in commons-compress, it checked for 'h' as first byte but it has to be 'BZh' in the first three bytes according to http://en.wikipedia.org/wiki/Bzip2 which works fine for bzip2-compressed files (the check for 'h' did not). I'm curre