Re: [validator] Inconsistent behavior in UrlValidator

2015-09-28 Thread Benedikt Ritter
2015-09-28 18:48 GMT+02:00 sebb : > The java.net.InetAddress class has a method: isLoopbackAddress() > > We should use whatever validation is provided by the JDK, not try and > invent our own > +1 > > On 27 September 2015 at 18:21, Kristian Rosenvold > wrote: > > Yeah, as long as the full rang

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-28 Thread sebb
The java.net.InetAddress class has a method: isLoopbackAddress() We should use whatever validation is provided by the JDK, not try and invent our own On 27 September 2015 at 18:21, Kristian Rosenvold wrote: > Yeah, as long as the full range is validated it should be fine. > > K > > > 2015-09-27

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-27 Thread Kristian Rosenvold
Yeah, as long as the full range is validated it should be fine. K 2015-09-27 19:17 GMT+02:00 Adrian Crum : > The address range 127.0.0.0 to 127.255.255.255 is reserved for loopback > testing. It seems pretty straightforward to me. > > Adrian Crum > Sandglass Software > www.sandglass-software.com

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-27 Thread Adrian Crum
The address range 127.0.0.0 to 127.255.255.255 is reserved for loopback testing. It seems pretty straightforward to me. Adrian Crum Sandglass Software www.sandglass-software.com On 9/27/2015 8:07 AM, Kristian Rosenvold wrote: 127.0.0.1 is not always the address for localhost. This is a can of

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-27 Thread Kristian Rosenvold
127.0.0.1 is not always the address for localhost. This is a can of worms big enough to drive a medium-sized container ship into Kristian 27. sep. 2015 4.13 p.m. skrev "Benedikt Ritter" : > Hm... since localhost is usually only an alias for 127.0.0.1 it doesn't > really make sense to allow one bu

Re: [validator] Inconsistent behavior in UrlValidator

2015-09-27 Thread Benedikt Ritter
Hm... since localhost is usually only an alias for 127.0.0.1 it doesn't really make sense to allow one but not the other. 2015-09-25 23:18 GMT+02:00 Adrian Crum : > I was just looking at the UrlValidator test and I noticed that localhost > is allowed in the URL if the ALLOW_LOCAL_URLS flag is set

[validator] Inconsistent behavior in UrlValidator

2015-09-25 Thread Adrian Crum
I was just looking at the UrlValidator test and I noticed that localhost is allowed in the URL if the ALLOW_LOCAL_URLS flag is set, and it is not allowed if the ALLOW_LOCAL_URLS flag is not set. If the ALLOW_LOCAL_URLS is not set, a loopback IP address (127.0.0.1) URL will validate. It seems t