RE: [sanselan] Question about Java coding style for sanselan project

2011-09-30 Thread Gary Lucas
From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Friday, September 30, 2011 2:19 PM To: Commons Developers List Subject: Re: [sanselan] Question about Java coding style for sanselan project Hello Gary(!): The project POM defines: 1.4 1.4 Java 1.4 is the current requirement. Usin

Re: [sanselan] Question about Java coding style for sanselan project

2011-09-30 Thread Gary Gregory
Hello Gary(!): The project POM defines: 1.4 1.4 Java 1.4 is the current requirement. Using generics would mean bumping the requirements of the project to Java 5. I do not know enough about the project to know if this is acceptable. Seems OK to me though. I am not sure who on this ML

[sanselan] Question about Java coding style for sanselan project

2011-09-30 Thread Gary Lucas
I am working on a couple of patches for sanselan. These involve about a couple of dozen files. I had two questions about coding style: First question: Is it okay to use generics for collections? These are a Java 1.5 element and I've noticed a couple of comments on the project page mentioning