Re: [sanselan] ColorConversionsTest failure

2012-01-04 Thread Emmanuel Bourg
Le 03/01/2012 22:06, Matt Benson a écrit : Ping, any of the sanselan/imaging guys want to tackle this? I started looking at the CMYK to RGB conversion but it seems there are different formulas floating around on Internet. I have yet to find an authoritative source on this topic. Emmanuel Bo

Re: [sanselan] ColorConversionsTest failure

2012-01-03 Thread Matt Benson
Ping, any of the sanselan/imaging guys want to tackle this? Matt On Wed, Dec 21, 2011 at 6:55 AM, Emmanuel Bourg wrote: > Le 21/12/2011 13:49, Gary Gregory a écrit : > > >> Sorry, that kind of feels like passing the buck here ;) I wish I could >> recall a French equivalent! :) > > > Yeah that's

Re: [sanselan] ColorConversionsTest failure

2011-12-21 Thread Emmanuel Bourg
Le 21/12/2011 13:49, Gary Gregory a écrit : Sorry, that kind of feels like passing the buck here ;) I wish I could recall a French equivalent! :) Yeah that's called "Management" ;) Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature

Re: [sanselan] ColorConversionsTest failure

2011-12-21 Thread Emmanuel Bourg
Le 21/12/2011 13:36, Gary Gregory a écrit : If you add a unit test, you should make sure it works IMO. Or, you should @Ignore it. Sorry I'm not keen to put the dust under the carpet. If there is an issue it should be visible. I let it to someone more knowledgeable on color spaces to review i

Re: [sanselan] ColorConversionsTest failure

2011-12-21 Thread Gary Gregory
On Wed, Dec 21, 2011 at 7:34 AM, Emmanuel Bourg wrote: > I do, the failure appeared after I moved the tests previously in > ColorConversions into a proper JUnit test case. I don't think I broke the > code, so I assume the issue was already there. > If you add a unit test, you should make sure it

Re: [sanselan] ColorConversionsTest failure

2011-12-21 Thread Emmanuel Bourg
I do, the failure appeared after I moved the tests previously in ColorConversions into a proper JUnit test case. I don't think I broke the code, so I assume the issue was already there. Emmanuel Bourg Le 21/12/2011 13:29, Gary Gregory a écrit : Does anyone else see this: junit.framework.Com