Re: [parent] japicmp problems

2018-08-12 Thread Stefan Bodewig
On 2018-08-12, Gary Gregory wrote: > Whatever you do, please document in the parent what does what and how a > component should enable and disable the report. http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1837064&r2=1837920 Actually, you don't have to do anything. I

Re: [parent] japicmp problems

2018-08-12 Thread Remko Popma
Has anyone communicated these issues (whatever they are) back to the japicmp author(s)? Or are they unaware? Forking the project in Commons means you’ve given up on the maintainers. It also likely means a significant time investment. Why not spend a fraction of that time to submit a bug fix to

Re: [parent] japicmp problems

2018-08-12 Thread Rob Tompkins
> On Aug 12, 2018, at 11:16 AM, Stefan Bodewig wrote: > >> On 2018-08-12, Rob Tompkins wrote: >> >> I agree with this statement generally. That said, this doesn’t >> surprise me that I made this error because japicmp is minimally >> cumbersome to work with. > > I didn't mean to blame you, so

Re: [parent] japicmp problems

2018-08-12 Thread Gary Gregory
Whatever you do, please document in the parent what does what and how a component should enable and disable the report. Thanks! Gary On Sun, Aug 12, 2018 at 9:16 AM Stefan Bodewig wrote: > On 2018-08-12, Rob Tompkins wrote: > > > I agree with this statement generally. That said, this doesn’t > >

Re: [parent] japicmp problems

2018-08-12 Thread Stefan Bodewig
On 2018-08-12, Rob Tompkins wrote: > I agree with this statement generally. That said, this doesn’t > surprise me that I made this error because japicmp is minimally > cumbersome to work with. I didn't mean to blame you, sorry if you received it that way. Fully agreed that japicmp is a pain, but

Re: [parent] japicmp problems

2018-08-12 Thread Gary Gregory
+1 using japicmp is maddening due to bugs. It feels unsupported... fork it and fix it within Commons? Gary On Sun, Aug 12, 2018, 07:08 Rob Tompkins wrote: > I agree with this statement generally. That said, this doesn’t surprise me > that I made this error because japicmp is minimally cumbersom

Re: [parent] japicmp problems

2018-08-12 Thread Rob Tompkins
I agree with this statement generally. That said, this doesn’t surprise me that I made this error because japicmp is minimally cumbersome to work with. It feels very unfinished/unpolished. Next time I get into [parent], I’ll try to go up and submit more polishing work to the japicmp codebase.

[parent] japicmp problems

2018-08-12 Thread Stefan Bodewig
Hi while building the site for Compress the japicmp report was empty, taking a closer look there is a little warning that says "skipping report because skip is set to true" which in fact it is. http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?r1=1832506&r2=185 added th