Re: [numbers] Making Quaternion a VALJO

2018-11-30 Thread Matt Juntunen
ometry/euclidean/threed/QuaternionRotation.java> Apache Commons Geometry. Contribute to darkma773r/commons-geometry development by creating an account on GitHub. github.com From: Gilles Sent: Friday, November 30, 2018 9:37 AM To: dev@commons.apache.org Subject: Re: [

Re: [numbers] Making Quaternion a VALJO

2018-11-30 Thread Gilles
On Fri, 30 Nov 2018 14:22:45 +, Steve Bosman wrote: > and I have also emailed an ICLA. Not received/acknowledged yet. I am now listed on the "Persons with signed CLAs but who are not (yet) committers." page. Welcome! > I think two convenience divide methods performing qr^{-1} and r

Re: [numbers] Making Quaternion a VALJO

2018-11-30 Thread Steve Bosman
> > and I have also emailed an ICLA. > Not received/acknowledged yet. I am now listed on the "Persons with signed CLAs but who are not (yet) committers." page. > > I think two convenience divide methods performing qr^{-1} and r^{-1}q > > for q > > and r would be useful, but I couldn't think of n

Re: [numbers] Making Quaternion a VALJO

2018-11-29 Thread Gilles
Hello. On Thu, 29 Nov 2018 08:43:22 +, Steve Bosman wrote: Hi I had a look last night at making Quaternion a VALJO. I've done the following * changed the constructors to private and added equivalent of methods. * added a parse method * altered equals so that (like Complex) it uses Doubl

[numbers] Making Quaternion a VALJO

2018-11-29 Thread Steve Bosman
Hi I had a look last night at making Quaternion a VALJO. I've done the following * changed the constructors to private and added equivalent of methods. * added a parse method * altered equals so that (like Complex) it uses Double.equals - gets round an edge case where Quaternions with the equiva