Re: [net] 2.0 Release Ready For Review

2008-09-23 Thread James Carman
I'd split it into multiple modules. On Tue, Sep 23, 2008 at 2:54 PM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Tue, Sep 23, 2008 at 5:12 PM, Daniel F. Savarese <[EMAIL PROTECTED]> wrote: >> I don't think the examples should be pre-compiled at all. They are >> source code examples that dem

Re: [net] 2.0 Release Ready For Review

2008-09-23 Thread Niklas Gustavsson
On Tue, Sep 23, 2008 at 5:12 PM, Daniel F. Savarese <[EMAIL PROTECTED]> wrote: > I don't think the examples should be pre-compiled at all. They are > source code examples that demonstrate how to use the API. Unless > something has changed recently, they are not intended as fully > functional prog

Re: [net] 2.0 Release Ready For Review

2008-09-23 Thread sebb
On 23/09/2008, Daniel F. Savarese <[EMAIL PROTECTED]> wrote: > > In message <[EMAIL PROTECTED]>, sebb > writes: > > >On 22/09/2008, Oberhuber, Martin <[EMAIL PROTECTED]> wrote: > > >> I'd rather put the examples into a separate Jar of their own, > >> but again I'm not sure what other Commons p

Re: [net] 2.0 Release Ready For Review

2008-09-22 Thread sebb
ailto:[EMAIL PROTECTED] > > Sent: Thursday, September 18, 2008 4:05 PM > > To: Commons Developers List > > Subject: Re: [net] 2.0 Release Ready For Review > > > > Also, the binary jar contains an examples/ directory, but it contains > > only the class files. &g

RE: [net] 2.0 Release Ready For Review

2008-09-22 Thread Oberhuber, Martin
; To: Commons Developers List > Subject: Re: [net] 2.0 Release Ready For Review > > Also, the binary jar contains an examples/ directory, but it contains > only the class files. > > Surely it should contain the source files instead?

RE: [net] 2.0 Release Ready For Review

2008-09-22 Thread Oberhuber, Martin
PROTECTED] > > Sent: Thursday, September 18, 2008 8:53 AM > > To: Jakarta Commons Developers List > > Subject: [net] 2.0 Release Ready For Review > > > > Hi all > > > > The RC for net-2.0 is available for review at: > > > > http://people.

RE: [net] 2.0 Release Ready For Review

2008-09-22 Thread Oberhuber, Martin
er http://www.eclipse.org/dsdp/tm > -Original Message- > From: Rory Winston [mailto:[EMAIL PROTECTED] > Sent: Thursday, September 18, 2008 8:53 AM > To: Jakarta Commons Developers List > Subject: [net] 2.0 Release Ready For Review > > Hi all > > The

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread Rory Winston
https://svn.apache.org/repos/asf/commons/proper/net/tags/NET_2_0 James Carman wrote: What tag was this built from in SVN? On Thu, Sep 18, 2008 at 3:32 AM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: On Thu, Sep 18, 2008 at 8:52 AM, Rory Winston <[EMAIL PROTECTED]> wrote: The RC for n

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread James Carman
I didn't like the examples stuff being in the "examples" package, but I don't guess that's really a violation or anything. I'd rather see it in o.a.c.net.examples. On Thu, Sep 18, 2008 at 10:04 AM, sebb <[EMAIL PROTECTED]> wrote: > Also, the binary jar contains an examples/ directory, but it cont

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread sebb
Also, the binary jar contains an examples/ directory, but it contains only the class files. Surely it should contain the source files instead? On 18/09/2008, sebb <[EMAIL PROTECTED]> wrote: > The jar files in commons-net-2.0.0-bin.tar are rather inconsistent as > regards LICENSE and NOTICE files

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread sebb
The jar files in commons-net-2.0.0-bin.tar are rather inconsistent as regards LICENSE and NOTICE files commons-net-2.0.0.jar has both in META-INF directory commons-net-2.0.0-tests.jar does not have either commons-net-ftp-2.0.0.jar has both in top-level directory (and it has a META-INF dir) The na

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread James Carman
What tag was this built from in SVN? On Thu, Sep 18, 2008 at 3:32 AM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Thu, Sep 18, 2008 at 8:52 AM, Rory Winston <[EMAIL PROTECTED]> wrote: >> The RC for net-2.0 is available for review at: >> >> http://people.apache.org/~rwinston/commons-net-2.0 >

Re: [net] 2.0 Release Ready For Review

2008-09-18 Thread Niklas Gustavsson
On Thu, Sep 18, 2008 at 8:52 AM, Rory Winston <[EMAIL PROTECTED]> wrote: > The RC for net-2.0 is available for review at: > > http://people.apache.org/~rwinston/commons-net-2.0 > > Changes are here: > > http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html#a2.0 > > Can someone

[net] 2.0 Release Ready For Review

2008-09-17 Thread Rory Winston
Hi all The RC for net-2.0 is available for review at: http://people.apache.org/~rwinston/commons-net-2.0 Changes are here: http://people.apache.org/~rwinston/commons-net-2.0/site/changes-report.html#a2.0 Can someone take a look at the RC and see if there are any issues? If not, I'll set up a