[ANNOUNCE] Apache Commons Net 3.11.1

2024-06-10 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.11.1. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, and Whois. This is

[RESULT][VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-10 Thread Gary Gregory
indbugs errors > 1) Introduce backward compatibility tests > > Phil > > > > > On Fri, Jun 7, 2024 at 5:40 AM Gary Gregory wrote: > > > We have fixed a few bugs and added enhancements since Apache Commons > > Net 3.11.0 was released, so I would like to release A

Re: [VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-10 Thread Phil Steitz
and set up build to fail on findbugs errors 1) Introduce backward compatibility tests Phil On Fri, Jun 7, 2024 at 5:40 AM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > Net 3.11.0 was released, so I would like to release Apache Commons Net

Re: [VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-10 Thread Henri Biestro
[ +1 ] LGTM: site looks good, javadoc ok, reports ok Build using: mvn clean install site -s ~/.m2/commons-settings.xml On: mvn -version Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /Users/hbiestro/Java/apache-maven-3.8.6 Java version: 1.8.0_352, vendor: Azul Systems

Re: [VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-09 Thread Gary D. Gregory
hil Steitz wrote: > There are a bunch of findbugs errors reported. Is this expected? > > Phil > > On Fri, Jun 7, 2024 at 5:40 AM Gary Gregory wrote: > > > We have fixed a few bugs and added enhancements since Apache Commons > > Net 3.11.0 was released, so I

Re: [VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-09 Thread Phil Steitz
There are a bunch of findbugs errors reported. Is this expected? Phil On Fri, Jun 7, 2024 at 5:40 AM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > Net 3.11.0 was released, so I would like to release Apache Commons Net > 3.11.1. > >

Re: [VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-09 Thread Gary Gregory
My +1 Gary On Fri, Jun 7, 2024, 8:39 AM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache Commons > Net 3.11.0 was released, so I would like to release Apache Commons Net > 3.11.1. > > Apache Commons Net 3.11.1 RC1 is available for review he

[VOTE] Release Apache Commons Net 3.11.1 based on RC1

2024-06-07 Thread Gary Gregory
We have fixed a few bugs and added enhancements since Apache Commons Net 3.11.0 was released, so I would like to release Apache Commons Net 3.11.1. Apache Commons Net 3.11.1 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.11.1-RC1 (svn revision 69595

[ANNOUNCE] Apache Commons Net 3.11.0

2024-05-31 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.11.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, and Whois

[RESULT][VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-31 Thread Gary Gregory
e have fixed a few bugs and added enhancements since Apache Commons > > Net 3.10.0 was released, so I would like to release Apache Commons Net > > 3.11.0. > > > > Apache Commons Net 3.11.0 RC1 is available for review here: > >https://dist.apache.org/repo

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-30 Thread Rob Tompkins
+1 > On May 28, 2024, at 8:09 PM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons > Net 3.10.0 was released, so I would like to release Apache Commons Net > 3.11.0. > > Apache Commons Net 3.11.0 RC1 is available for re

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-29 Thread Gary Gregory
My +1 Gary On Wed, May 29, 2024 at 4:35 AM Henri Biestro wrote: > > [ +1 ] LGTM > > Site & Javadoc look good, changes & JIRA report clean (nice!), nit: Jacoco > report missing some classes > > Built using: > mvn clean install site -Pjacoco -s ~/.m2/commons-settings.xml > On: > mvn -version > Ap

Re: [VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-29 Thread Henri Biestro
[ +1 ] LGTM Site & Javadoc look good, changes & JIRA report clean (nice!), nit: Jacoco report missing some classes Built using: mvn clean install site -Pjacoco -s ~/.m2/commons-settings.xml On: mvn -version Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: /Users/hbiestr

[VOTE] Release Apache Commons Net 3.11.0 based on RC1

2024-05-28 Thread Gary Gregory
We have fixed a few bugs and added enhancements since Apache Commons Net 3.10.0 was released, so I would like to release Apache Commons Net 3.11.0. Apache Commons Net 3.11.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.11.0-RC1 (svn revision 69435

Re: [Net] JUnit 5 migration discussion

2024-03-04 Thread Elric V
Following Rob's suggestion, I migrated FTPSClientTest from @Parameterized to @Nested The result so far can be found here: https://github.com/apache/commons-net/pull/227/commits/b14ee39cca486bda106758a48d31c91ad52d0d83 Basically the test methods were moved from FTPSClientTest.java [

Re: [Net] JUnit 5 migration discussion

2024-03-01 Thread Elric V
On 01/03/2024 16:53, Rob Spoor wrote: You can turn the current parameterized test into an abstract base class; you can even nest it in another class. Then for each set of parameters you use an @Nested sub class that fills in the parameters in the call to its super constructor. Thanks Rob & Al

Re: [Net] JUnit 5 migration discussion

2024-03-01 Thread Rob Spoor
FS. This one is challenging due to some similar JUnit 3 and 4 heritage issues. It is possible that between Net and VFS, what we need are custom JUnit extensions. I had started a Commons Testing repository a long time ago but never got far with adding what at the time were JUnit 4 rules. I too find some

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Alex Herbert
ome similar JUnit 3 and 4 heritage issues. > > It is possible that between Net and VFS, what we need are custom JUnit > extensions. I had started a Commons Testing repository a long time ago but > never got far with adding what at the time were JUnit 4 rules. > > I too find some

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread sebb
for digging into this Eric. > > > > Another component to consider for JUnit 5 migration is Commons VFS. This > > one is challenging due to some similar JUnit 3 and 4 heritage issues. > > > > It is possible that between Net and VFS, what we need are custom JUnit > > extensions.

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Gary Gregory
t is possible that between Net and VFS, what we need are custom JUnit > extensions. I had started a Commons Testing repository a long time ago but > never got far with adding what at the time were JUnit 4 rules. > > I too find some of the JUnit 5 changes baffling but that's what we g

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Gary Gregory
Thank you for digging into this Eric. Another component to consider for JUnit 5 migration is Commons VFS. This one is challenging due to some similar JUnit 3 and 4 heritage issues. It is possible that between Net and VFS, what we need are custom JUnit extensions. I had started a Commons Testing

[Net] JUnit 5 migration discussion

2024-02-29 Thread Elric V
Hi folks, I recently made some changes to commons-cli to move it from JUnit 4 to JUnit 5. This was mostly straightforward, and I think it went pretty well. Currently looking into doing the same for commons-net, but there are a couple of tricky tests that probably require some up front

Re: (commons-net) branch master updated: Add Javadoc @return comments

2024-02-13 Thread Gary Gregory
:24 2024 + > > Add Javadoc @return comments > --- > src/main/java/org/apache/commons/net/ftp/FTPSClient.java | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/main/java/org/apache/commons/net/ftp/FTPSClient.java > b/src/main/java/org/apache/commons/net/ftp/

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-13 Thread sebb
have the correct number of CRLFs only if > the conditional is true. > > So I think the line > > output.write(CRLF); > > should be moved into the conditional, rather than being added to the > conditional, as that would result in an extra CRLF. > > i.e. > > https:/

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread sebb
F); should be moved into the conditional, rather than being added to the conditional, as that would result in an extra CRLF. i.e. https://github.com/apache/commons-net/pull/217 > On Mon, Feb 12, 2024 at 10:15 AM Емельянов Юрий Владимирович > wrote: > > > > see FTPHTTPClient.t

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Elliotte Rusty Harold
Be careful with this one. I don't have full context, but this looks likely to be a real bug on some code paths and perhaps not a bug on others. We'll need to make sure that the patch for the broken code path doesn't break a currently working path. Specifically I'm worried about where \r\n might and

Re: [commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Gary Gregory
Hi, Thank you for your email. I can't validate this without a test. The best path forward is for you to provide a PR in GitHub. TY! Gary On Mon, Feb 12, 2024, 10:15 AM Емельянов Юрий Владимирович wrote: > see FTPHTTPClient.tunnelHandshake > > current code is: > > if (proxyUsername !=

[commons-net] issue: FTP other HTTP with Proxy-Authorization fail

2024-02-12 Thread Емельянов Юрий Владимирович
see FTPHTTPClient.tunnelHandshake current code is:     if (proxyUsername != null && proxyPassword != null) {     final String auth = proxyUsername + ":" + proxyPassword;     final String header = "Proxy-Authorization: Basic " + Base64.getEncoder().encodeToString(auth.getByte

Re: [Net] Mode Z for FTP

2024-02-08 Thread Gary Gregory
Hello Georg, The best way forward to provide a PR on github. Make sure you provide enough tests to cover all the new code. You can build the site and check the JaCoCo report to do so. TY! Gary On Thu, Feb 8, 2024, 10:32 AM Georg Voss wrote: > Hello, > > I'm not sure if this is the correct mai

[Net] Mode Z for FTP

2024-02-08 Thread Georg Voss
Hello, I'm not sure if this is the correct mailing list for this topic, but we would like to implement "MODE Z" for the FTP client implementation inside the commons.net component. We are using this library to retrieve data from wind energy plants in Germany. Some of them provide the data only

[ANNOUNCEMENT] Apache Commons Net 3.10.0

2023-10-06 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.10.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, and Whois

[RESULT][VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-05 Thread Gary Gregory
ave fixed a few bugs and added some enhancements since Apache > > Commons Net 3.9.0 was released, so I would like to release Apache > > Commons Net 3.10.0. > > > > Apache Commons Net 3.10.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/com

Re: [VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-05 Thread Gary Gregory
My +1 Gary On Sun, Oct 1, 2023 at 9:48 AM Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Net 3.9.0 was released, so I would like to release Apache > Commons Net 3.10.0. > > Apache Commons Net 3.10.0 RC1 is availab

Re: [VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-02 Thread Henri Biestro
Builds ok, tests ok, site ok: [+1] Nitpick: no coverage report in site (using mvn site), Spotbugs report a tad verbose hbiestro@hbiestro-MBP16 commons-net-3.10.0-RC1 % uname -a Darwin hbiestro-MBP16 22.6.0 Darwin Kernel Version 22.6.0: Fri Sep 15 13:41:28 PDT 2023; root:xnu-8796.141.3.700.8~1

Re: [VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-01 Thread Phil Steitz
some enhancements since Apache > Commons Net 3.9.0 was released, so I would like to release Apache > Commons Net 3.10.0. > > Apache Commons Net 3.10.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/net/3.10.0-RC1 (svn > revision 64282) > >

Re: [VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-01 Thread Bruno Kinoshita
[x] +1 Release these artifacts Building OK, tests passing, site generated OK, reports look good. Bruno On Sun, 1 Oct 2023 at 15:48, Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache > Commons Net 3.9.0 was released, so I would like to release

[VOTE] Release Apache Commons Net 3.10.0 based on RC1

2023-10-01 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons Net 3.9.0 was released, so I would like to release Apache Commons Net 3.10.0. Apache Commons Net 3.10.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.10.0-RC1 (svn revision 64282

[ANNOUCE] Apache Commons Net 3.9.0

2022-12-02 Thread Gary Gregory
The Apache Commons team is pleased to announce the release of Apache Commons Net 3.9.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, Whois Maintenance and

[VOTE][RESULT] Release Apache Commons Net 3.9.0 based on RC1

2022-12-01 Thread Gary Gregory
uite a few bugs and added some enhancements since Apache > > Commons Net 3.8.0 was released, so I would like to release Apache Commons > > Net 3.9.0. > > > > Apache Commons Net 3.9.0 RC1 is available for review here: > > https://dist.apache.org/repos/dist/dev/com

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-12-01 Thread Gary Gregory
My +1 Gary On Sat, Nov 26, 2022 at 10:02 PM Gary Gregory wrote: > > We have fixed quite a few bugs and added some enhancements since Apache > Commons Net 3.8.0 was released, so I would like to release Apache Commons Net > 3.9.0. > > Apache Commons Net 3.9.0 RC1 is availab

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-12-01 Thread sebb
t;mac os x", version: "10.16", arch: "x86_64", family: "mac" Sebb On Sun, 27 Nov 2022 at 03:02, Gary Gregory wrote: > > We have fixed quite a few bugs and added some enhancements since Apache > Commons Net 3.8.0 was released, so I would like to release A

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-12-01 Thread Gary D. Gregory
We need more reviews please. Gary On 2022/11/29 21:32:31 Gary Gregory wrote: > Ping ;-) > > Gary > > On Sat, Nov 26, 2022, 22:02 Gary Gregory wrote: > > > We have fixed quite a few bugs and added some enhancements since Apache > > Commons Net 3.8.0 was releas

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-12-01 Thread Gary D. Gregory
We need more reviews please. Gary On 2022/11/29 21:32:31 Gary Gregory wrote: > Ping ;-) > > Gary > > On Sat, Nov 26, 2022, 22:02 Gary Gregory wrote: > > > We have fixed quite a few bugs and added some enhancements since Apache > > Commons Net 3.8.0 was releas

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-11-29 Thread Gary Gregory
Ping ;-) Gary On Sat, Nov 26, 2022, 22:02 Gary Gregory wrote: > We have fixed quite a few bugs and added some enhancements since Apache > Commons Net 3.8.0 was released, so I would like to release Apache Commons > Net 3.9.0. > > Apache Commons Net 3.9.0 RC1 is available

Re: [VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-11-28 Thread Bruno Kinoshita
right now. Checked signatures of sources and binaries in dist area, manually inspected a couple files from the dist area. Everything looking OK. Thanks! Bruno On Sun, 27 Nov 2022 at 04:02, Gary Gregory wrote: > We have fixed quite a few bugs and added some enhancements since Apache > Commons

[VOTE] Release Apache Commons Net 3.9.0 based on RC1

2022-11-26 Thread Gary Gregory
We have fixed quite a few bugs and added some enhancements since Apache Commons Net 3.8.0 was released, so I would like to release Apache Commons Net 3.9.0. Apache Commons Net 3.9.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.9.0-RC1 (svn revision

Re: [commons-net] branch master updated: Fix broken build due to RAT failure

2022-03-31 Thread sebb
On Thu, 31 Mar 2022 at 14:31, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-net.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [net] IMAP Memory considerations with large ‘FETCH’ sizes.

2022-01-24 Thread Gilles Sadowski
Hello. [Cc to the "dev" ML.] Le lun. 24 janv. 2022 à 06:05, Josh a écrit : > > I tried that, to reach the [net] mailing list but it didn’t work Your message did reach the ML; see it in the archive: https://markmail.org/message/xerlcemds4ro43nn > so I opened an enha

[net] IMAP Memory considerations with large ‘FETCH’ sizes.

2022-01-23 Thread Josh
IMAP Memory considerations with large ‘FETCH’ sizes. The following comments concern classes in the [org.apache.common.net.imap](https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/imap/package-summary.html) package. Consider the following imap ‘fetch’ exchange between

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Xeno Amess
I see the codes. have no idea whether it cause the ci fail, but I do think the codes there be wrong. bug fixed provided at https://issues.apache.org/jira/projects/NET/issues/NET-708?filter=reportedbyme please check it, thanks. Xeno Amess 于2022年1月1日周六 21:12写道: > WAIT, I see codes in comm

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Xeno Amess
WAIT, I see codes in commons-net then really found several in date format... Might they be the troubler? https://ericasadun.com/2018/12/25/iso-8601---and-why-your-year-may-be-wrong/ IMAPExportMbox POP3ExportMbox Xeno Amess 于2022年1月1日周六 21:06写道: > something break the last week

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Xeno Amess
something break the last week of a year and works the next year... a smell of thing. Gary Gregory 于2022年1月1日周六 20:56写道: > Good: We are back to green builds on GitHub > https://github.com/apache/commons-net/actions and Jenkins. > > Gary > > On Sat, Jan 1, 2022 at 7:

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Gary Gregory
Good: We are back to green builds on GitHub https://github.com/apache/commons-net/actions and Jenkins. Gary On Sat, Jan 1, 2022 at 7:46 AM Gary Gregory wrote: > Wow, so there is some odd set up in the test that does not account for > being run near the start of a year! > > Gary >

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Gary Gregory
> > > > > > 991b775f2052e150c4c16d1c1cd2073021d40c2e is the first bad commit > > > commit 991b775f2052e150c4c16d1c1cd2073021d40c2e > > > Author: Sebb > > > Date: Wed Dec 15 00:18:48 2021 + > > > > > > Prevent serialization > > > >

Re: [net] Build broken by commit "Prevent serialization"

2022-01-01 Thread Gilles Sadowski
alization > > > > It is not useful and is unlikely to work properly. > > > > src/changes/changes.xml | 4 > > .../apache/commons/net/ProtocolCommandSupport.java | 18 > > +++++++++- > > .../java/o

Re: [net] Build broken by commit "Prevent serialization"

2021-12-31 Thread Gilles Sadowski
the first bad commit > commit 991b775f2052e150c4c16d1c1cd2073021d40c2e > Author: Sebb > Date: Wed Dec 15 00:18:48 2021 + > > Prevent serialization > > It is not useful and is unlikely to work properly. > > src/changes/changes.xml

[net] Build broken by commit "Prevent serialization"

2021-12-31 Thread Gary Gregory
15 00:18:48 2021 + Prevent serialization It is not useful and is unlikely to work properly. src/changes/changes.xml | 4 .../apache/commons/net/ProtocolCommandSupport.java | 18 +- .../java/org/apache/commons/net/ftp/FTPFile.java

Re: [commons-net] branch master updated: Prevent serialization

2021-12-15 Thread sebb
> Date: Tue, Dec 14, 2021 at 7:19 PM > Subject: [commons-net] branch master updated: Prevent serialization > To: comm...@commons.apache.org > > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a commit to branch master > in reposi

Fwd: [commons-net] branch master updated: Prevent serialization

2021-12-14 Thread Gary Gregory
Why not import java.io.ObjectOutputStream instead of always using the fully qualified class name? Gary -- Forwarded message - From: Date: Tue, Dec 14, 2021 at 7:19 PM Subject: [commons-net] branch master updated: Prevent serialization To: comm...@commons.apache.org This is an

Re: [commons-net] branch master updated: Javadoc 17 does not like empty paras

2021-08-01 Thread Gary Gregory
ot like empty paras > 719771a is described below > > commit 719771affb6a01756e21c620b26b886859c119ae > Author: Sebb > AuthorDate: Mon Aug 2 00:27:57 2021 +0100 > > Javadoc 17 does not like empty paras > --- > .../java/org/apache/commons/net/SocketClient.java | 50 > +++--

Re: [NET] Issues with FTPSClientTest and JKS files

2021-08-01 Thread sebb
On Thu, 29 Jul 2021 at 14:22, sebb wrote: > > On Thu, 29 Jul 2021 at 13:43, Gary Gregory wrote: > > > > On Tue, Jul 27, 2021 at 7:38 PM sebb wrote: > > > > > > On Tue, 27 Jul 2021 at 16:05, sebb wrote: > > > > > > > > Something strange is going on with the FTPSClientTest. > > > > > > > > One my

Re: [NET] Issues with FTPSClientTest and JKS files

2021-07-29 Thread sebb
On Thu, 29 Jul 2021 at 13:43, Gary Gregory wrote: > > On Tue, Jul 27, 2021 at 7:38 PM sebb wrote: > > > > On Tue, 27 Jul 2021 at 16:05, sebb wrote: > > > > > > Something strange is going on with the FTPSClientTest. > > > > > > One my macOS system, the original jks file works with all my Java >

Re: [NET] Issues with FTPSClientTest and JKS files

2021-07-29 Thread Gary Gregory
On Tue, Jul 27, 2021 at 7:38 PM sebb wrote: > > On Tue, 27 Jul 2021 at 16:05, sebb wrote: > > > > Something strange is going on with the FTPSClientTest. > > > > One my macOS system, the original jks file works with all my Java > > installations: > > Java 8 (Oracle and AdoptOpenJDK) > > Java 11 (

Re: [NET] Issues with FTPSClientTest and JKS files

2021-07-27 Thread sebb
On Tue, 27 Jul 2021 at 16:05, sebb wrote: > > Something strange is going on with the FTPSClientTest. > > One my macOS system, the original jks file works with all my Java > installations: > Java 8 (Oracle and AdoptOpenJDK) > Java 11 (Oracle and AdoptOpenJDK) > Java 15 (Oracle) > Java 16 (AdoptOpe

Re: [commons-net] branch master updated: More debug

2021-07-27 Thread Gary Gregory
described below > > commit 4e7a2386943dc4bb2f3c888493e4e2015eabf99a > Author: Sebb > AuthorDate: Tue Jul 27 17:39:18 2021 +0100 > > More debug > --- > .../org/apache/commons/net/ftp/FTPSClientTest.java | 39 > +- > 1 file changed, 24 insertions(+),

[NET] Issues with FTPSClientTest and JKS files

2021-07-27 Thread sebb
Something strange is going on with the FTPSClientTest. One my macOS system, the original jks file works with all my Java installations: Java 8 (Oracle and AdoptOpenJDK) Java 11 (Oracle and AdoptOpenJDK) Java 15 (Oracle) Java 16 (AdoptOpenJDK) With the jre8.jks, only Java8 works; the others all fa

Re: [commons-net] 03/04: Some resources created with Java 8 cannot be used in Java 16. Provide scripts to create keystores for Java 8 up to Java 15, and for Java 16 and up. The FTPSClientTest class st

2021-07-26 Thread sebb
: Remote host terminated the handshake For me, AOJ 16 works fine with ftpserver.jks.old, as do all the other versions mentioned above. It looks like the new JKS files only have a single entry, whereas the original had two. > > --- > > pom.xml

Re: [commons-net] 03/04: Some resources created with Java 8 cannot be used in Java 16. Provide scripts to create keystores for Java 8 up to Java 15, and for Java 16 and up. The FTPSClientTest class st

2021-07-26 Thread sebb
a relatively rare event, the simplest solution to the above issues would be to include instructions in the FTPSClientTest.java file instead. - java 11 now fails when testing - ftpserver.jks.old should be deleted > --- > pom.xml

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Gary Gregory
rnd wrote: > > > > Hello, > > > > > > > The test code appears to select TLSV1.2. > > > > > > > https://github.com/apache/commons-net/blob/fd06a81fd4ea3ace33d397935c76a4e014088fa2/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java#L103 &g

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
On Mon, 26 Jul 2021 at 17:43, Bernd wrote: > > Hello, > > > > The test code appears to select TLSV1.2. > > > https://github.com/apache/commons-net/blob/fd06a81fd4ea3ace33d397935c76a4e014088fa2/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java#L103 > > &

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Bernd
Hello, > The test code appears to select TLSV1.2. https://github.com/apache/commons-net/blob/fd06a81fd4ea3ace33d397935c76a4e014088fa2/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java#L103 the test code seems to limit the client to TLS1 only. Not sure why it does that, if

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
d > > > -- > http://bernd.eckenfels.net > > Von: Gary Gregory > Gesendet: Monday, July 26, 2021 2:57:35 PM > An: sebb > Cc: CommonsDev > Betreff: Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11 > > Hm, there might be some sy

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Bernd Eckenfels
Von: Gary Gregory Gesendet: Monday, July 26, 2021 2:57:35 PM An: sebb Cc: CommonsDev Betreff: Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11 Hm, there might be some system property to set that says "use this old and now deprecated algorithm" or we

Re: [NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread Gary Gregory
Hm, there might be some system property to set that says "use this old and now deprecated algorithm" or we might have to recreate any certificates used in tests with a current JDK 8. Gary On Mon, Jul 26, 2021, 08:42 sebb wrote: > As the subject says: FTPSClientTest fails with > > javax.net.ssl

[NET] FTPSClientTest fails on AdoptOpenJDK 8 & 11

2021-07-26 Thread sebb
As the subject says: FTPSClientTest fails with javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate) when run with AdoptOpenJDK 8 & 11 However it works fine with the Oracle version of Java 8 & 11 @Gary Gregory : I think you wrote t

[ANNOUNCEMENT] Apache Commons Net 3.8.0

2021-02-20 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.8.0. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, Whois Maintenance

[VOTE][RESULT] Release Apache Commons Net 3.8.0 based on RC1

2021-02-19 Thread Gary Gregory
inor releases, no blockers. > > Thanks Gary! > > Bruno > > > On Sunday, 14 February 2021, 4:45:33 am NZDT, Gary Gregory < > ggreg...@apache.org> wrote: > > We have fixed a few bugs and added enhancements since Apache Commons Net > 3.7.2 was released, so I

Re: [VOTE] Release Apache Commons Net 3.8.0 based on RC1

2021-02-18 Thread Bruno P. Kinoshita
inor releases, no blockers. Thanks Gary! Bruno On Sunday, 14 February 2021, 4:45:33 am NZDT, Gary Gregory wrote: We have fixed a few bugs and added enhancements since Apache Commons Net 3.7.2 was released, so I would like to release Apache Commons Net 3.8.0. Apache Commons Net 3.

Re: [VOTE] Release Apache Commons Net 3.8.0 based on RC1

2021-02-17 Thread Rob Tompkins
13, 2021, at 10:45 AM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons Net > 3.7.2 was released, so I would like to release Apache Commons Net 3.8.0. > > > > Apache Commons Net 3.8.0 RC1 is available for review here: > &

Re: [VOTE] Release Apache Commons Net 3.8.0 based on RC1

2021-02-16 Thread Gary Gregory
5 AM Gary Gregory wrote: > >> We have fixed a few bugs and added enhancements since Apache Commons Net >> 3.7.2 was released, so I would like to release Apache Commons Net 3.8.0. >> >> >> >> Apache Commons Net 3.8.0 RC1 is available for review here: >> &

Re: [VOTE] Release Apache Commons Net 3.8.0 based on RC1

2021-02-13 Thread Gary Gregory
This: I have tested this with the Maven default goal 'mvn clean' using:... Should read: I have tested this with the Maven default goal 'mvn' using:... On Sat, Feb 13, 2021 at 10:45 AM Gary Gregory wrote: > We have fixed a few bugs and added enhancements since Apache

[VOTE] Release Apache Commons Net 3.8.0 based on RC1

2021-02-13 Thread Gary Gregory
We have fixed a few bugs and added enhancements since Apache Commons Net 3.7.2 was released, so I would like to release Apache Commons Net 3.8.0. Apache Commons Net 3.8.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.8.0-RC1 (svn revision 46074

[ANNOUNCE] Apache Commons Net 3.7.2.

2020-10-18 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.7.2. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, Whois Maintenance

[VOTE][RESULT] Release Apache Commons Net 3.7.2 based on RC1

2020-10-17 Thread Gary Gregory
w bugs since Apache Commons Net 3.7.1 was released, so >> I would like to release Apache Commons Net 3.7.2. >> >> Apache Commons Net 3.7.2 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/net/3.7.2-RC1 (svn >> revision 41933) >

Re: [VOTE] Release Apache Commons Net 3.7.2 based on RC1

2020-10-17 Thread Gary Gregory
My +1 Gary On Wed, Oct 14, 2020 at 12:19 PM Gary Gregory wrote: > We have fixed a few bugs since Apache Commons Net 3.7.1 was released, so I > would like to release Apache Commons Net 3.7.2. > > Apache Commons Net 3.7.2 RC1 is available for review here: > https://dist.a

Re: [VOTE] Release Apache Commons Net 3.7.2 based on RC1

2020-10-16 Thread Rob Tompkins
+1 Signatures Check out Java8 build checks out Java11 build checks out site reports all look good, RAT good > On Oct 14, 2020, at 12:19 PM, Gary Gregory wrote: > > We have fixed a few bugs since Apache Commons Net 3.7.1 was released, so I > would like to release Apache Commo

Re: [VOTE] Release Apache Commons Net 3.7.2 based on RC1

2020-10-14 Thread Bruno P. Kinoshita
Thursday, 15 October 2020, 5:20:05 am NZDT, Gary Gregory wrote: We have fixed a few bugs since Apache Commons Net 3.7.1 was released, so I would like to release Apache Commons Net 3.7.2. Apache Commons Net 3.7.2 RC1 is available for review here:     https://dist.apache.org/repos/dist/dev/commons

[VOTE] Release Apache Commons Net 3.7.2 based on RC1

2020-10-14 Thread Gary Gregory
We have fixed a few bugs since Apache Commons Net 3.7.1 was released, so I would like to release Apache Commons Net 3.7.2. Apache Commons Net 3.7.2 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/net/3.7.2-RC1 (svn revision 41933) The Git tag commons-net

[NET] Release 3.7.2 soonish

2020-10-13 Thread Gary Gregory
FYI: I think I'd like to create a release candidate for 2.7.2 to deploy three recent fixes. Gary

[ANNOUCE] Apache Commons Net 3.7.1

2020-10-04 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.7.1. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, Whois Maintenance

Re: [ANNOUNCE] Apache Commons Net 3.7.1

2020-10-04 Thread Gary Gregory
On Sun, Oct 4, 2020 at 9:23 AM sebb wrote: > On Sun, 4 Oct 2020 at 00:12, Gary Gregory wrote: > > > > > Download page: > > > https://commons.apache.org/proper/commons-net/download_validator.cgi > > > > > Spot the error? > > > > I do now:

Re: [ANNOUNCE] Apache Commons Net 3.7.1

2020-10-04 Thread sebb
On Sun, 4 Oct 2020 at 00:12, Gary Gregory wrote: > > > Download page: > > https://commons.apache.org/proper/commons-net/download_validator.cgi > > > Spot the error? > > I do now: > > https://github.com/apache/commons-net/commit/2782592e9

Re: [ANNOUNCE] Apache Commons Net 3.7.1

2020-10-03 Thread Gary Gregory
> Download page: > https://commons.apache.org/proper/commons-net/download_validator.cgi > Spot the error? I do now: https://github.com/apache/commons-net/commit/2782592e9528c873545131f5e1a4f43400f1629f#diff-eaaddda9313ede01b93c08bf91532881 Gary On Sat, Oct 3, 2020, 18:44 sebb wro

Re: [ANNOUNCE] Apache Commons Net 3.7.1

2020-10-03 Thread sebb
On Sat, 3 Oct 2020 at 17:39, Gary Gregory wrote: > > The Apache Commons Net team is pleased to announce the release of Apache > Commons Net 3.7.1. > > Apache Commons Net library contains a collection of network utilities and > protocol implementations. > Supported protocols

[ANNOUNCE] Apache Commons Net 3.7.1

2020-10-03 Thread Gary Gregory
The Apache Commons Net team is pleased to announce the release of Apache Commons Net 3.7.1. Apache Commons Net library contains a collection of network utilities and protocol implementations. Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Telnet, Whois Maintenance

[VOTE][RESULT] Release Apache Commons Net 3.7.1 based on RC2

2020-10-02 Thread Gary Gregory
latize this script for future release >> valication. >> >> -Rob >> >> > On Sep 30, 2020, at 12:45 AM, Gary Gregory wrote: >> > >> > *[The difference between RC1 and RC2 is that pom.xml fil**le's* *version >> > has been fixed to be 3

Re: [VOTE] Release Apache Commons Net 3.7.1 based on RC2

2020-10-02 Thread Gary Gregory
> has been fixed to be 3.7.1 instead of 3.7.1-SNAPSHOT.]* > > > > We have fixed one regression bug since Apache Commons Net 3.7 was > released, > > so I would like to release Apache Commons Net 3.7.1. > > > > Apache Commons Net 3.7.1 RC2 is available for

Re: [VOTE] Release Apache Commons Net 3.7.1 based on RC2

2020-10-01 Thread Rob Tompkins
. -Rob > On Sep 30, 2020, at 12:45 AM, Gary Gregory wrote: > > *[The difference between RC1 and RC2 is that pom.xml fil**le's* *version > has been fixed to be 3.7.1 instead of 3.7.1-SNAPSHOT.]* > > We have fixed one regression bug since Apache Commons Net 3.7 was release

Re: [VOTE] Release Apache Commons Net 3.7.1 based on RC2

2020-09-30 Thread Bruno P. Kinoshita
been fixed to be 3.7.1 instead of 3.7.1-SNAPSHOT.]* We have fixed one regression bug since Apache Commons Net 3.7 was released, so I would like to release Apache Commons Net 3.7.1. Apache Commons Net 3.7.1 RC2 is available for review here:     https://dist.apache.org/repos/dist/dev/commons/net/3.7.

[VOTE] Release Apache Commons Net 3.7.1 based on RC2

2020-09-29 Thread Gary Gregory
*[The difference between RC1 and RC2 is that pom.xml fil**le's* *version has been fixed to be 3.7.1 instead of 3.7.1-SNAPSHOT.]* We have fixed one regression bug since Apache Commons Net 3.7 was released, so I would like to release Apache Commons Net 3.7.1. Apache Commons Net 3.7.1 R

  1   2   3   4   5   6   7   8   9   >