This should be the only outstanding error. I have attached updated patches
for the MillerRegression and RegressionResults.
On Wed, Jul 20, 2011 at 2:02 PM, Luc Maisonobe wrote:
> Le 20/07/2011 20:45, Greg Sterijevski a écrit :
>
> The errors concern the copy of the reference I am making. In the
Le 20/07/2011 20:45, Greg Sterijevski a écrit :
The errors concern the copy of the reference I am making. In the constructor
of the RegressionResults object there is the boolean flag "copyData".This
governs whether the user wants to store a copy of the data or just a copy of
the references. What
The errors concern the copy of the reference I am making. In the constructor
of the RegressionResults object there is the boolean flag "copyData".This
governs whether the user wants to store a copy of the data or just a copy of
the references. What I had hoped to do is avoid copying potentially lar
On 7/20/11 9:56 AM, Greg Sterijevski wrote:
> Having discovered the check-results.xml file, I will work through them
> all... (the ones I contributed). -Greg
Thanks, Greg!
The easiest way to check everything is to run "mvn site" from the
root of the full checkout and then look at the reports in t
Le 20/07/2011 18:56, Greg Sterijevski a écrit :
Having discovered the check-results.xml file, I will work through them
all... (the ones I contributed). -Greg
You may also want to have a look at the findbugs report. There are only
a few problems (2 or 3 if I remember correctly), related to stor
Having discovered the check-results.xml file, I will work through them
all... (the ones I contributed). -Greg
On Wed, Jul 20, 2011 at 10:27 AM, Greg Sterijevski
wrote:
> Yes, sorry about the mess I created. I will go back and add the javadoc.
>
> -Greg
>
>
> On Wed, Jul 20, 2011 at 8:58 AM, Phil
Yes, sorry about the mess I created. I will go back and add the javadoc.
-Greg
On Wed, Jul 20, 2011 at 8:58 AM, Phil Steitz wrote:
> Ack. All of the warnings are either missing javadoc or exception string
> warnings. I was holding off fixing the latter until we had a couple of
> impls to comp
Ack. All of the warnings are either missing javadoc or exception string
warnings. I was holding off fixing the latter until we had a couple of impls
to compare so we could see the full range of errors we were likely to see. I
can probably do that now, though. Will add to the thread on regres
Hello all,
Is seems there are many checkstyle and findbugs warnings in the
RegressionResults and MillerUpdatingRegression classes. They are mainly
missing javadoc, but also hard-coded exception messages and storing
array references in classes.
Greg, I think you provided the patch, could you
