Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-21 Thread Phil Steitz
On 12/21/15 1:21 PM, Ole Ersoy wrote: > > > On 12/21/2015 01:45 PM, Phil Steitz wrote: >> On 12/21/15 12:26 PM, Ole Ersoy wrote: Should look like this, with some typos fixed: /** ... * @throws MatrixDimensionMismatchException if the dimensions of

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-21 Thread Ole Ersoy
On 12/21/2015 01:45 PM, Phil Steitz wrote: On 12/21/15 12:26 PM, Ole Ersoy wrote: Should look like this, with some typos fixed: /** ... * @throws MatrixDimensionMismatchException if the dimensions of * {@code destination} do not match those of {@code this}. * @throws N

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-21 Thread Phil Steitz
On 12/21/15 12:26 PM, Ole Ersoy wrote: >> Should look like this, with some typos fixed: >> >> /** >> ... >> * @throws MatrixDimensionMismatchException if the dimensions of >> * {@code destination} do not match those of {@code this}. >> * @throws NumberIsTooSmallException if {@co

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-21 Thread Ole Ersoy
Should look like this, with some typos fixed: /** ... * @throws MatrixDimensionMismatchException if the dimensions of * {@code destination} do not match those of {@code this}. * @throws NumberIsTooSmallException if {@code endRow < startRow} or * {@code endColumn < startCo

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-21 Thread Phil Steitz
On 12/18/15 4:20 PM, Ole Ersoy wrote: > > > On 12/18/2015 04:07 PM, Phil Steitz wrote: >> On 12/18/15 2:59 PM, Ole Ersoy wrote: >>> I think it makes sense. If the destination array is too small, >>> throw an IAE. >> Right. That is what the implementations do - it is just a >> specialized IAE. We

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Ole Ersoy
On 12/18/2015 04:07 PM, Phil Steitz wrote: On 12/18/15 2:59 PM, Ole Ersoy wrote: I think it makes sense. If the destination array is too small, throw an IAE. Right. That is what the implementations do - it is just a specialized IAE. We decided a while back not to throw "raw" IAE but to use

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Phil Steitz
On 12/18/15 2:59 PM, Ole Ersoy wrote: > I think it makes sense. If the destination array is too small, > throw an IAE. Right. That is what the implementations do - it is just a specialized IAE. We decided a while back not to throw "raw" IAE but to use things like MatrixDimensionMismatchExceptio

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Ole Ersoy
I think it makes sense. If the destination array is too small, throw an IAE. Perhaps the implementations need to be updated. I'm attempting to modularize the linear package ATM so I'll have a closer look. Cheers, - Ole On 12/18/2015 01:31 PM, Phil Steitz wrote: It does not look to me like

Re: [math] Updated FieldMatrix exceptions thrown to match javadoc.

2015-12-18 Thread Phil Steitz
It does not look to me like any implementation we have of this interface actually throws raw IAE anywhere. I think maybe it is the javadoc that is wrong. On 12/18/15 4:47 AM, l...@apache.org wrote: > Repository: commons-math > Updated Branches: > refs/heads/master abb205795 -> 5566a21d2 > > > U