Re: [math] Negative max in class Incrementor

2015-08-30 Thread Ole Ersoy
On 08/30/2015 04:13 PM, Gilles wrote: On Sun, 30 Aug 2015 14:45:19 -0500, Ole Ersoy wrote: On 08/30/2015 08:18 AM, Gilles wrote: Hi. On Sat, 29 Aug 2015 22:21:55 -0500, Ole Ersoy wrote: I'm deleting most of the discussion, because I think I may be throwing too many ingredients on the table.

Re: [math] Negative max in class Incrementor

2015-08-30 Thread Gilles
On Sun, 30 Aug 2015 14:45:19 -0500, Ole Ersoy wrote: On 08/30/2015 08:18 AM, Gilles wrote: Hi. On Sat, 29 Aug 2015 22:21:55 -0500, Ole Ersoy wrote: I'm deleting most of the discussion, because I think I may be throwing too many ingredients on the table. For further context please see the prev

Re: [math] Negative max in class Incrementor

2015-08-30 Thread Ole Ersoy
On 08/30/2015 08:18 AM, Gilles wrote: Hi. On Sat, 29 Aug 2015 22:21:55 -0500, Ole Ersoy wrote: I'm deleting most of the discussion, because I think I may be throwing too many ingredients on the table. For further context please see the previous thread. I don't get that. Here the main purp

Re: [math] Negative max in class Incrementor

2015-08-30 Thread Gilles
Hi. On Sat, 29 Aug 2015 22:21:55 -0500, Ole Ersoy wrote: I'm deleting most of the discussion, because I think I may be throwing too many ingredients on the table. For further context please see the previous thread. I don't get that. Here the main purpose is to set a hard limit that will rais

Re: [math] Negative max in class Incrementor

2015-08-29 Thread Ole Ersoy
I'm deleting most of the discussion, because I think I may be throwing too many ingredients on the table. For further context please see the previous thread. I don't get that. Here the main purpose is to set a hard limit that will raise an exception (to avoid that some algo from running forev

Re: [math] Negative max in class Incrementor

2015-08-29 Thread Gilles
On Sat, 29 Aug 2015 15:56:38 -0500, Ole Ersoy wrote: On 08/29/2015 06:59 AM, Gilles wrote: On Fri, 28 Aug 2015 21:25:12 -0500, Ole Ersoy wrote: On 08/28/2015 04:29 PM, Gilles wrote: On Fri, 28 Aug 2015 11:48:28 -0500, Ole Ersoy wrote: This is a side note. In the class Incrementor there's a M

Re: [math] Negative max in class Incrementor

2015-08-29 Thread Ole Ersoy
On 08/29/2015 06:59 AM, Gilles wrote: On Fri, 28 Aug 2015 21:25:12 -0500, Ole Ersoy wrote: On 08/28/2015 04:29 PM, Gilles wrote: On Fri, 28 Aug 2015 11:48:28 -0500, Ole Ersoy wrote: This is a side note. In the class Incrementor there's a MaxCountExceededCallback that triggers the MaxCountEx

Re: [math] Negative max in class Incrementor

2015-08-29 Thread Gilles
On Fri, 28 Aug 2015 21:25:12 -0500, Ole Ersoy wrote: On 08/28/2015 04:29 PM, Gilles wrote: On Fri, 28 Aug 2015 11:48:28 -0500, Ole Ersoy wrote: This is a side note. In the class Incrementor there's a MaxCountExceededCallback that triggers the MaxCountExceededException. It might make sense to

Re: [math] Negative max in class Incrementor

2015-08-28 Thread Ole Ersoy
On 08/28/2015 04:29 PM, Gilles wrote: On Fri, 28 Aug 2015 11:48:28 -0500, Ole Ersoy wrote: This is a side note. In the class Incrementor there's a MaxCountExceededCallback that triggers the MaxCountExceededException. It might make sense to place the code that throws the exception in a static

Re: [math] Negative max in class Incrementor

2015-08-28 Thread Gilles
On Fri, 28 Aug 2015 11:48:28 -0500, Ole Ersoy wrote: This is a side note. In the class Incrementor there's a MaxCountExceededCallback that triggers the MaxCountExceededException. It might make sense to place the code that throws the exception in a static utility method inside the exception, elim

Re: [math] Negative max in class Incrementor

2015-08-28 Thread Ole Ersoy
This is a side note. In the class Incrementor there's a MaxCountExceededCallback that triggers the MaxCountExceededException. It might make sense to place the code that throws the exception in a static utility method inside the exception, eliminating the cb property, the MaxCountExceededCall

Re: [math] Negative max in class Incrementor

2015-08-28 Thread Gilles
On Fri, 28 Aug 2015 04:16:09 +0200, Gilles wrote: On Wed, 26 Aug 2015 23:03:36 +0200, Gilles wrote: Hi. On Wed, 26 Aug 2015 18:33:29 +0200, Cahangirova Gunel wrote: Dear all, Recently I have reported a bug (in my opinion) MATH-1259 in class Incrementor from the org.apache.commons.math4.util p

Re: [math] Negative max in class Incrementor

2015-08-27 Thread Gilles
On Wed, 26 Aug 2015 23:03:36 +0200, Gilles wrote: Hi. On Wed, 26 Aug 2015 18:33:29 +0200, Cahangirova Gunel wrote: Dear all, Recently I have reported a bug (in my opinion) MATH-1259 in class Incrementor from the org.apache.commons.math4.util package, as it is possible to pass a negative number

Re: [math] Negative max in class Incrementor

2015-08-26 Thread Gilles
Hi. On Wed, 26 Aug 2015 18:33:29 +0200, Cahangirova Gunel wrote: Dear all, Recently I have reported a bug (in my opinion) MATH-1259 in class Incrementor from the org.apache.commons.math4.util package, as it is possible to pass a negative number for the max variable. Given that the count variabl

[math] Negative max in class Incrementor

2015-08-26 Thread Cahangirova Gunel
Dear all, Recently I have reported a bug (in my opinion) MATH-1259 in class Incrementor from the org.apache.commons.math4.util package, as it is possible to pass a negative number for the max variable. Given that the count variable is initialised to 0 by default, it means that canIncrement() me