Re: [math] MathIllegalArgumentException

2013-10-27 Thread Gilles
> > [...] I am OK adding more types. I think the two I suggested above, SubsetSizeException and InsufficientDataException would be useful (along with precise messages and context data) in quite a few places to replace the less meaningful low-level ones. Are you both OK with me adding these and

Re: [math] MathIllegalArgumentException

2013-10-27 Thread Phil Steitz
On 10/27/13 7:29 AM, Gilles wrote: > On Sun, 27 Oct 2013 10:35:45 +0100, Luc Maisonobe wrote: >> Le 21/10/2013 22:58, Ted Dunning a écrit : >>> +1 >>> >>> The overwhelming standard practice is to use a plausible >>> exception type >>> (such as some form of IllegalArgumentException) with a message.

Re: [math] MathIllegalArgumentException

2013-10-27 Thread Gilles
On Sun, 27 Oct 2013 10:35:45 +0100, Luc Maisonobe wrote: Le 21/10/2013 22:58, Ted Dunning a écrit : +1 The overwhelming standard practice is to use a plausible exception type (such as some form of IllegalArgumentException) with a message. On Mon, Oct 21, 2013 at 5:24 PM, Phil Steitz wro

Re: [math] MathIllegalArgumentException

2013-10-27 Thread Luc Maisonobe
Le 21/10/2013 22:58, Ted Dunning a écrit : > +1 > > The overwhelming standard practice is to use a plausible exception type > (such as some form of IllegalArgumentException) with a message. > > > > > On Mon, Oct 21, 2013 at 5:24 PM, Phil Steitz wrote: > >> I hate to open this can of worms ag

Re: [math] MathIllegalArgumentException

2013-10-21 Thread Ted Dunning
+1 The overwhelming standard practice is to use a plausible exception type (such as some form of IllegalArgumentException) with a message. On Mon, Oct 21, 2013 at 5:24 PM, Phil Steitz wrote: > I hate to open this can of worms again, but the following is just > too painful for me to ignore.

[math] MathIllegalArgumentException

2013-10-21 Thread Phil Steitz
I hate to open this can of worms again, but the following is just too painful for me to ignore. From recent mods to BinomialConfidenceInterval javadoc: * @throws NumberIsTooLargeException if {@code numberOfSuccesses > numberOfTrials}. The "NumberIsTooLarge" exception adds exactly zero to w