Re: [math] Duplicate code in ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest

2012-05-31 Thread Luc Maisonobe
Le 31/05/2012 07:56, Sébastien Brisard a écrit : > Hello, > assuming that no answer meant no (strong) opposition, I took the > liberty to create MATH-795 [1]. This refactoring has already revealed > a problem (see r1344570 and r1344571). Fine, thanks Luc > > Best regards, > > Sébastien > > [1

Re: [math] Duplicate code in ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest

2012-05-30 Thread Sébastien Brisard
Hello, assuming that no answer meant no (strong) opposition, I took the liberty to create MATH-795 [1]. This refactoring has already revealed a problem (see r1344570 and r1344571). Best regards, Sébastien [1] https://issues.apache.org/jira/browse/MATH-795 2012/5/30 Sébastien Brisard : > Dear al

[math] Duplicate code in ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest

2012-05-29 Thread Sébastien Brisard
Dear all, while working on MATH-792 [1], I've noticed that the above mentioned tests contain a lot of duplicate code. Besides, some of the unit tests are no longer (in my opinion) unit tests, since they test many different functionalities. I would be tempted to refactor these tests. I've recently i