Re: [math] About MATH-849 and the NSWC library

2012-08-23 Thread Sébastien Brisard
Hi Thomas, thanks for reviewing. > > static final double HALF_LOG_2_PI is not used anymore > well spotted! I'll get rid of that. I'm also currently revisiting MATH-753, I would like to get rid of all things related to the Lanczos approximation (which is no longer used for Gamma, but still necessa

Re: [math] About MATH-849 and the NSWC library

2012-08-23 Thread Thomas Neidhart
On 08/22/2012 06:43 AM, Sébastien Brisard wrote: > Dear all, > please review the code I've attached to MATH-849. The improvement in > accuracy is great. I also implemented, besides logGamma(x), a new function > -- namely Gamma(x). > I would like to know if you feel the references to the NSWC librar

[math] About MATH-849 and the NSWC library

2012-08-21 Thread Sébastien Brisard
Dear all, please review the code I've attached to MATH-849. The improvement in accuracy is great. I also implemented, besides logGamma(x), a new function -- namely Gamma(x). I would like to know if you feel the references to the NSWC library is fair. Thanks for your advice, Sébastien PS : with th