On Wed, Jul 8, 2020 at 10:13 AM Gary Gregory wrote:
>
>
> On Wed, Jul 8, 2020, 09:32 Rob Tompkins wrote:
>
>>
>>
>> > On Jul 7, 2020, at 6:56 PM, Gary Gregory
>> wrote:
>> >
>> > In the PR https://github.com/apache/commons-lang/pull/559 I am going
>> with
>> > "LockingVistors".
>>
>> I like th
On Wed, Jul 8, 2020, 09:32 Rob Tompkins wrote:
>
>
> > On Jul 7, 2020, at 6:56 PM, Gary Gregory wrote:
> >
> > In the PR https://github.com/apache/commons-lang/pull/559 I am going
> with
> > "LockingVistors".
>
> I like this name because of its brevity yet clarity.
>
Let's go for that then. I'
> On Jul 7, 2020, at 6:56 PM, Gary Gregory wrote:
>
> In the PR https://github.com/apache/commons-lang/pull/559 I am going with
> "LockingVistors".
I like this name because of its brevity yet clarity.
-Rob
>
> Gary
>
> On Tue, Jul 7, 2020 at 2:33 PM Rob Tompkins wrote:
>
>> I’m not all
On Tue, Jul 7, 2020 at 10:22 PM Gary Gregory wrote:
> On Tue, Jul 7, 2020 at 7:14 PM Matt Sicker wrote:
>
>> JCIP seems to call this idea a monitor, but that’s also the general
>> implicit locking mechanism in Java.
>>
>
FTR, that's JCIP section 4.2.1 (in my edition).
Gary
>
> Hi Matt,
>
> Ri
On Tue, Jul 7, 2020 at 7:14 PM Matt Sicker wrote:
> JCIP seems to call this idea a monitor, but that’s also the general
> implicit locking mechanism in Java.
>
Hi Matt,
Right, and it is tempting to rename LockingVisitors.AbstractLockVisitor's
'object' ivar to 'monitor' but that is somewhat misl
JCIP seems to call this idea a monitor, but that’s also the general
implicit locking mechanism in Java.
On Tue, Jul 7, 2020 at 17:56 Gary Gregory wrote:
> Typo: LockingVisitors.
>
> On Tue, Jul 7, 2020 at 6:56 PM Gary Gregory
> wrote:
>
> > In the PR https://github.com/apache/commons-lang/pull
Typo: LockingVisitors.
On Tue, Jul 7, 2020 at 6:56 PM Gary Gregory wrote:
> In the PR https://github.com/apache/commons-lang/pull/559 I am going
> with "LockingVistors".
>
> Gary
>
> On Tue, Jul 7, 2020 at 2:33 PM Rob Tompkins wrote:
>
>> I’m not all that familiar with that area of academia. L
In the PR https://github.com/apache/commons-lang/pull/559 I am going with
"LockingVistors".
Gary
On Tue, Jul 7, 2020 at 2:33 PM Rob Tompkins wrote:
> I’m not all that familiar with that area of academia. Let me see what I
> can dig up
>
> -Rob
>
> > On Jul 7, 2020, at 2:19 PM, Matt Sicker wro
I’m not all that familiar with that area of academia. Let me see what I can dig
up
-Rob
> On Jul 7, 2020, at 2:19 PM, Matt Sicker wrote:
>
> Are there any academic references for this? Or even something from
> Java Concurrency in Practice? Those are good sources for names around
> concurrency.
Are there any academic references for this? Or even something from
Java Concurrency in Practice? Those are good sources for names around
concurrency.
On Tue, 7 Jul 2020 at 12:42, Rob Tompkins wrote:
>
> Why not make the name “ThreadedLambdaSynchronizer” or something like
> that….just something m
Why not make the name “ThreadedLambdaSynchronizer” or something like that….just
something more descriptive here that get’s closer to what the intended
functionality is.
That said, I’m not particularly tied to the name “ThreadedLambdaSynchronizer”
just spitballing here for something more descrip
Now that starts to sound like Apache Groovy or Kotlin.
On Mon, 29 Jun 2020 at 11:58, Xeno Amess wrote:
>
> soemtimes I really wish to rewrite/add some functions in jdk directly...
> especially for reusing some package private static functions...
>
> Gary Gregory 于2020年6月30日周二 上午12:01写道：
>
> > I'
soemtimes I really wish to rewrite/add some functions in jdk directly...
especially for reusing some package private static functions...
Gary Gregory 于2020年6月30日周二 上午12:01写道：
> I'm not sure talking to the JDK folks is helpful IMO. We are still
> targeting Java 8. The customers I deal with are mi
I'm not sure talking to the JDK folks is helpful IMO. We are still
targeting Java 8. The customers I deal with are migrating from 8 to 11, and
Java 11 is not everywhere our customers are. So talking about something
that might end up in Java... 25 seems to be not in our user's best or
immediate inte
At first look, I’m a little surprised we’re trying to take on this
functionality. Has anyone reached out to the JDK guys to see if they’d be
interested in having it in the JDK? That said, if we approach it from that
path, we would lose the functionality in older versions of java. So maybe I
jus
The 'Locks' class is in master. My PR is in my 1st message.
Gary
On Fri, Jun 26, 2020 at 5:27 PM Miguel Muñoz wrote:
> The "lockedObject" might be better named "lockableObject." That way it
> makes no assumptions about its current state. Building on this, the class
> might be called Lockable.
>
The "lockedObject" might be better named "lockableObject." That way it
makes no assumptions about its current state. Building on this, the class
might be called Lockable.
However, I also like the idea of calling the class Locker, as in a gym
locker. The idea is that it holds something important. O
Hi All:
I know email is a challenging medium for code reviews, so please consider
these comments coming from my best intentions, constructive and caring ;-)
Also please excuse the meandering nature of this post.
The new class org.apache.commons.lang3.concurrent.Locks.Lock needs better
names IMO,
18 matches
Mail list logo
