Re: [lang] New Streams code breaks build

2020-02-07 Thread Alex Herbert
> On 7 Feb 2020, at 21:04, Alex Herbert wrote: > > > >> On 7 Feb 2020, at 21:02, Jochen Wiedmann wrote: >> >> Hi, Alex, >> >> On Tue, Feb 4, 2020 at 10:06 PM Alex Herbert >> wrote: >> >>> Travis just uses ‘mvn’. This triggers the default goal in the pom which >>> does this: >> >> Tha

Re: [lang] New Streams code breaks build

2020-02-07 Thread Alex Herbert
> On 7 Feb 2020, at 21:02, Jochen Wiedmann wrote: > > Hi, Alex, > > On Tue, Feb 4, 2020 at 10:06 PM Alex Herbert wrote: > >> Travis just uses ‘mvn’. This triggers the default goal in the pom which does >> this: > > Thanks for the information. I wasn't even aware, that there is a default g

Re: [lang] New Streams code breaks build

2020-02-07 Thread Jochen Wiedmann
Hi, Alex, On Tue, Feb 4, 2020 at 10:06 PM Alex Herbert wrote: > Travis just uses ‘mvn’. This triggers the default goal in the pom which does > this: Thanks for the information. I wasn't even aware, that there is a default goal. > I did note when I had a look that the main javadoc gives the e

Re: [lang] New Streams code breaks build

2020-02-04 Thread Alex Herbert
> On 4 Feb 2020, at 19:36, Jochen Wiedmann wrote: > > On Mon, Feb 3, 2020 at 3:57 PM Gary Gregory wrote: > >> The commit >> https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=2ea44b2adae8da8e3e7f55cc226479f9431feda9 >> broke >> the Travis build due to Checktyle errors. > > As

Re: [lang] New Streams code breaks build

2020-02-04 Thread Jochen Wiedmann
On Mon, Feb 3, 2020 at 3:57 PM Gary Gregory wrote: > The commit > https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=2ea44b2adae8da8e3e7f55cc226479f9431feda9 > broke > the Travis build due to Checktyle errors. As the responsible person, I apologize for that. I am sure, that I did

Re: [lang] New Streams code breaks build

2020-02-04 Thread Alex Herbert
On 04/02/2020 09:56, Peter Verhas wrote: It also breaks all the pull requests and I am not sure that Travis on GitHub gives it a try again when the master changes. What is the expected procedure? Should I push a null change commit to the branch to trigger Travis after the master is fixed? How s

Re: [lang] New Streams code breaks build

2020-02-04 Thread Peter Verhas
It also breaks all the pull requests and I am not sure that Travis on GitHub gives it a try again when the master changes. What is the expected procedure? Should I push a null change commit to the branch to trigger Travis after the master is fixed? How should I know when the master is fixed? Should

[lang] New Streams code breaks build

2020-02-03 Thread Gary Gregory
Hi, The commit https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=commit;h=2ea44b2adae8da8e3e7f55cc226479f9431feda9 broke the Travis build due to Checktyle errors. Please fix. Gary