Re: [lang] LANG-686 Recursive call of replaceEachRepeatedly

2011-08-02 Thread Henri Yandell
On Sat, Jul 30, 2011 at 2:27 AM, Henri Yandell wrote: > On Fri, Jul 29, 2011 at 8:27 AM, Gary Gregory wrote: >> Hi Hen, >> >> I am not really comfortable knowing that a SOE can be a "normal" code >> path. It would have to be Javadoc'd to boot. >> >> I can see catching IllegalStateException and Il

Re: [lang] LANG-686 Recursive call of replaceEachRepeatedly

2011-07-30 Thread Henri Yandell
On Fri, Jul 29, 2011 at 8:27 AM, Gary Gregory wrote: > Hi Hen, > > I am not really comfortable knowing that a SOE can be a "normal" code > path. It would have to be Javadoc'd to boot. > > I can see catching IllegalStateException and IllegalArgumentException > in client code, especially in a server

Re: [lang] LANG-686 Recursive call of replaceEachRepeatedly

2011-07-29 Thread Gary Gregory
Hi Hen, I am not really comfortable knowing that a SOE can be a "normal" code path. It would have to be Javadoc'd to boot. I can see catching IllegalStateException and IllegalArgumentException in client code, especially in a server or a processor of some kind, but to do that for SOE feels wrong.

Re: [lang] LANG-686 Recursive call of replaceEachRepeatedly

2011-07-28 Thread Henri Yandell
Anyone against just letting users get a StackOverflowError? https://issues.apache.org/jira/browse/LANG-686 Hen On Tue, Jul 26, 2011 at 11:42 PM, Henri Yandell wrote: > I'm wondering what people think to: > >    https://issues.apache.org/jira/browse/LANG-686 > > I've improved the message of the

[lang] LANG-686 Recursive call of replaceEachRepeatedly

2011-07-26 Thread Henri Yandell
I'm wondering what people think to: https://issues.apache.org/jira/browse/LANG-686 I've improved the message of the thrown exception to match the javadoc, but I'm wondering if a TTL of 2 to protect a StackOverflowError is really necessary :) I have the urge to throw in 64, or 512, or some ran