Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Duncan Jones
On 17 September 2012 20:26, Duncan Jones wrote: > On 17 September 2012 19:39, Gary Gregory wrote: >> On Mon, Sep 17, 2012 at 2:27 PM, Matt Benson wrote: >> >>> On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones >>> wrote: >>> > On 17 September 2012 19:13, Duncan Jones wrote: >>> >> On 17 September

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Duncan Jones
On 17 September 2012 19:39, Gary Gregory wrote: > On Mon, Sep 17, 2012 at 2:27 PM, Matt Benson wrote: > >> On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones >> wrote: >> > On 17 September 2012 19:13, Duncan Jones wrote: >> >> On 17 September 2012 19:07, Gary Gregory >> wrote: >> >>> On Mon, Sep 17

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Gary Gregory
On Mon, Sep 17, 2012 at 2:27 PM, Matt Benson wrote: > On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones > wrote: > > On 17 September 2012 19:13, Duncan Jones wrote: > >> On 17 September 2012 19:07, Gary Gregory > wrote: > >>> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson > wrote: > >>> > Hell

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Gary Gregory
On Mon, Sep 17, 2012 at 2:19 PM, Duncan Jones wrote: > On 17 September 2012 19:13, Duncan Jones wrote: > > On 17 September 2012 19:07, Gary Gregory wrote: > >> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson > wrote: > >> > >>> Hello, > >>> We'd love to have our whole testsuite updated to JUnit

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Matt Benson
On Mon, Sep 17, 2012 at 1:19 PM, Duncan Jones wrote: > On 17 September 2012 19:13, Duncan Jones wrote: >> On 17 September 2012 19:07, Gary Gregory wrote: >>> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson wrote: >>> Hello, We'd love to have our whole testsuite updated to JUnit 4, IMO.

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Duncan Jones
On 17 September 2012 19:13, Duncan Jones wrote: > On 17 September 2012 19:07, Gary Gregory wrote: >> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson wrote: >> >>> Hello, >>> We'd love to have our whole testsuite updated to JUnit 4, IMO. The >>> only thing is that as a rule we'd rather that chang

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Duncan Jones
On 17 September 2012 19:07, Gary Gregory wrote: > On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson wrote: > >> Hello, >> We'd love to have our whole testsuite updated to JUnit 4, IMO. The >> only thing is that as a rule we'd rather that changeset be separate >> from another, so I'd recommend provi

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Gary Gregory
On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson wrote: > Hello, > We'd love to have our whole testsuite updated to JUnit 4, IMO. The > only thing is that as a rule we'd rather that changeset be separate > from another, so I'd recommend providing multiple patches, possibly > submitted in separate

Re: [lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Matt Benson
Hello, We'd love to have our whole testsuite updated to JUnit 4, IMO. The only thing is that as a rule we'd rather that changeset be separate from another, so I'd recommend providing multiple patches, possibly submitted in separate JIRA issues. Matt On Mon, Sep 17, 2012 at 12:59 PM, Duncan Jon

[lang] Etiquette regarding updating test classes to use JUnit 4 annotations

2012-09-17 Thread Duncan Jones
Hi, While working on a patch for LANG-799, I ran into a problem where I couldn't use JUnit4 Assume.* methods because the DateUtilsTest.java extends TestCase (forcing JUnit3 behaviour), rather than using JUnit4 annotations. Is it rude to adjust this class to use JUnit4 annotations? There seem to b